From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
Liviu Dudau <Liviu.Dudau@arm.com>,
dri-devel@lists.freedesktop.org,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCH] drm: Do not set connector->encoder in drivers
Date: Mon, 16 Nov 2015 17:46:46 +0000 [thread overview]
Message-ID: <20151116174646.GS8644@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1447694393-24700-1-git-send-email-thierry.reding@gmail.com>
On Mon, Nov 16, 2015 at 06:19:53PM +0100, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> An encoder is associated with a connector by the DRM core as a result of
> setting up a configuration. Drivers using the atomic or legacy helpers
> should never set up this link, even if it is a static one.
>
> While at it, try to catch this kind of error in the future by adding a
> WARN_ON() in drm_mode_connector_attach_encoder(). Note that this doesn't
> cover all the cases, since drivers could set this up after attaching.
> Drivers that use the atomic helpers will get a warning later on, though,
> so hopefully the two combined cover enough to help people avoid this in
> the future.
I'm pretty sure that when I started out writing armada-drm,
pre-initialising the connector's encoder was required, otherwise
DRM would oops. Has something changed which makes a NULL pointer
there at initialisation always safe?
--
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2015-11-16 17:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-16 17:19 [PATCH] drm: Do not set connector->encoder in drivers Thierry Reding
2015-11-16 17:46 ` Russell King - ARM Linux [this message]
2015-11-17 10:43 ` Daniel Vetter
2015-11-17 10:29 ` Liviu Dudau
2016-01-13 11:47 ` Liviu Dudau
2016-01-13 12:31 ` Daniel Vetter
2015-11-17 10:46 ` Daniel Vetter
2015-11-17 14:58 ` Jani Nikula
2015-11-17 16:16 ` Daniel Vetter
2016-01-14 18:54 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151116174646.GS8644@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=Liviu.Dudau@arm.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox