From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 1/2] drm: Avoid calling the cursor_set2 callback from the drm_mode_cursor ioctl Date: Fri, 27 Nov 2015 11:11:33 +0100 Message-ID: <20151127101133.GW17050@phenom.ffwll.local> References: <1448563935-3157-1-git-send-email-thellstrom@vmware.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-f43.google.com (mail-wm0-f43.google.com [74.125.82.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id E71B26E26D for ; Fri, 27 Nov 2015 02:11:38 -0800 (PST) Received: by wmuu63 with SMTP id u63so49468495wmu.0 for ; Fri, 27 Nov 2015 02:11:37 -0800 (PST) Content-Disposition: inline In-Reply-To: <1448563935-3157-1-git-send-email-thellstrom@vmware.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Thomas Hellstrom Cc: airlied@redhat.com, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBOb3YgMjYsIDIwMTUgYXQgMTA6NTI6MTRBTSAtMDgwMCwgVGhvbWFzIEhlbGxzdHJv bSB3cm90ZToKPiBJZiB0aGUgZHJtX21vZGVfY3Vyc29yX2lvY3RsIGlzIGNhbGxlZCBhbmQgdGhl IGN1cnNvcl9zZXQyIGNhbGxiYWNrIGlzCj4gaW1wbGVtZW50ZWQsIHRoZSBjdXJzb3IgaG90c3Bv dCBpcyBzZXQgdG8gKDAsMCkgd2hpY2ggaXMgaW5jb21wYXRpYmxlCj4gd2l0aCB2bXdnZnggd2hl cmUgdGhlIGhvdHNwb3Qgc2hvdWxkIGluc3RlYWQgcmVtYWluIHVuY2hhbmdlZC4KPiAKPiBTbyBp ZiB0aGUgZHJpdmVyIGltcGxlbWVudHMgYm90aCBjdXJzb3Jfc2V0MiBhbmQgY3Vyc29yX3NldCwg cHJlZmVyIGNhbGxpbmcKPiB0aGUgbGF0dGVyIGZyb20gdGhlIGRybV9tb2RlX2N1cnNvciBpb2N0 bC4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBUaG9tYXMgSGVsbHN0cm9tIDx0aGVsbHN0cm9tQHZtd2Fy ZS5jb20+CgpUaGF0IGxvb2tzIGxpa2UgcGFwZXJpbmcgb3ZlciBhIGJ1ZyBpbiB0aGUgY2xpZW50 IC0gaXQgc2ltcGx5IHNob3VsZG4ndAptaXggdGhlc2UgdHdvIGlmIGl0IGV4cGVjdHMgdGhlIGhv dHNwb3QgdG8gc3RpY2sgYXJvdW5kLiBUaGVyZSB3YXMgYWxzbwpyZWNlbnRseSBhIGJpZyBkaXNj dXNzaW9uIGFib3V0IGhvdHNwb3QgYmVoYXZpb3VyLCBhbmQgdGhlIGNvbmNsdXNpb24gd2FzCnRo YXQgcXhsIGdvdCBpdCBhbGwgd3JvbmcuIFNpbmNlIHRoYXQgd2FzIHNwZWNpZmljYWxseSBhZGRl ZCBmb3IgcXhsIEknbQpub3Qgc3VyZSBob3cgd2VsbCB0aGlzIHdhcyBldmVyIHRlc3RlZCAuLi4K ClRoZSBvdGhlciBwcm9ibGVtIHNlZW1zIHRvIGJlIHRoYXQgWCBpcyByYWN5IHdpdGggdXBkYXRp bmcgY3Vyc29ycyAoc2luY2UKaXQgZG9lcyBhIHNldFBvcyBhbmQgc2V0Q3Vyc29yIHNlcGFyYXRl bHksIGRlc3BpdGUgdGhhdCB0aGlzIGlvY3RsIGNhbiBkbwppdCBpbiBvbmUgZ28pIGFuZCBzbyBp ZiB5b3UgbW92ZSB0aGUgaG90c3BvdCB5b3UgZ2V0IGEganVtcHkgY3Vyc29yLgpSYWRlb24gdHJp ZWQgdG8gcGFwZXIgb3ZlciB0aGF0IGJ1dCBmdW5kYW1lbnRhbGx5IHlvdSBuZWVkIHRvIGZpeCBY IGFuZAp1c2UgYXRvbWljIChvciBhdCBsZWFzdCB1bml2ZXJzYWwgcGxhbmUgY3Vyc29yIHN1cHBv cnQpIHRvIGZpeCB0aGlzLgoKR2l2ZW4gYWxsIHRoYXQgSSdtIGxlYW5pbmcgdG93YXJkcyAidGhl IGZ1dHVyZSBpcyBhdG9taWMiLCBsZXQncyBwbGVhc2UKbm90IGFkZCBoYWNrcyB0byBsZWdhY3kg Y29kZS4gQXNpZGU6IEF0b21pYyBkb2Vzbid0IGhhdmUgdGhlIGhvdHNwb3QteC95CnByb3BlcnRp ZXMgeWV0LCBidXQgcmVhbGx5IHRoZSBvbmx5IHJlYXNvbiB3YXMgdGhhdCB3ZSBkb24ndCB5ZXQg aGF2ZSBhbgphdG9taWMgZHJpdmVyIG5lZWRpbmcgdGhlbS4gQWRkaW5nIHRob3NlIHByb3BzIHdp bGwgYmUgYSB0aW55IHBhdGNoIG9mIGEKZmV3IGxpbmVzLgoKQ2hlZXJzLCBEYW5pZWwKPiAtLS0K PiAgZHJpdmVycy9ncHUvZHJtL2RybV9jcnRjLmMgfCAxMCArKysrKystLS0tCj4gIDEgZmlsZSBj aGFuZ2VkLCA2IGluc2VydGlvbnMoKyksIDQgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvZ3B1L2RybS9kcm1fY3J0Yy5jIGIvZHJpdmVycy9ncHUvZHJtL2RybV9jcnRjLmMK PiBpbmRleCAyNGM1NDM0Li45M2Y4MGE1IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9k cm1fY3J0Yy5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV9jcnRjLmMKPiBAQCAtMjg3NCw3 ICsyODc0LDggQEAgc3RhdGljIGludCBkcm1fbW9kZV9jdXJzb3JfdW5pdmVyc2FsKHN0cnVjdCBk cm1fY3J0YyAqY3J0YywKPiAgCj4gIHN0YXRpYyBpbnQgZHJtX21vZGVfY3Vyc29yX2NvbW1vbihz dHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+ICAJCQkJICBzdHJ1Y3QgZHJtX21vZGVfY3Vyc29yMiAq cmVxLAo+IC0JCQkJICBzdHJ1Y3QgZHJtX2ZpbGUgKmZpbGVfcHJpdikKPiArCQkJCSAgc3RydWN0 IGRybV9maWxlICpmaWxlX3ByaXYsCj4gKwkJCQkgIGJvb2wgZnJvbV8yKQo+ICB7Cj4gIAlzdHJ1 Y3QgZHJtX2NydGMgKmNydGM7Cj4gIAlpbnQgcmV0ID0gMDsKPiBAQCAtMjkwNyw3ICsyOTA4LDgg QEAgc3RhdGljIGludCBkcm1fbW9kZV9jdXJzb3JfY29tbW9uKHN0cnVjdCBkcm1fZGV2aWNlICpk ZXYsCj4gIAkJCWdvdG8gb3V0Owo+ICAJCX0KPiAgCQkvKiBUdXJucyBvZmYgdGhlIGN1cnNvciBp ZiBoYW5kbGUgaXMgMCAqLwo+IC0JCWlmIChjcnRjLT5mdW5jcy0+Y3Vyc29yX3NldDIpCj4gKwkJ aWYgKGNydGMtPmZ1bmNzLT5jdXJzb3Jfc2V0MiAmJgo+ICsJCSAgICAoZnJvbV8yIHx8ICFjcnRj LT5mdW5jcy0+Y3Vyc29yX3NldCkpCj4gIAkJCXJldCA9IGNydGMtPmZ1bmNzLT5jdXJzb3Jfc2V0 MihjcnRjLCBmaWxlX3ByaXYsIHJlcS0+aGFuZGxlLAo+ICAJCQkJCQkgICAgICByZXEtPndpZHRo LCByZXEtPmhlaWdodCwgcmVxLT5ob3RfeCwgcmVxLT5ob3RfeSk7Cj4gIAkJZWxzZQo+IEBAIC0y OTUzLDcgKzI5NTUsNyBAQCBpbnQgZHJtX21vZGVfY3Vyc29yX2lvY3RsKHN0cnVjdCBkcm1fZGV2 aWNlICpkZXYsCj4gIAltZW1jcHkoJm5ld19yZXEsIHJlcSwgc2l6ZW9mKHN0cnVjdCBkcm1fbW9k ZV9jdXJzb3IpKTsKPiAgCW5ld19yZXEuaG90X3ggPSBuZXdfcmVxLmhvdF95ID0gMDsKPiAgCj4g LQlyZXR1cm4gZHJtX21vZGVfY3Vyc29yX2NvbW1vbihkZXYsICZuZXdfcmVxLCBmaWxlX3ByaXYp Owo+ICsJcmV0dXJuIGRybV9tb2RlX2N1cnNvcl9jb21tb24oZGV2LCAmbmV3X3JlcSwgZmlsZV9w cml2LCBmYWxzZSk7Cj4gIH0KPiAgCj4gIC8qKgo+IEBAIC0yOTc2LDcgKzI5NzgsNyBAQCBpbnQg ZHJtX21vZGVfY3Vyc29yMl9pb2N0bChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+ICB7Cj4gIAlz dHJ1Y3QgZHJtX21vZGVfY3Vyc29yMiAqcmVxID0gZGF0YTsKPiAgCj4gLQlyZXR1cm4gZHJtX21v ZGVfY3Vyc29yX2NvbW1vbihkZXYsIHJlcSwgZmlsZV9wcml2KTsKPiArCXJldHVybiBkcm1fbW9k ZV9jdXJzb3JfY29tbW9uKGRldiwgcmVxLCBmaWxlX3ByaXYsIHRydWUpOwo+ICB9Cj4gIAo+ICAv KioKPiAtLSAKPiAyLjQuMwo+IAo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCj4gZHJpLWRldmVsIG1haWxpbmcgbGlzdAo+IGRyaS1kZXZlbEBsaXN0cy5m cmVlZGVza3RvcC5vcmcKPiBodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz dGluZm8vZHJpLWRldmVsCgotLSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50 ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2 ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFp bG1hbi9saXN0aW5mby9kcmktZGV2ZWwK