From: Daniel Vetter <daniel@ffwll.ch>
To: Jani Nikula <jani.nikula@intel.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm: keep connector status change logging human readable
Date: Fri, 4 Dec 2015 08:59:56 +0100 [thread overview]
Message-ID: <20151204075956.GU10243@phenom.ffwll.local> (raw)
In-Reply-To: <1449144003-2877-1-git-send-email-jani.nikula@intel.com>
On Thu, Dec 03, 2015 at 02:00:03PM +0200, Jani Nikula wrote:
> We've had human readable connector status change debug logging since
>
> commit ed7951dc13aad4a14695ec8122e9f0e2ef25d39e
> Author: Lespiau, Damien <damien.lespiau@intel.com>
> Date: Fri May 10 12:36:42 2013 +0000
>
> drm: Make the HPD status updates debug logs more readable
>
> but
>
> commit 162b6a57ac50eec236530a16c071ffa50e87362a
> Author: Daniel Vetter <daniel.vetter@ffwll.ch>
> Date: Wed Jan 21 08:45:21 2015 +0100
>
> drm/probe-helper: don't lose hotplug event
>
> added a new one with just the numbers. Fix it.
>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Applied to drm-misc, thanks.
-Daniel
> ---
> drivers/gpu/drm/drm_probe_helper.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_probe_helper.c b/drivers/gpu/drm/drm_probe_helper.c
> index 94ba39e34299..eee3b6f38cfb 100644
> --- a/drivers/gpu/drm/drm_probe_helper.c
> +++ b/drivers/gpu/drm/drm_probe_helper.c
> @@ -168,10 +168,11 @@ static int drm_helper_probe_single_connector_modes_merge_bits(struct drm_connect
> * check here, and if anything changed start the hotplug code.
> */
> if (old_status != connector->status) {
> - DRM_DEBUG_KMS("[CONNECTOR:%d:%s] status updated from %d to %d\n",
> + DRM_DEBUG_KMS("[CONNECTOR:%d:%s] status updated from %s to %s\n",
> connector->base.id,
> connector->name,
> - old_status, connector->status);
> + drm_get_connector_status_name(old_status),
> + drm_get_connector_status_name(connector->status));
>
> /*
> * The hotplug event code might call into the fb
> --
> 2.1.4
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2015-12-04 8:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-03 12:00 [PATCH] drm: keep connector status change logging human readable Jani Nikula
2015-12-04 7:59 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151204075956.GU10243@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox