dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thierry Reding <thierry.reding@gmail.com>
To: Emil Velikov <emil.l.velikov@gmail.com>
Cc: Hyungwon Hwang <human.hwang@samsung.com>,
	ML dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH libdrm 01/10] tests: Split helpers into library
Date: Mon, 14 Dec 2015 09:12:00 +0100	[thread overview]
Message-ID: <20151214081200.GA10055@ulmo.nvidia.com> (raw)
In-Reply-To: <CACvgo51wB+dUdWfmh5MZjaOtjy2Md2Dsurukqn8f-gB6JTro0w@mail.gmail.com>


[-- Attachment #1.1: Type: text/plain, Size: 2479 bytes --]

On Sat, Dec 12, 2015 at 03:26:09PM +0000, Emil Velikov wrote:
> Hi Thierry, all,
> 
> On 9 December 2015 at 17:37, Thierry Reding <thierry.reding@gmail.com> wrote:
> > From: Thierry Reding <treding@nvidia.com>
> >
> > Some of the helpers, such as the pattern drawing helpers or the format
> > lookup helpers, have potential to be reused. Move them into a separate
> > library to make it easier to share them.
> >
> > Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > Signed-off-by: Thierry Reding <treding@nvidia.com>
> > ---
> >  CleanSpec.mk                |   1 +
> >  configure.ac                |   1 +
> >  tests/Makefile.am           |   2 +-
> >  tests/modeprint/Makefile.am |   1 +
> >  tests/modeprint/modeprint.c |   2 +-
> >  tests/modetest/Android.mk   |   1 +
> >  tests/modetest/Makefile.am  |   8 +-
> >  tests/modetest/buffers.c    | 961 +-------------------------------------------
> >  tests/modetest/buffers.h    |  12 +-
> >  tests/modetest/cursor.c     |   4 +-
> >  tests/modetest/modetest.c   |  25 +-
> >  tests/proptest/Makefile.am  |   4 +-
> >  tests/proptest/proptest.c   |   3 +-
> >  tests/util/Android.mk       |  39 ++
> >  tests/util/Makefile.am      |  13 +
> >  tests/util/Makefile.sources |   6 +
> >  tests/util/common.h         |  33 ++
> >  tests/util/format.c         | 120 ++++++
> >  tests/util/format.h         |  65 +++
> >  tests/util/pattern.c        | 870 +++++++++++++++++++++++++++++++++++++++
> >  tests/util/pattern.h        |  39 ++
> >  tests/vbltest/Makefile.am   |   1 +
> >  tests/vbltest/vbltest.c     |   2 +-
> >  23 files changed, 1223 insertions(+), 990 deletions(-)
> >  create mode 100644 tests/util/Android.mk
> >  create mode 100644 tests/util/Makefile.am
> >  create mode 100644 tests/util/Makefile.sources
> >  create mode 100644 tests/util/common.h
> >  create mode 100644 tests/util/format.c
> >  create mode 100644 tests/util/format.h
> >  create mode 100644 tests/util/pattern.c
> >  create mode 100644 tests/util/pattern.h
> >
> As mentioned on IRC, although there might be some minor nitpicks I'd
> rather the series in those in and fix them later. Mostly to avoid the
> long gap until you get the chance to respin things, but also to spare
> Tomi (and others) the need to reinvent them :-)

I don't mind doing another round if you point out the nitpicks. I'm
hopeful that I'll get around to respinning sooner this time. =)

Thierry

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2015-12-14  8:12 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-09 17:37 [PATCH libdrm 01/10] tests: Split helpers into library Thierry Reding
2015-12-09 17:37 ` [PATCH libdrm 02/10] tests: Move name tables to libutil Thierry Reding
2015-12-09 17:37 ` [PATCH libdrm 03/10] proptest: Add Android support Thierry Reding
2015-12-09 17:37 ` [PATCH libdrm 04/10] tests: Add libkms-test library Thierry Reding
2015-12-09 17:37 ` [PATCH libdrm 05/10] tests: kms: Implement CRTC stealing test Thierry Reding
2015-12-09 17:37 ` [PATCH libdrm 06/10] tests: kms: Implement universal planes test Thierry Reding
2015-12-09 17:37 ` [PATCH libdrm 07/10] tests: Add helper to open a device/module Thierry Reding
2015-12-09 17:37 ` [PATCH libdrm 08/10] modetest: Use util_open() Thierry Reding
2015-12-09 17:37 ` [PATCH libdrm 09/10] proptest: " Thierry Reding
2015-12-09 17:37 ` [PATCH libdrm 10/10] vbltest: " Thierry Reding
2015-12-12 15:26 ` [PATCH libdrm 01/10] tests: Split helpers into library Emil Velikov
2015-12-14  8:12   ` Thierry Reding [this message]
2015-12-14 13:10     ` Emil Velikov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151214081200.GA10055@ulmo.nvidia.com \
    --to=thierry.reding@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=emil.l.velikov@gmail.com \
    --cc=human.hwang@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox