dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: dri-devel@lists.freedesktop.org,
	Christian Gmeiner <christian.gmeiner@gmail.com>
Subject: re: drm/etnaviv: add initial etnaviv DRM driver
Date: Thu, 24 Dec 2015 10:30:24 +0300	[thread overview]
Message-ID: <20151224073024.GF29642@mwanda> (raw)

Hello The etnaviv authors,

The patch a8c21a5451d8: "drm/etnaviv: add initial etnaviv DRM driver"
from Dec 3, 2015, leads to the following static checker warning:

	drivers/gpu/drm/etnaviv/etnaviv_gpu.c:254 etnaviv_hw_identify()
	warn: masked condition '(((chipIdentity) << 24) & 4278190080) == 1' is always false.

drivers/gpu/drm/etnaviv/etnaviv_gpu.c
   247  static void etnaviv_hw_identify(struct etnaviv_gpu *gpu)
   248  {
   249          u32 chipIdentity;
   250  
   251          chipIdentity = gpu_read(gpu, VIVS_HI_CHIP_IDENTITY);
   252  
   253          /* Special case for older graphic cores. */
   254          if (VIVS_HI_CHIP_IDENTITY_FAMILY(chipIdentity) ==  0x01) {
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Not possibly true.

   255                  gpu->identity.model    = 0x500; /* gc500 */
   256                  gpu->identity.revision = VIVS_HI_CHIP_IDENTITY_REVISION(chipIdentity);
   257          } else {
   258  

regards,
dan carpenter
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

                 reply	other threads:[~2015-12-24  7:30 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151224073024.GF29642@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=christian.gmeiner@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox