From: Daniel Vetter <daniel@ffwll.ch>
To: Daniel Stone <daniel@fooishbar.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
Daniel Stone <daniels@collabora.com>,
DRI Development <dri-devel@lists.freedesktop.org>
Subject: Re: [Intel-gfx] [PATCH 4/5] drm/atomic-helper: Reject legacy flips on a disabled pipe
Date: Tue, 5 Jan 2016 10:02:08 +0100 [thread overview]
Message-ID: <20160105090208.GL8076@phenom.ffwll.local> (raw)
In-Reply-To: <CAPj87rMqhaTFq8puVPu_J6kvoGKH0QkcFeNeQdbf3sL_SdEzgA@mail.gmail.com>
On Tue, Dec 08, 2015 at 12:01:57PM +0000, Daniel Stone wrote:
> Hi,
>
> On 8 December 2015 at 08:49, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> > We want this for consistency with existing page_flip semantics.
> >
> > Since this spurred quite a discussion on IRC also document why we
> > reject even generation when the pipe is off: It's not that it's hard
> > to implement, but userspace has a track recording proofing that it's
> > way too easy to accidentally abuse and cause havoc. We want to make
> > sure userspace doesn't get away with that.
> >
> > v2: Somehow thought we do reject events already, but that code only
> > existed in my imagination ... Also suggestions from Thierry.
>
> What a beautifully-coloured shed.
>
> Reviewed-by: Daniel Stone <daniels@collabora.com>
Added Ilia's spelling fixes and merged to drm-misc, thanks for the review.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-01-05 9:02 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-08 8:49 [PATCH 1/5] [RFC] drm: Documentation style guide Daniel Vetter
2015-12-08 8:49 ` [PATCH 2/5] drm/atomic-helper: Drop unneeded argument from check_pending_encoder Daniel Vetter
2015-12-14 15:58 ` Thierry Reding
2015-12-08 8:49 ` [PATCH 3/5] drm: Move more framebuffer doc from docbook to kerneldoc Daniel Vetter
2015-12-14 15:58 ` Thierry Reding
2015-12-14 17:25 ` Daniel Vetter
2015-12-08 8:49 ` [PATCH 4/5] drm/atomic-helper: Reject legacy flips on a disabled pipe Daniel Vetter
2015-12-08 12:01 ` [Intel-gfx] " Daniel Stone
2016-01-05 9:02 ` Daniel Vetter [this message]
2015-12-08 13:55 ` Ilia Mirkin
2015-12-08 8:49 ` [PATCH 5/5] drm/tda998x: Remove dummy save/restore funcs Daniel Vetter
2015-12-08 9:30 ` Emil Velikov
2015-12-08 10:11 ` Daniel Vetter
2015-12-08 10:15 ` Russell King - ARM Linux
2015-12-08 15:29 ` Rodrigo Vivi
2015-12-08 9:59 ` [PATCH 1/5] [RFC] drm: Documentation style guide Pierre Moreau
2015-12-08 10:14 ` Daniel Vetter
2015-12-08 13:49 ` Laurent Pinchart
2015-12-09 10:41 ` [PATCH] " Daniel Vetter
2015-12-09 10:44 ` Daniel Vetter
2015-12-09 11:21 ` Jani Nikula
2015-12-09 12:35 ` Laurent Pinchart
2015-12-09 14:17 ` Jani Nikula
2015-12-09 14:32 ` Laurent Pinchart
2015-12-09 13:35 ` Daniel Vetter
2015-12-09 15:19 ` Lukas Wunner
2015-12-09 16:08 ` Daniel Vetter
2015-12-14 15:39 ` Thierry Reding
2015-12-15 14:56 ` Dave Gordon
2015-12-15 16:09 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160105090208.GL8076@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel@fooishbar.org \
--cc=daniels@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox