From: Daniel Vetter <daniel@ffwll.ch>
To: Benjamin Gaignard <benjamin.gaignard@linaro.org>
Cc: vincent.abriou@st.com, fabien.dessenne@st.com,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 3/5] drm: sti: set CRTC modesetting parameters
Date: Thu, 7 Jan 2016 14:52:11 +0100 [thread overview]
Message-ID: <20160107135211.GN8076@phenom.ffwll.local> (raw)
In-Reply-To: <1452173441-30033-4-git-send-email-benjamin.gaignard@linaro.org>
On Thu, Jan 07, 2016 at 02:30:39PM +0100, Benjamin Gaignard wrote:
> Set CRTC modesetting parameters to avoid warnings in atomic mode.
Hm, should we extend the documentation for the mode_fixup hooks that this
should be done? Care to submit a patch against drm-misc/linux-next (since
there's more doc work queued in there)?
Thanks, Daniel
>
> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@linaro.org>
> ---
> drivers/gpu/drm/sti/sti_crtc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/sti/sti_crtc.c b/drivers/gpu/drm/sti/sti_crtc.c
> index de11c7c..505620c 100644
> --- a/drivers/gpu/drm/sti/sti_crtc.c
> +++ b/drivers/gpu/drm/sti/sti_crtc.c
> @@ -56,6 +56,7 @@ static bool sti_crtc_mode_fixup(struct drm_crtc *crtc,
> struct drm_display_mode *adjusted_mode)
> {
> /* accept the provided drm_display_mode, do not fix it up */
> + drm_mode_set_crtcinfo(adjusted_mode, CRTC_INTERLACE_HALVE_V);
> return true;
> }
>
> --
> 1.9.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-01-07 13:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-07 13:30 [PATCH 0/5] sti fix to enable atomic modesetting Benjamin Gaignard
2016-01-07 13:30 ` [PATCH 1/5] drm: sti: fix potential crash in gdp Benjamin Gaignard
2016-01-07 13:30 ` [PATCH 2/5] drm: sti: add atomic get/set properties for planes Benjamin Gaignard
2016-01-07 13:50 ` Daniel Vetter
2016-01-07 14:05 ` Benjamin Gaignard
2016-01-07 14:47 ` Daniel Vetter
2016-01-13 8:53 ` Benjamin Gaignard
2016-01-13 8:58 ` Daniel Vetter
2016-01-07 13:30 ` [PATCH 3/5] drm: sti: set CRTC modesetting parameters Benjamin Gaignard
2016-01-07 13:52 ` Daniel Vetter [this message]
2016-01-07 13:30 ` [PATCH 4/5] drm: sti: fix cursor coordinates Benjamin Gaignard
2016-01-07 13:30 ` [PATCH 5/5] drm: sti: set DRIVER_ATOMIC for sti Benjamin Gaignard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160107135211.GN8076@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=benjamin.gaignard@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=fabien.dessenne@st.com \
--cc=vincent.abriou@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox