From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: Lockdep warning when using REGCACHE_RBTREE Date: Fri, 15 Jan 2016 11:49:46 +0000 Message-ID: <20160115114946.GV6588@sirena.org.uk> References: <20160115094541.GH3421@worktop> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0807857263==" Return-path: Received: from mezzanine.sirena.org.uk (mezzanine.sirena.org.uk [106.187.55.193]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0DA466EB5A for ; Fri, 15 Jan 2016 03:50:07 -0800 (PST) In-Reply-To: <20160115094541.GH3421@worktop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Peter Zijlstra Cc: dri-devel@lists.freedesktop.org, mingo@redhat.com, linux-kernel@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org --===============0807857263== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="R6pG8OF89Zv1WQ+4" Content-Disposition: inline --R6pG8OF89Zv1WQ+4 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Jan 15, 2016 at 10:45:41AM +0100, Peter Zijlstra wrote: > So _regmap_write() does: map->lock(map->lock_arg) > Which isn't very enlightening, since that can be a mutex or a spinlock, > the above strongly suggests spinlock though. > Looking at __regmap_init(), this seems to depend on: > (bus && bus->fast_io) || config->fast_io > now, afaict, regmap_mmio is used in this case, which has .fast_io = > true. > So yeah, fail. Indeed, that'd do it. It hadn't occurred to me that someone would be using MMIO with an rbtree cache. --R6pG8OF89Zv1WQ+4 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWmNzZAAoJECTWi3JdVIfQ73QH/RhD3lEdX/7aY8xlwKt1Qzoy Mk4TQpSDQ5y9H1R2frvyUThhm19T/a9kWZsBBMGc3S3M9ORo5GrBKlmFiFouysoQ 2zrKg4/cubMpN3u9Dq5nQ0JhRPWmAxN5TR6lCW25IryiwAIzkrg2REVZZni6G9dC LNCkJnA4X4uK2PNN2+L6XaKRMK5a+pCWe7NJgSSzhCRQFk/UT1/Md+CDaPlpfg1h cM7lpVmUuRJZg0fQMGBHDZj70ZIvMCsmCqNkOupctxSjwqSgxWJLRuWldYUjhXFn H3gKdlvTwJ+yM646KNcU9zj6DaXGwZV/zrBTdO458HWUKzZJ0Dgpq8BK6mTgkJ4= =WKoG -----END PGP SIGNATURE----- --R6pG8OF89Zv1WQ+4-- --===============0807857263== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK --===============0807857263==--