From: Daniel Vetter <daniel@ffwll.ch>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm: initialize default rotation value to DRM_ROTATE_0
Date: Tue, 19 Jan 2016 09:42:21 +0100 [thread overview]
Message-ID: <20160119084221.GP19130@phenom.ffwll.local> (raw)
In-Reply-To: <1453192008-13283-1-git-send-email-m.szyprowski@samsung.com>
On Tue, Jan 19, 2016 at 09:26:48AM +0100, Marek Szyprowski wrote:
> When no console framebuffer is enabled, the default plane state is
> defined by plane reset function. If driver uses generic helper, then
> rotation property is set to zero. This is not a valid value for that
> enum. This patch sets default rotation value to DRM_ROTATE_0.
>
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
Applied to drm-misc.
-Daniel
> ---
> drivers/gpu/drm/drm_atomic_helper.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atomic_helper.c
> index 268d37f26960..d0d4b2ff7c21 100644
> --- a/drivers/gpu/drm/drm_atomic_helper.c
> +++ b/drivers/gpu/drm/drm_atomic_helper.c
> @@ -2526,8 +2526,10 @@ void drm_atomic_helper_plane_reset(struct drm_plane *plane)
> kfree(plane->state);
> plane->state = kzalloc(sizeof(*plane->state), GFP_KERNEL);
>
> - if (plane->state)
> + if (plane->state) {
> plane->state->plane = plane;
> + plane->state->rotation = BIT(DRM_ROTATE_0);
> + }
> }
> EXPORT_SYMBOL(drm_atomic_helper_plane_reset);
>
> --
> 1.9.2
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2016-01-19 8:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-19 8:26 [PATCH] drm: initialize default rotation value to DRM_ROTATE_0 Marek Szyprowski
2016-01-19 8:42 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160119084221.GP19130@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=m.szyprowski@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox