From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Lucas Stach <l.stach@pengutronix.de>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/etnaviv: fix get pages error path in etnaviv_gem_vaddr
Date: Tue, 26 Jan 2016 16:45:52 +0000 [thread overview]
Message-ID: <20160126164552.GR10826@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1453823126-3899-1-git-send-email-l.stach@pengutronix.de>
On Tue, Jan 26, 2016 at 04:45:25PM +0100, Lucas Stach wrote:
> In case that etnaviv_gem_get_pages is unable to get the required
> pages the object mutex needs to be unlocked. Also return NULL in
> this case instead of propagating the error, as callers of this
> function might not be prepared to handle a pointer error, but
> expect this call to follow the semantics of a plain vmap to return
> NULL in case of an error.
If we're giving it vmap() semantics, then let's add another patch
which calls this function etnaviv_gem_vmap()...
--
RMK's Patch system: http://www.arm.linux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2016-01-26 16:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-26 15:45 [PATCH 1/2] drm/etnaviv: fix get pages error path in etnaviv_gem_vaddr Lucas Stach
2016-01-26 15:45 ` [PATCH 2/2] drm/etnaviv: call correct function when trying to vmap a DMABUF Lucas Stach
2016-01-26 16:48 ` Russell King - ARM Linux
2016-01-26 16:45 ` Russell King - ARM Linux [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160126164552.GR10826@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=dri-devel@lists.freedesktop.org \
--cc=l.stach@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).