From: Gustavo Padovan <gustavo@padovan.org>
To: Emil Velikov <emil.l.velikov@gmail.com>
Cc: devel@driverdev.osuosl.org,
"Daniel Stone" <daniels@collabora.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>,
"ML dri-devel" <dri-devel@lists.freedesktop.org>,
"Arve Hjønnevåg" <arve@android.com>,
"Daniel Vetter" <daniel.vetter@ffwll.ch>,
"Riley Andrews" <riandrews@android.com>,
"Gustavo Padovan" <gustavo.padovan@collabora.co.uk>,
"John Harrison" <John.C.Harrison@intel.com>
Subject: Re: [PATCH v2 01/11] dma-buf/sync_file: de-stage sync_file
Date: Wed, 27 Jan 2016 18:25:40 -0200 [thread overview]
Message-ID: <20160127202540.GD3773@joana> (raw)
In-Reply-To: <CACvgo52bp9FQO50REHMzqaqXnwdkTx2yjx_xiet2V_wQscuu1Q@mail.gmail.com>
Hi Emil,
2016-01-27 Emil Velikov <emil.l.velikov@gmail.com>:
> Hi Gustavo,
>
> On 27 January 2016 at 17:03, Gustavo Padovan <gustavo@padovan.org> wrote:
> > Hi Maarten,
> >
> > 2016-01-27 Maarten Lankhorst <maarten.lankhorst@linux.intel.com>:
> >
> >> Hey,
> >>
> >> Op 27-01-16 om 14:30 schreef Gustavo Padovan:
> >> > From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
> >> >
> >> > sync_file is useful to connect one or more fences to the file. The file is
> >> > used by userspace to track fences.
> >> >
> >> > Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
> >> >
> >> Is there a value in keeping the abi unchanged?
> >> If not, then Documentation/ioctl/botching-up-ioctls.txt is worth a read.
> >
> > None from me. I'll look where we can improve the ABI.
> >
> Speaking of ABI... there are a couple of things that rang bells here:
> - In most/all of the kernel a len/size named member variable
> indicates the length of the extra data (zero sized array). While here
> it includes the size of the struct as well.
len in this case is the size of the buffer sent to the kernel,
the total length (including the whole struct) is returned in the ioctl.
> - struct sync_file_info_data::fence_info is of type __u8 yet it is "a
> fence_info struct for every fence in the sync_file". Thus shouldn't
> one use "struct fence_info" as the type ?
Agreed. But I'm currently thinking if we really should keep this ioctl.
Gustavo
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-01-27 20:25 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-27 13:30 [PATCH v2 00/11] sync framework de-staging: part 2 - de-stage Gustavo Padovan
2016-01-27 13:30 ` [PATCH v2 01/11] dma-buf/sync_file: de-stage sync_file Gustavo Padovan
2016-01-27 14:31 ` Maarten Lankhorst
2016-01-27 17:03 ` Gustavo Padovan
2016-01-27 18:17 ` Emil Velikov
2016-01-27 20:25 ` Gustavo Padovan [this message]
2016-01-27 21:41 ` Greg Hackmann
2016-01-28 9:23 ` Daniel Vetter
2016-01-29 17:46 ` Greg Hackmann
2016-01-27 13:30 ` [PATCH v2 02/11] staging/android: store last signaled value on sync timeline Gustavo Padovan
2016-01-27 13:30 ` [PATCH v2 03/11] staging/android: remove .fill_driver_data() timeline ops Gustavo Padovan
2016-01-27 13:30 ` [PATCH v2 04/11] staging/android: remove .{fence, timeline}_value_str() from timeline_ops Gustavo Padovan
2016-01-27 13:30 ` [PATCH v2 05/11] staging/android: remove struct sync_timeline_ops Gustavo Padovan
2016-01-27 13:30 ` [PATCH v2 06/11] staging/android: remove sw_sync_timeline and sw_sync_pt Gustavo Padovan
2016-01-27 13:30 ` [PATCH v2 07/11] staging/android: remove sw_sync.[ch] files Gustavo Padovan
2016-01-27 13:30 ` [PATCH v2 08/11] staging/android: rename android_fence to timeline_fence Gustavo Padovan
2016-01-27 13:30 ` [PATCH v2 09/11] dma-buf/sync_timeline: de-stage sync_timeline Gustavo Padovan
2016-01-27 13:30 ` [PATCH v2 10/11] dma-buf/sync_file: bring debug back to sync file Gustavo Padovan
2016-01-27 13:30 ` [PATCH v2 11/11] dma-buf/sync_file: bring sync_dump() back Gustavo Padovan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160127202540.GD3773@joana \
--to=gustavo@padovan.org \
--cc=John.C.Harrison@intel.com \
--cc=arve@android.com \
--cc=daniel.vetter@ffwll.ch \
--cc=daniels@collabora.com \
--cc=devel@driverdev.osuosl.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=emil.l.velikov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=gustavo.padovan@collabora.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=riandrews@android.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).