From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH 7/7] drm/fsl-dcu: use mode flags for hsync/vsync pixelclk polarity Date: Wed, 3 Feb 2016 15:00:39 +0100 Message-ID: <20160203140039.GA9650@ulmo> References: <1447900970-15936-1-git-send-email-stefan@agner.ch> <1447900970-15936-8-git-send-email-stefan@agner.ch> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1184993633==" Return-path: Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46]) by gabe.freedesktop.org (Postfix) with ESMTPS id B6B6E6E3E0 for ; Wed, 3 Feb 2016 06:00:43 -0800 (PST) Received: by mail-wm0-f46.google.com with SMTP id 128so166790559wmz.1 for ; Wed, 03 Feb 2016 06:00:43 -0800 (PST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Stefan Agner Cc: alison.wang@freescale.com, daniel.vetter@ffwll.ch, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Shawn Guo List-Id: dri-devel@lists.freedesktop.org --===============1184993633== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="huq684BweRXVnRxX" Content-Disposition: inline --huq684BweRXVnRxX Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Jan 27, 2016 at 06:46:50PM -0800, Stefan Agner wrote: [...] > > diff --git a/drivers/gpu/drm/panel/panel-simple.c > > b/drivers/gpu/drm/panel/panel-simple.c > > index f97b73e..fa68b56 100644 > > --- a/drivers/gpu/drm/panel/panel-simple.c > > +++ b/drivers/gpu/drm/panel/panel-simple.c > > @@ -960,6 +960,8 @@ static const struct drm_display_mode > > nec_nl4827hc19_05b_mode = { > > .vsync_end = 272 + 2 + 4, > > .vtotal = 272 + 2 + 4 + 2, > > .vrefresh = 74, > > + .flags = DRM_MODE_FLAG_NVSYNC | DRM_MODE_FLAG_NHSYNC | > > + DISPLAY_FLAGS_PIXDATA_POSEDGE, It doesn't seem like these two types of flags should be mixed because they overlap. DISPLAY_FLAGS_PIXDATA_POSEDGE has the same value as the DRM_MODE_FLAG_CSYNC define. The definition of the DISPLAY_FLAGS_PIXDATA_POSEDGE is also not very clear to me. I don't think we have an equivalent DRM_MODE_FLAG_* but we could add one if there's really a need. Thierry --huq684BweRXVnRxX Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJWsggDAAoJEN0jrNd/PrOhD5QP/iHw/6viwkClFT5Iv5gOQnzV 86Tu/uZ3mQ+PwpuNHJzlNigyGKAJPCpbC80NkGvKu2/bjx1+eNUPJIi3T7OwhCd1 1buizoXZHIzuooH3/c8rHeKcVxf4JSSgCiNsaRNVMeSp3CBIQrDV7eKXSjZTmKca xEEU444UVZl2eb79Y+VkQCyPtTBEhN+/M5f+IZW91VfQlya7fa21FD7l7qLzWYHO 920ijVuWAfSWAuwrUE3RbUVzJb/iVeDaQ3YUS/Z/bc1alyAdOrhwFIM7DlpxNN0B whAYELH2qJ+N0zqMHnRPU1w2+EjPP8KGcQo0STNQOA7kPzPO8J+NhjdAmCax0XQo iGsqjNZqdQbVBgZuhusuKSG20qkt1dJzLsOpYiigXx1/ABOKYfS7JBZBY9KEs1lF omEtEYyFgCUWPqeGZRWsM84d+AjVEgFUog3XB7Ry6fPp4m4AfiyvtxVwPnvNTOkE lhn561ksUYzhrnxnnE+/lkJodd1M2xDCl4R7xDVwYQsednH0O8WuUyrW9sdQ1EXY r5HbPOoosZSrc6MkFB1hwZ6EwUUftVAhwyzoLsK6QdYH2ddEE8OePWZWeHOqTSsm OR121zt89dVVNQW5zJ/rFRcS251mXcLECqjSa5eBP3PzDCmuZUSVHxQMXDuv4OMV XKtH4eXUNGp2cBvgU/9E =es5L -----END PGP SIGNATURE----- --huq684BweRXVnRxX-- --===============1184993633== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK --===============1184993633==--