From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gustavo Padovan Subject: Re: [PATCH] staging/android: refactor SYNC_IOC_FILE_INFO Date: Mon, 29 Feb 2016 19:08:39 -0300 Message-ID: <20160229220839.GD2479@joana> References: <1456511507-2534-4-git-send-email-gustavo@padovan.org> <1456520410-28195-1-git-send-email-gustavo@padovan.org> <56D400CD.6070804@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-yw0-f170.google.com (mail-yw0-f170.google.com [209.85.161.170]) by gabe.freedesktop.org (Postfix) with ESMTPS id ADED76E00B for ; Mon, 29 Feb 2016 22:08:44 +0000 (UTC) Received: by mail-yw0-f170.google.com with SMTP id e63so133302854ywc.3 for ; Mon, 29 Feb 2016 14:08:44 -0800 (PST) Content-Disposition: inline In-Reply-To: <56D400CD.6070804@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Maarten Lankhorst Cc: devel@driverdev.osuosl.org, Daniel Stone , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Daniel Vetter , Riley Andrews , Gustavo Padovan , John Harrison List-Id: dri-devel@lists.freedesktop.org SGkgTWFhcnRlbiwKCjIwMTYtMDItMjkgTWFhcnRlbiBMYW5raG9yc3QgPG1hYXJ0ZW4ubGFua2hv cnN0QGxpbnV4LmludGVsLmNvbT46Cgo+IE9wIDI2LTAyLTE2IG9tIDIyOjAwIHNjaHJlZWYgR3Vz dGF2byBQYWRvdmFuOgo+ID4gRnJvbTogR3VzdGF2byBQYWRvdmFuIDxndXN0YXZvLnBhZG92YW5A Y29sbGFib3JhLmNvLnVrPgo+ID4KPiA+IENoYW5nZSBTWU5DX0lPQ19GSUxFX0lORk8gYmVoYXZp b3VyIHRvIGF2b2lkIGZ1dHVyZSBBUEkgYnJlYWtzIGFuZAo+ID4gb3B0aW1pemUgYnVmZmVyIGFs bG9jYXRpb24uIEluIHRoZSBuZXcgYXBwcm9hY2ggdGhlIGlvY3RsIG5lZWRzIHRvIGJlIGNhbGxl ZAo+ID4gdHdpY2UgdG8gcmV0cmlldmUgdGhlIGFycmF5IG9mIGZlbmNlX2luZm9zIHBvaW50ZWQg YnkgaW5mby0+c3luY19mZW5jZV9pbmZvLgo+ID4KPiA+IFRoZSBmaXJzdCBjYWxsIHNob3VsZCBw YXNzIG51bV9mZW5jZXMgPSAwLCB0aGUga2VybmVsIHdpbGwgdGhlbiBmaWxsCj4gPiBpbmZvLT5u dW1fZmVuY2VzLiBVc2Vyc3BhY2UgcmVjZWl2ZXMgYmFjayB0aGUgbnVtYmVyIG9mIGZlbmNlcyBh bmQKPiA+IGFsbG9jYXRlcyBhIGJ1ZmZlciBzaXplIG51bV9mZW5jZXMgKiBzaXplb2Yoc3RydWN0 IHN5bmNfZmVuY2VfaW5mbykgb24KPiA+IGluZm8tPnN5bmNfZmVuY2VfaW5mby4KPiA+Cj4gPiBJ dCB0aGVuIGNhbGwgdGhlIGlvY3RsIGFnYWluIHBhc3NpbmcgbnVtX2ZlbmNlcyByZWNlaXZlZCBp biBpbmZvLT5udW1fZmVuY2VzLgo+ID4gVGhlIGtlcm5lbCBjaGVja3MgaWYgaW5mby0+bnVtX2Zl bmNlcyA+IDAgYW5kIGlmIHllcyBpdCBmaWxsCj4gPiBpbmZvLT5zeW5jX2ZlbmNlX2luZm8gd2l0 aCBhbiBhcnJheSBjb250YWluaW5nIGFsbCBmZW5jZV9pbmZvcy4KPiA+Cj4gPiBpbmZvLT5sZW4g bm93IHJlcHJlc2VudHMgdGhlIGxlbmd0aCBvZiB0aGUgYnVmZmVyIHN5bmNfZmVuY2VfaW5mbyBw b2ludHMKPiA+IHRvLiBBbHNvLCBpbmZvLT5zeW5jX2ZlbmNlX2luZm8gd2FzIGNvbnZlcnRlZCB0 byBfX3U2NCBwb2ludGVyLgo+ID4KPiA+IEFuIGV4YW1wbGUgdXNlcnNwYWNlIGNvZGUgd291bGQg YmU6Cj4gPgo+ID4gCXN0cnVjdCBzeW5jX2ZpbGVfaW5mbyAqaW5mbzsKPiA+IAlpbnQgZXJyLCBz aXplLCBudW1fZmVuY2VzOwo+ID4KPiA+IAlpbmZvID0gbWFsbG9jKHNpemVvZigqaW5mbykpOwo+ ID4KPiA+IAltZW1zZXQoaW5mbywgMCwgc2l6ZW9mKCppbmZvKSk7Cj4gPgo+ID4gCWVyciA9IGlv Y3RsKGZkLCBTWU5DX0lPQ19GSUxFX0lORk8sIGluZm8pOwo+ID4gCW51bV9mZW5jZXMgPSBpbmZv LT5udW1fZmVuY2VzOwo+ID4KPiA+IAlpZiAobnVtX2ZlbmNlcykgewo+ID4gCQltZW1zZXQoaW5m bywgMCwgc2l6ZW9mKCppbmZvKSk7Cj4gV291bGQgdGhpcyBtZW1zZXQgc3RpbGwgYmUgbmVlZGVk IGlmIHdlIGRpZG4ndCBjaGVjayBmb3IgbnVsbHMgaW4gaW5mby0+c3RhdHVzIGFuZCBpbmZvLT5u YW1lID8KPiAKPiBTZWVtcyB0byBtZSB0aGF0IGl0IGNvdWxkIGJlIHNraXBwZWQgaW4gdGhhdCBj YXNlLgoKWWVzLCBJIGFncmVlLgoKPiA+IAkJc2l6ZSA9IHNpemVvZihzdHJ1Y3Qgc3luY19mZW5j ZV9pbmZvKSAqIG51bV9mZW5jZXM7Cj4gPiAJCWluZm8tPmxlbiA9IHNpemU7Cj4gPiAJCWluZm8t Pm51bV9mZW5jZXMgPSBudW1fZmVuY2VzOwo+ID4gCQlpbmZvLT5zeW5jX2ZlbmNlX2luZm8gPSAo dWludDY0X3QpIGNhbGxvYyhudW1fZmVuY2VzLAo+ID4gCQkJCQkJCSAgc2l6ZW9mKHN0cnVjdCBz eW5jX2ZlbmNlX2luZm8pKTsKPiA+Cj4gPiAJCWVyciA9IGlvY3RsKGZkLCBTWU5DX0lPQ19GSUxF X0lORk8sIGluZm8pOwo+ID4gCX0KPiA+Cj4gPiB2MjogZml4IGZlbmNlX2luZm8gbWVtb3J5IGxl YWsKPiA+Cj4gPiBTaWduZWQtb2ZmLWJ5OiBHdXN0YXZvIFBhZG92YW4gPGd1c3Rhdm8ucGFkb3Zh bkBjb2xsYWJvcmEuY28udWs+Cj4gPiAtLS0KPiA+ICBkcml2ZXJzL3N0YWdpbmcvYW5kcm9pZC9z eW5jLmMgICAgICB8IDUyICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0KPiA+ ICBkcml2ZXJzL3N0YWdpbmcvYW5kcm9pZC91YXBpL3N5bmMuaCB8ICA5ICsrKy0tLS0KPiA+ICAy IGZpbGVzIGNoYW5nZWQsIDQ1IGluc2VydGlvbnMoKyksIDE2IGRlbGV0aW9ucygtKQo+ID4KPiA+ IGRpZmYgLS1naXQgYS9kcml2ZXJzL3N0YWdpbmcvYW5kcm9pZC9zeW5jLmMgYi9kcml2ZXJzL3N0 YWdpbmcvYW5kcm9pZC9zeW5jLmMKPiA+IGluZGV4IGRjNWYzODIuLjIzNzlmMjMgMTAwNjQ0Cj4g PiAtLS0gYS9kcml2ZXJzL3N0YWdpbmcvYW5kcm9pZC9zeW5jLmMKPiA+ICsrKyBiL2RyaXZlcnMv c3RhZ2luZy9hbmRyb2lkL3N5bmMuYwo+ID4gQEAgLTUwMiwyMSArNTAyLDIyIEBAIHN0YXRpYyBp bnQgc3luY19maWxsX2ZlbmNlX2luZm8oc3RydWN0IGZlbmNlICpmZW5jZSwgdm9pZCAqZGF0YSwg aW50IHNpemUpCj4gPiAgc3RhdGljIGxvbmcgc3luY19maWxlX2lvY3RsX2ZlbmNlX2luZm8oc3Ry dWN0IHN5bmNfZmlsZSAqc3luY19maWxlLAo+ID4gIAkJCQkJdW5zaWduZWQgbG9uZyBhcmcpCj4g PiAgewo+ID4gLQlzdHJ1Y3Qgc3luY19maWxlX2luZm8gKmluZm87Cj4gPiArCXN0cnVjdCBzeW5j X2ZpbGVfaW5mbyBpbiwgKmluZm87Cj4gPiArCXN0cnVjdCBzeW5jX2ZlbmNlX2luZm8gKmZlbmNl X2luZm8gPSBOVUxMOwo+ID4gIAlfX3UzMiBzaXplOwo+ID4gIAlfX3UzMiBsZW4gPSAwOwo+ID0g MCB1bm5lZWRlZC4KPiA+ICAJaW50IHJldCwgaTsKPiA+ICAKPiA+IC0JaWYgKGNvcHlfZnJvbV91 c2VyKCZzaXplLCAodm9pZCBfX3VzZXIgKilhcmcsIHNpemVvZihzaXplKSkpCj4gPiArCWlmIChj b3B5X2Zyb21fdXNlcigmaW4sICh2b2lkIF9fdXNlciAqKWFyZywgc2l6ZW9mKCppbmZvKSkpCj4g PiAgCQlyZXR1cm4gLUVGQVVMVDsKPiA+ICAKPiA+IC0JaWYgKHNpemUgPCBzaXplb2Yoc3RydWN0 IHN5bmNfZmlsZV9pbmZvKSkKPiA+IC0JCXJldHVybiAtRUlOVkFMOwo+ID4gKwlpZiAoaW4uc3Rh dHVzIHx8IHN0cmNtcChpbi5uYW1lLCAiXDAiKSkKPiA+ICsJCXJldHVybiAtRUZBVUxUOwo+IFRo ZXNlIG1lbWJlcnMgYWx3YXlzIGdldCB3cml0dGVuIGJ5IHRoZSBmZW5jZSBpb2N0bCwgSSdtIG5v dCBzdXJlIGl0IGFkZHMgdmFsdWUgdG8gaGF2ZSB0aGVtIGV4cGxpY2l0bHkgemVybydkIG91dCBi eSB1c2Vyc3BhY2UuCj4gPiAtCWlmIChzaXplID4gNDA5NikKPiA+IC0JCXNpemUgPSA0MDk2Owo+ ID4gKwlpZiAoaW4ubnVtX2ZlbmNlcyAmJiAhaW4uc3luY19mZW5jZV9pbmZvKQo+ID4gKwkJcmV0 dXJuIC1FRkFVTFQ7Cj4gVGhpcyBjaGVjayBpcyB1bm5lZWRlZCwgaXQgd2lsbCBoYXBwZW4gaW4g dGhlIGNvcHlfdG9fdXNlciBjYWxsIGFueXdheS4KPiA+IC0JaW5mbyA9IGt6YWxsb2Moc2l6ZSwg R0ZQX0tFUk5FTCk7Cj4gPiArCWluZm8gPSBremFsbG9jKHNpemVvZigqaW5mbyksIEdGUF9LRVJO RUwpOwo+ID4gIAlpZiAoIWluZm8pCj4gPiAgCQlyZXR1cm4gLUVOT01FTTsKPiA+ICAKPiA+IEBA IC01MjUsMTQgKzUyNiwzMyBAQCBzdGF0aWMgbG9uZyBzeW5jX2ZpbGVfaW9jdGxfZmVuY2VfaW5m byhzdHJ1Y3Qgc3luY19maWxlICpzeW5jX2ZpbGUsCj4gPiAgCWlmIChpbmZvLT5zdGF0dXMgPj0g MCkKPiA+ICAJCWluZm8tPnN0YXR1cyA9ICFpbmZvLT5zdGF0dXM7Cj4gPiAgCj4gPiAtCWluZm8t Pm51bV9mZW5jZXMgPSBzeW5jX2ZpbGUtPm51bV9mZW5jZXM7Cj4gPiArCS8qCj4gPiArCSAqIFBh c3NpbmcgbnVtX2ZlbmNlcyA9IDAgbWVhbnMgdGhhdCB1c2Vyc3BhY2Ugd2FudCB0byBrbm93IGhv dwo+ID4gKwkgKiBtYW55IGZlbmNlcyBhcmUgaW4gdGhlIHN5bmNfZmlsZSB0byBiZSBhYmxlIHRv IGFsbG9jYXRlIGEgYnVmZmVyIHRvCj4gPiArCSAqIGZpdCBhbGwgc3luY19mZW5jZV9pbmZvcyBh bmQgY2FsbCB0aGUgaW9jdGwgYWdhaW4gd2l0aCB0aGUgYnVmZmVyCj4gPiArCSAqIGFzc2lnbmVk IHRvIGluZm8tPnN5bmNfZmVuY2VfaW5mby4gVGhlIHNlY29uZCBjYWxsIHBhc3MgdGhlCj4gPiAr CSAqIG51bV9mZW5jZXMgdmFsdWUgcmVjZWl2ZWQgaW4gdGhlIGZpcnN0IGNhbGwuCj4gPiArCSAq Lwo+ID4gKwlpZiAoIWluLm51bV9mZW5jZXMpCj4gPiArCQlnb3RvIG5vX2ZlbmNlczsKPiA+ICsK PiA+ICsJc2l6ZSA9IHN5bmNfZmlsZS0+bnVtX2ZlbmNlcyAqIHNpemVvZigqZmVuY2VfaW5mbyk7 Cj4gPiArCWlmIChpbi5sZW4gIT0gc2l6ZSkgewo+ID4gKwkJcmV0ID0gLUVGQVVMVDsKPiA+ICsJ CWdvdG8gb3V0Owo+ID4gKwl9Cj4gTWF5YmUgY2hlY2sgZm9yIGluLmxlbiA8IHNpemUsIGFuZCBz ZXQgc2V0IHRvIHNpemU/Cj4gCj4gCj4gPiAtCWxlbiA9IHNpemVvZihzdHJ1Y3Qgc3luY19maWxl X2luZm8pOwo+ID4gKwlmZW5jZV9pbmZvID0ga3phbGxvYyhzaXplLCBHRlBfS0VSTkVMKTsKPiA+ ICsJaWYgKCFmZW5jZV9pbmZvKSB7Cj4gPiArCQlyZXQgPSAtRU5PTUVNOwo+ID4gKwkJZ290byBv dXQ7Cj4gPiArCX0KPiA+ICAKPiA+ICAJZm9yIChpID0gMDsgaSA8IHN5bmNfZmlsZS0+bnVtX2Zl bmNlczsgKytpKSB7Cj4gPiAgCQlzdHJ1Y3QgZmVuY2UgKmZlbmNlID0gc3luY19maWxlLT5jYnNb aV0uZmVuY2U7Cj4gPiAgCj4gPiAtCQlyZXQgPSBzeW5jX2ZpbGxfZmVuY2VfaW5mbyhmZW5jZSwg KHU4ICopaW5mbyArIGxlbiwgc2l6ZSAtIGxlbik7Cj4gPiArCQlyZXQgPSBzeW5jX2ZpbGxfZmVu Y2VfaW5mbyhmZW5jZSwgKHU4ICopZmVuY2VfaW5mbyArIGxlbiwKPiA+ICsJCQkJCSAgIHNpemUg LSBsZW4pOwo+ID4gIAo+ID4gIAkJaWYgKHJldCA8IDApCj4gPiAgCQkJZ290byBvdXQ7Cj4gPiBA QCAtNTQwLDE0ICs1NjAsMjQgQEAgc3RhdGljIGxvbmcgc3luY19maWxlX2lvY3RsX2ZlbmNlX2lu Zm8oc3RydWN0IHN5bmNfZmlsZSAqc3luY19maWxlLAo+ID4gIAkJbGVuICs9IHJldDsKPiA+ICAJ fQo+ID4gIAo+ID4gKwlpZiAoY29weV90b191c2VyKCh2b2lkIF9fdXNlciAqKWluLnN5bmNfZmVu Y2VfaW5mbywgZmVuY2VfaW5mbywgc2l6ZSkpIHsKPiA+ICsJCXJldCA9IC1FRkFVTFQ7Cj4gPiAr CQlnb3RvIG91dDsKPiA+ICsJfQo+ID4gKwo+ID4gIAlpbmZvLT5sZW4gPSBsZW47Cj4gPiArCWlu Zm8tPnN5bmNfZmVuY2VfaW5mbyA9IChfX3U2NCkgaW4uc3luY19mZW5jZV9pbmZvOwo+ID4gKwo+ ID4gK25vX2ZlbmNlczoKPiA+ICsJaW5mby0+bnVtX2ZlbmNlcyA9IHN5bmNfZmlsZS0+bnVtX2Zl bmNlczsKPiA+ICAKPiA+IC0JaWYgKGNvcHlfdG9fdXNlcigodm9pZCBfX3VzZXIgKilhcmcsIGlu Zm8sIGxlbikpCj4gPiArCWlmIChjb3B5X3RvX3VzZXIoKHZvaWQgX191c2VyICopYXJnLCBpbmZv LCBzaXplb2YoKmluZm8pKSkKPiA+ICAJCXJldCA9IC1FRkFVTFQ7Cj4gPiAgCWVsc2UKPiA+ICAJ CXJldCA9IDA7Cj4gPiAgCj4gPiAgb3V0Ogo+ID4gKwlrZnJlZShmZW5jZV9pbmZvKTsKPiA+ICAJ a2ZyZWUoaW5mbyk7Cj4gPiAgCj4gPiAgCXJldHVybiByZXQ7Cj4gPiBkaWZmIC0tZ2l0IGEvZHJp dmVycy9zdGFnaW5nL2FuZHJvaWQvdWFwaS9zeW5jLmggYi9kcml2ZXJzL3N0YWdpbmcvYW5kcm9p ZC91YXBpL3N5bmMuaAo+ID4gaW5kZXggZjBiNDFjZS4uOWFhZDYyMyAxMDA2NDQKPiA+IC0tLSBh L2RyaXZlcnMvc3RhZ2luZy9hbmRyb2lkL3VhcGkvc3luYy5oCj4gPiArKysgYi9kcml2ZXJzL3N0 YWdpbmcvYW5kcm9pZC91YXBpL3N5bmMuaAo+ID4gQEAgLTQyLDIxICs0MiwyMCBAQCBzdHJ1Y3Qg c3luY19mZW5jZV9pbmZvIHsKPiA+ICAKPiA+ICAvKioKPiA+ICAgKiBzdHJ1Y3Qgc3luY19maWxl X2luZm8gLSBkYXRhIHJldHVybmVkIGZyb20gZmVuY2UgaW5mbyBpb2N0bAo+ID4gLSAqIEBsZW46 CWlvY3RsIGNhbGxlciB3cml0ZXMgdGhlIHNpemUgb2YgdGhlIGJ1ZmZlciBpdHMgcGFzc2luZyBp bi4KPiA+IC0gKgkJaW9jdGwgcmV0dXJucyBsZW5ndGggb2Ygc3luY19maWxlX2luZm8gcmV0dXJu ZWQgdG8KPiA+IC0gKgkJdXNlcnNwYWNlIGluY2x1ZGluZyBwdF9pbmZvLgo+ID4gICAqIEBuYW1l OgluYW1lIG9mIGZlbmNlCj4gPiAgICogQHN0YXR1czoJc3RhdHVzIG9mIGZlbmNlLiAxOiBzaWdu YWxlZCAwOmFjdGl2ZSA8MDplcnJvcgo+ID4gICAqIEBudW1fZmVuY2VzCW51bWJlciBvZiBmZW5j ZXMgaW4gdGhlIHN5bmNfZmlsZQo+ID4gKyAqIEBsZW46CWlvY3RsIGNhbGxlciB3cml0ZXMgdGhl IHNpemUgb2YgdGhlIGJ1ZmZlciBpdHMgcGFzc2luZyBpbi4KPiA+ICsgKgkJaW9jdGwgcmV0dXJu cyBsZW5ndGggb2YgYWxsIGZlbmNlX2luZm9zIHN1bW1lZC4KPiA+ICAgKiBAc3luY19mZW5jZV9p bmZvOiBhcnJheSBvZiBzeW5jX2ZlbmNlX2luZm8gZm9yIGV2ZXJ5IGZlbmNlIGluIHRoZSBzeW5j X2ZpbGUKPiA+ICAgKi8KPiA+ICBzdHJ1Y3Qgc3luY19maWxlX2luZm8gewo+ID4gLQlfX3UzMgls ZW47Cj4gPiAgCWNoYXIJbmFtZVszMl07Cj4gPiAgCV9fczMyCXN0YXR1czsKPiA+ICAJX191MzIJ bnVtX2ZlbmNlczsKPiA+ICsJX191MzIJbGVuOwo+ID4gIAo+ID4gLQlfX3U4CXN5bmNfZmVuY2Vf aW5mb1swXTsKPiA+ICsJX191NjQJc3luY19mZW5jZV9pbmZvOwo+ID4gIH07Cj4gPiAgCj4gPiAg I2RlZmluZSBTWU5DX0lPQ19NQUdJQwkJJz4nCj4gTm90IHN1cmUgaWYgbGVuIGFkZHMgYW55dGhp bmcgaGVyZSwgdXNlcnNwYWNlIGtub3dzIHRvIGFsbG9jYXRlIG51bV9mZW5jZXMgKiBzaXplb2Yo c3RydWN0IHN5bmNfZmVuY2VfaW5mbyk7CgpJIHRoaW5rIG9mIGxlbiBiZWluZyB1c2VmdWwgaWYg d2UgZGVjaWRlIHRvIGV4dGVuZCBzdHJ1Y3Qgc3luY19mZW5jZV9pbmZvIGluCnRoZSBmdXR1cmUs IHNvIHdlIG1heSB1c2UgbGVuIHRvIGhlbHAgZGlzY292ZXIgdGhlIHNpemUgb2YgZWFjaApzeW5j X2ZlbmNlX2luZm8uIFdoYXQgZG8geW91IHRoaW5rPwoKCUd1c3Rhdm8KX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApk cmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Au b3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==