From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH 3/4] drm: bridge/dw-hdmi: detect initial connector state Date: Wed, 2 Mar 2016 17:35:54 +0100 Message-ID: <20160302163554.GB31136@ulmo.nvidia.com> References: <1452243727-7242-1-git-send-email-p.zabel@pengutronix.de> <1452243727-7242-3-git-send-email-p.zabel@pengutronix.de> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1684376833==" Return-path: Received: from mail-pf0-x22e.google.com (mail-pf0-x22e.google.com [IPv6:2607:f8b0:400e:c00::22e]) by gabe.freedesktop.org (Postfix) with ESMTPS id 256B86E8EF for ; Wed, 2 Mar 2016 16:35:59 +0000 (UTC) Received: by mail-pf0-x22e.google.com with SMTP id w128so92179267pfb.2 for ; Wed, 02 Mar 2016 08:35:59 -0800 (PST) In-Reply-To: <1452243727-7242-3-git-send-email-p.zabel@pengutronix.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Philipp Zabel , Daniel Vetter Cc: Russell King , Thierry Reding , dri-devel@lists.freedesktop.org, kernel@pengutronix.de List-Id: dri-devel@lists.freedesktop.org --===============1684376833== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="+g7M9IMkV8truYOl" Content-Disposition: inline --+g7M9IMkV8truYOl Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jan 08, 2016 at 10:02:06AM +0100, Philipp Zabel wrote: > Allow userspace to read the initial connector state via sysfs without > having to issue a detect manually. There is no reason to keep the state > unknown during initialization. >=20 > Signed-off-by: Philipp Zabel > --- > drivers/gpu/drm/bridge/dw-hdmi.c | 2 ++ > 1 file changed, 2 insertions(+) It would seem to me that this should be the default, rather than having to duplicate this into every driver. Daniel, can you think of a reason why we wouldn't want to do handle this in the core so that all drivers can benefit? Thierry >=20 > diff --git a/drivers/gpu/drm/bridge/dw-hdmi.c b/drivers/gpu/drm/bridge/dw= -hdmi.c > index e41ff4b..2388a55 100644 > --- a/drivers/gpu/drm/bridge/dw-hdmi.c > +++ b/drivers/gpu/drm/bridge/dw-hdmi.c > @@ -1660,6 +1660,8 @@ static int dw_hdmi_register(struct drm_device *drm,= struct dw_hdmi *hdmi) > DRM_MODE_CONNECTOR_HDMIA); > =20 > hdmi->connector.encoder =3D encoder; > + hdmi->connector.status =3D dw_hdmi_connector_detect(&hdmi->connector, > + false); > =20 > drm_mode_connector_attach_encoder(&hdmi->connector, encoder); > =20 > --=20 > 2.6.4 >=20 > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel --+g7M9IMkV8truYOl Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJW1xZqAAoJEN0jrNd/PrOhiPoQAIFJxfxJHzEg5AAQ7lWCUUzp Cc2PvcjRMejF3NBPetx4zS6RwuLF0c0m2fPLfbWd/kS8+szijQTCKQMMJAKBaNCc zU/Op9TXa2HnduaZjeWDH3QP3FRxvhKAVM9iKp4NfW2hv76VKfThhdNUziY5GhU2 3hULtSLNCn+uL+ez9JBUVlr7a9p+db7gcjG0Q1FVLtRtbK4H2Ly9lbPWUaPf1m50 hYHe4XuGTsCQ/h8wbH5bLQ6IRgWSWKRVQHv6IfU1BcxSI56/kEK6POy4Ij4jtXRE w4nKj6ehg4lCj9g0uhAmolEI1PGgsryCRyYFaP9egOMnzCta0lrYUnq2EAwVkES2 9PZpdTeflOQV2ydUShTtFWpyfJGZ8WphnLAA2xi6bw9T5I6HP3ACqKxdLsXpxAGR sHrihf2rqbnsr8HuwCrknrLT5tRA9KDtjv/PD+jS5O/ahO92GjWhjjLa8bFTe+Rx D0T9hCYGVEP0I8U+fZeaOkSqgL8IYIWtnFpynALXjXPJift+KROxUtrpT3TnfzXX Y1Ib3wb4yWlVo5wwL7nD6b4NtizMNFjoUEI72TyQNYbognKQ1DPw4ajgjUuKZew1 tCisvNuEj+LhbxT7B+Es954wjSqDCh6y+yiFspig6OeLUxf9dGorYCr7600CUrnd pRFbpSrRM0yjGdaoHrXi =6LCo -----END PGP SIGNATURE----- --+g7M9IMkV8truYOl-- --===============1684376833== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1684376833==--