From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v2 4/6] drm/atomic: Handle encoder stealing from set_config better. Date: Fri, 4 Mar 2016 17:20:08 +0100 Message-ID: <20160304162008.GW32705@phenom.ffwll.local> References: <1456303053-28806-1-git-send-email-maarten.lankhorst@linux.intel.com> <1456303053-28806-5-git-send-email-maarten.lankhorst@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x229.google.com (mail-wm0-x229.google.com [IPv6:2a00:1450:400c:c09::229]) by gabe.freedesktop.org (Postfix) with ESMTPS id E69BD6E5E4 for ; Fri, 4 Mar 2016 16:19:28 +0000 (UTC) Received: by mail-wm0-x229.google.com with SMTP id p65so35346307wmp.0 for ; Fri, 04 Mar 2016 08:19:28 -0800 (PST) Content-Disposition: inline In-Reply-To: <1456303053-28806-5-git-send-email-maarten.lankhorst@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Maarten Lankhorst Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBGZWIgMjQsIDIwMTYgYXQgMDk6Mzc6MzFBTSArMDEwMCwgTWFhcnRlbiBMYW5raG9y c3Qgd3JvdGU6Cj4gSW5zdGVhZCBvZiBmYWlsaW5nIHdpdGggLUVJTlZBTCB3aGVuIGNvbmZsaWN0 aW5nIGVuY29kZXJzIGFyZSBmb3VuZCwKPiB0aGUgbGVnYWN5IHNldF9jb25maWcgd2lsbCBkaXNh YmxlIG90aGVyIGNvbm5lY3RvcnMgd2hlbiBlbmNvZGVycwo+IGNvbmZsaWN0Lgo+IAo+IFdpdGgg dGhlIGNsZWFudXAgdG8gdXBkYXRlX291dHB1dF9zdGF0ZSB0aGlzIGlzIGEgbG90IGVhc2llciB0 bwo+IGltcGxlbWVudC4gc2V0X2NvbmZpZyBvbmx5IGFkZHMgY29ubmVjdG9ycyB0byB0aGUgc3Rh dGUgdGhhdCBhcmUKPiBtb2RpZmllZCwgYW5kIGJlY2F1c2Ugb2YgdGhlIHByZXZpb3VzIGNvbW1p dCB0aGF0IGNhbGxzCj4gYWRkX2FmZmVjdGVkX2Nvbm5lY3RvcnMgb25seSBvbiBzZXQtPmNydGMg aXQgbWVhbnMgYW55IGNvbm5lY3RvciBub3QKPiBwYXJ0IG9mIHRoZSBtb2Rlc2V0IGNhbiBiZSBz dG9sZW4gZnJvbS4gV2UgZGlzYWJsZSB0aGUgY29ubmVjdG9yIGluCj4gdGhhdCBjYXNlLCBhbmQg cG9zc2libHkgdGhlIGNydGMgaWYgbm8gY29ubmVjdG9ycyBhcmUgbGVmdC4KPiAKPiBBdG9taWMg bW9kZXNldCBpdHNlbGYgc3RpbGwgZG9lc24ndCBhbGxvdyBlbmNvZGVyIHN0ZWFsaW5nLCB0aGUK PiByZXN1bHRzIHdvdWxkIGJlIHRvbyB1bnByZWRpY3RhYmxlLgoKU2hvdWxkbid0IHRoaXMgYmUg cmV3b3JrZWQgdG8gc2F5IHNvbWV0aGluZyBsaWtlICJXaXRoIHRoaXMgd2UgY2FuIHJld29yawp0 aGUgYXRvbWljIGNvcmUgdG8gbm90IGFsbG93IHN0ZWFsaW5nIj8KPiAKPiBTaWduZWQtb2ZmLWJ5 OiBNYWFydGVuIExhbmtob3JzdCA8bWFhcnRlbi5sYW5raG9yc3RAbGludXguaW50ZWwuY29tPgo+ IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pY19oZWxwZXIuYyB8IDY5ICsrKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysKPiAgaW5jbHVkZS9kcm0vZHJtX2NydGMuaCAg ICAgICAgICAgICAgfCAgMiArKwo+ICAyIGZpbGVzIGNoYW5nZWQsIDcxIGluc2VydGlvbnMoKykK PiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWNfaGVscGVyLmMgYi9k cml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pY19oZWxwZXIuYwo+IGluZGV4IGU4OWE1ZGEyNzQ2My4u MzU0M2M3ZmNkMDcyIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljX2hl bHBlci5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWNfaGVscGVyLmMKPiBAQCAt ODYsNiArODYsNjggQEAgZHJtX2F0b21pY19oZWxwZXJfcGxhbmVfY2hhbmdlZChzdHJ1Y3QgZHJt X2F0b21pY19zdGF0ZSAqc3RhdGUsCj4gIAl9Cj4gIH0KPiAgCj4gK3N0YXRpYyBpbnQgZGlzYWJs ZV9jb25mbGljdGluZ19jb25uZWN0b3JzKHN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICpzdGF0ZSkK PiArewo+ICsJc3RydWN0IGRybV9jb25uZWN0b3Jfc3RhdGUgKmNvbm5fc3RhdGU7Cj4gKwlzdHJ1 Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9yOwo+ICsJc3RydWN0IGRybV9lbmNvZGVyICplbmNv ZGVyOwo+ICsJdW5zaWduZWQgZW5jb2Rlcl9tYXNrID0gMDsKPiArCWludCBpLCByZXQ7Cj4gKwo+ ICsJZm9yX2VhY2hfY29ubmVjdG9yX2luX3N0YXRlKHN0YXRlLCBjb25uZWN0b3IsIGNvbm5fc3Rh dGUsIGkpIHsKPiArCQljb25zdCBzdHJ1Y3QgZHJtX2Nvbm5lY3Rvcl9oZWxwZXJfZnVuY3MgKmZ1 bmNzID0gY29ubmVjdG9yLT5oZWxwZXJfcHJpdmF0ZTsKPiArCQlzdHJ1Y3QgZHJtX2VuY29kZXIg Km5ld19lbmNvZGVyOwo+ICsKPiArCQlpZiAoIWNvbm5fc3RhdGUtPmNydGMpCj4gKwkJCWNvbnRp bnVlOwo+ICsKPiArCQlpZiAoZnVuY3MtPmF0b21pY19iZXN0X2VuY29kZXIpCj4gKwkJCW5ld19l bmNvZGVyID0gZnVuY3MtPmF0b21pY19iZXN0X2VuY29kZXIoY29ubmVjdG9yLCBjb25uX3N0YXRl KTsKPiArCQllbHNlCj4gKwkJCW5ld19lbmNvZGVyID0gZnVuY3MtPmJlc3RfZW5jb2Rlcihjb25u ZWN0b3IpOwo+ICsKPiArCQlpZiAobmV3X2VuY29kZXIpCj4gKwkJCWVuY29kZXJfbWFzayB8PSAx IDw8IGRybV9lbmNvZGVyX2luZGV4KG5ld19lbmNvZGVyKTsKPiArCX0KPiArCj4gKwlkcm1fZm9y X2VhY2hfY29ubmVjdG9yKGNvbm5lY3Rvciwgc3RhdGUtPmRldikgewo+ICsJCXN0cnVjdCBkcm1f Y3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZTsKPiArCj4gKwkJaWYgKGRybV9hdG9taWNfZ2V0X2V4aXN0 aW5nX2Nvbm5lY3Rvcl9zdGF0ZShzdGF0ZSwgY29ubmVjdG9yKSkKPiArCQkJY29udGludWU7Cj4g Kwo+ICsJCWVuY29kZXIgPSBjb25uZWN0b3ItPnN0YXRlLT5iZXN0X2VuY29kZXI7Cj4gKwkJaWYg KCFlbmNvZGVyIHx8ICEoZW5jb2Rlcl9tYXNrICYgKDEgPDwgZHJtX2VuY29kZXJfaW5kZXgoZW5j b2RlcikpKSkKPiArCQkJY29udGludWU7Cj4gKwo+ICsJCWNvbm5fc3RhdGUgPSBkcm1fYXRvbWlj X2dldF9jb25uZWN0b3Jfc3RhdGUoc3RhdGUsIGNvbm5lY3Rvcik7Cj4gKwkJaWYgKElTX0VSUihj b25uX3N0YXRlKSkKPiArCQkJcmV0dXJuIFBUUl9FUlIoY29ubl9zdGF0ZSk7Cj4gKwo+ICsJCURS TV9ERUJVR19BVE9NSUMoIltFTkNPREVSOiVkOiVzXSBpbiB1c2Ugb24gW0NSVEM6JWQ6JXNdLCBk aXNhYmxpbmcgW0NPTk5FQ1RPUjolZDolc11cbiIsCj4gKwkJCQkgZW5jb2Rlci0+YmFzZS5pZCwg ZW5jb2Rlci0+bmFtZSwKPiArCQkJCSBjb25uX3N0YXRlLT5jcnRjLT5iYXNlLmlkLCBjb25uX3N0 YXRlLT5jcnRjLT5uYW1lLAo+ICsJCQkJIGNvbm5lY3Rvci0+YmFzZS5pZCwgY29ubmVjdG9yLT5u YW1lKTsKPiArCj4gKwkJY3J0Y19zdGF0ZSA9IGRybV9hdG9taWNfZ2V0X2V4aXN0aW5nX2NydGNf c3RhdGUoc3RhdGUsIGNvbm5fc3RhdGUtPmNydGMpOwo+ICsKPiArCQlyZXQgPSBkcm1fYXRvbWlj X3NldF9jcnRjX2Zvcl9jb25uZWN0b3IoY29ubl9zdGF0ZSwgTlVMTCk7Cj4gKwkJaWYgKHJldCkK PiArCQkJcmV0dXJuIHJldDsKPiArCj4gKwkJaWYgKCFjcnRjX3N0YXRlLT5jb25uZWN0b3JfbWFz aykgewo+ICsJCQlyZXQgPSBkcm1fYXRvbWljX3NldF9tb2RlX3Byb3BfZm9yX2NydGMoY3J0Y19z dGF0ZSwKPiArCQkJCQkJCQlOVUxMKTsKPiArCQkJaWYgKHJldCA8IDApCj4gKwkJCQlyZXR1cm4g cmV0Owo+ICsKPiArCQkJY3J0Y19zdGF0ZS0+YWN0aXZlID0gZmFsc2U7Cj4gKwkJfQo+ICsJfQo+ ICsKPiArCXJldHVybiAwOwo+ICt9Cj4gKwo+ICBzdGF0aWMgYm9vbAo+ICBjaGVja19wZW5kaW5n X2VuY29kZXJfYXNzaWdubWVudChzdHJ1Y3QgZHJtX2F0b21pY19zdGF0ZSAqc3RhdGUsCj4gIAkJ CQkgc3RydWN0IGRybV9lbmNvZGVyICpuZXdfZW5jb2RlcikKPiBAQCAtNDQ5LDYgKzUxMSwxMiBA QCBkcm1fYXRvbWljX2hlbHBlcl9jaGVja19tb2Rlc2V0KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYs Cj4gIAkJfQo+ICAJfQo+ICAKPiArCWlmIChzdGF0ZS0+bGVnYWN5X3NldF9jb25maWcpIHsKPiAr CQlyZXQgPSBkaXNhYmxlX2NvbmZsaWN0aW5nX2Nvbm5lY3RvcnMoc3RhdGUpOwo+ICsJCWlmIChy ZXQpCj4gKwkJCXJldHVybiByZXQ7Cj4gKwl9Cj4gKwo+ICAJZm9yX2VhY2hfY29ubmVjdG9yX2lu X3N0YXRlKHN0YXRlLCBjb25uZWN0b3IsIGNvbm5lY3Rvcl9zdGF0ZSwgaSkgewo+ICAJCS8qCj4g IAkJICogVGhpcyBvbmx5IHNldHMgY3J0Yy0+bW9kZV9jaGFuZ2VkIGZvciByb3V0aW5nIGNoYW5n ZXMsCj4gQEAgLTE3OTcsNiArMTg2NSw3IEBAIGludCBkcm1fYXRvbWljX2hlbHBlcl9zZXRfY29u ZmlnKHN0cnVjdCBkcm1fbW9kZV9zZXQgKnNldCkKPiAgCWlmICghc3RhdGUpCj4gIAkJcmV0dXJu IC1FTk9NRU07Cj4gIAo+ICsJc3RhdGUtPmxlZ2FjeV9zZXRfY29uZmlnID0gdHJ1ZTsKPiAgCXN0 YXRlLT5hY3F1aXJlX2N0eCA9IGRybV9tb2Rlc2V0X2xlZ2FjeV9hY3F1aXJlX2N0eChjcnRjKTsK PiAgcmV0cnk6Cj4gIAlyZXQgPSBfX2RybV9hdG9taWNfaGVscGVyX3NldF9jb25maWcoc2V0LCBz dGF0ZSk7Cj4gZGlmZiAtLWdpdCBhL2luY2x1ZGUvZHJtL2RybV9jcnRjLmggYi9pbmNsdWRlL2Ry bS9kcm1fY3J0Yy5oCj4gaW5kZXggN2ZhZDE5M2RjNjQ1Li45YTk0NmRmMjdmMDcgMTAwNjQ0Cj4g LS0tIGEvaW5jbHVkZS9kcm0vZHJtX2NydGMuaAo+ICsrKyBiL2luY2x1ZGUvZHJtL2RybV9jcnRj LmgKPiBAQCAtMTY3Nyw2ICsxNjc3LDcgQEAgc3RydWN0IGRybV9icmlkZ2Ugewo+ICAgKiBAZGV2 OiBwYXJlbnQgRFJNIGRldmljZQo+ICAgKiBAYWxsb3dfbW9kZXNldDogYWxsb3cgZnVsbCBtb2Rl c2V0Cj4gICAqIEBsZWdhY3lfY3Vyc29yX3VwZGF0ZTogaGludCB0byBlbmZvcmNlIGxlZ2FjeSBj dXJzb3IgSU9DVEwgc2VtYW50aWNzCj4gKyAqIEBsZWdhY3lfc2V0X2NvbmZpZzogRGlzYWJsZSBj b25mbGljdGluZyBlbmNvZGVycyBpbnN0ZWFkIG9mIGZhaWxpbmcgd2l0aCAtRUlOVkFMLgo+ICAg KiBAcGxhbmVzOiBwb2ludGVyIHRvIGFycmF5IG9mIHBsYW5lIHBvaW50ZXJzCj4gICAqIEBwbGFu ZV9zdGF0ZXM6IHBvaW50ZXIgdG8gYXJyYXkgb2YgcGxhbmUgc3RhdGVzIHBvaW50ZXJzCj4gICAq IEBjcnRjczogcG9pbnRlciB0byBhcnJheSBvZiBDUlRDIHBvaW50ZXJzCj4gQEAgLTE2OTAsNiAr MTY5MSw3IEBAIHN0cnVjdCBkcm1fYXRvbWljX3N0YXRlIHsKPiAgCXN0cnVjdCBkcm1fZGV2aWNl ICpkZXY7Cj4gIAlib29sIGFsbG93X21vZGVzZXQgOiAxOwo+ICAJYm9vbCBsZWdhY3lfY3Vyc29y X3VwZGF0ZSA6IDE7Cj4gKwlib29sIGxlZ2FjeV9zZXRfY29uZmlnIDogMTsKPiAgCXN0cnVjdCBk cm1fcGxhbmUgKipwbGFuZXM7Cj4gIAlzdHJ1Y3QgZHJtX3BsYW5lX3N0YXRlICoqcGxhbmVfc3Rh dGVzOwo+ICAJc3RydWN0IGRybV9jcnRjICoqY3J0Y3M7Cj4gLS0gCj4gMi4xLjAKPiAKPiBfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IGRyaS1kZXZlbCBt YWlsaW5nIGxpc3QKPiBkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cHM6Ly9s aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwKCi0tIApEYW5p ZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgpodHRwOi8vYmxv Zy5mZndsbC5jaApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK aHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK