From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v2.1 3/6] drm/atomic: Always call steal_encoder, v2. Date: Fri, 4 Mar 2016 17:20:53 +0100 Message-ID: <20160304162053.GX32705@phenom.ffwll.local> References: <1456303053-28806-1-git-send-email-maarten.lankhorst@linux.intel.com> <1456303053-28806-4-git-send-email-maarten.lankhorst@linux.intel.com> <56D59E85.2060205@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <56D59E85.2060205@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Maarten Lankhorst Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBNYXIgMDEsIDIwMTYgYXQgMDI6NTI6MDVQTSArMDEwMCwgTWFhcnRlbiBMYW5raG9y c3Qgd3JvdGU6Cj4gVGhlcmUncyBubyBuZWVkIHRvIGhhdmUgYSBzZXBhcmF0ZSBmdW5jdGlvbiB0 byBnZXQgdGhlIGNydGMKPiB3aGljaCBpcyBzdG9sZW4sIHRoaXMgY2FuIGFscmVhZHkgYmUgZm91 bmQgd2hlbiBhY3R1YWxseQo+IHN0ZWFsaW5nIHRoZSBlbmNvZGVyLgo+IAo+IGRybV9mb3JfZWFj aF9jb25uZWN0b3IgYWxyZWFkeSBjaGVja3MgZm9yIGNvbm5lY3Rpb25fbXV0ZXgsIHNvCj4gdXNl IHRoYXQgbWFjcm8gbm93Lgo+IAo+IENoYW5nZXMgc2luY2UgdjE6Cj4gLSBEbyBub3QgY2hlY2sg Zm9yIE5VTEwgY3J0YyBpbiBjb25uZWN0b3Jfc3RhdGUsCj4gICB0aGlzIG1heSBoYXBwZW4gd2hl biBhIGNydGMgaXMgZGlzYWJsZWQgYW5kIGl0cyBlbmNvZGVyIHN0b2xlbi4KPiAtIEJlY2F1c2Ug b2YgdGhpcywgdXNlIGNvbm5lY3Rvci0+c3RhdGUtPmNydGMgaW5zdGVhZCBvZiBjb25uX3N0YXRl LT5jcnRjLgo+IAo+IFNpZ25lZC1vZmYtYnk6IE1hYXJ0ZW4gTGFua2hvcnN0IDxtYWFydGVuLmxh bmtob3JzdEBsaW51eC5pbnRlbC5jb20+CgpBbHNvIEkgdGhpbmsgd2Ugc2hvdWxkIGhhdmUgYSB0 ZXN0Y2FzZSBvZiBzb21lIHNvcnRzIGZvciB0aGlzLiBQcm9iYWJseQpzaW1wbGVzdCB0byB3cml0 ZSB1bml0IHRlc3RzIGZvciB0aGUgYXRvbWljIGhlbHBlciBsaWJyYXJ5LgotRGFuaWVsCgo+IC0t LQo+IE9vcHMsIHRoaXMgcGF0Y2ggaGFkIGEgV0FSTl9PTighY29ubl9zdGF0ZS0+Y3J0Yyk7IGlu IHYxLAo+IHRoaXMgYnJva2UgRFAgTVNUIHdoaWNoIGhhZCBhIGxlZ2l0aW1hdGUgcmVhc29uIHRv IGRvIHNvLgo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pY19oZWxw ZXIuYyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljX2hlbHBlci5jCj4gaW5kZXggM2QxZjk3 YTgzMmZjLi43MmNhODViMzIyNjAgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2RybV9h dG9taWNfaGVscGVyLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pY19oZWxwZXIu Ywo+IEBAIC0xMDYsMjUgKzEwNiw2IEBAIGNoZWNrX3BlbmRpbmdfZW5jb2Rlcl9hc3NpZ25tZW50 KHN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICpzdGF0ZSwKPiAgCXJldHVybiB0cnVlOwo+ICB9Cj4g IAo+IC1zdGF0aWMgc3RydWN0IGRybV9jcnRjICoKPiAtZ2V0X2N1cnJlbnRfY3J0Y19mb3JfZW5j b2RlcihzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+IC0JCQkgICAgIHN0cnVjdCBkcm1fZW5jb2Rl ciAqZW5jb2RlcikKPiAtewo+IC0Jc3RydWN0IGRybV9tb2RlX2NvbmZpZyAqY29uZmlnID0gJmRl di0+bW9kZV9jb25maWc7Cj4gLQlzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9yOwo+IC0K PiAtCVdBUk5fT04oIWRybV9tb2Rlc2V0X2lzX2xvY2tlZCgmY29uZmlnLT5jb25uZWN0aW9uX211 dGV4KSk7Cj4gLQo+IC0JZHJtX2Zvcl9lYWNoX2Nvbm5lY3Rvcihjb25uZWN0b3IsIGRldikgewo+ IC0JCWlmIChjb25uZWN0b3ItPnN0YXRlLT5iZXN0X2VuY29kZXIgIT0gZW5jb2RlcikKPiAtCQkJ Y29udGludWU7Cj4gLQo+IC0JCXJldHVybiBjb25uZWN0b3ItPnN0YXRlLT5jcnRjOwo+IC0JfQo+ IC0KPiAtCXJldHVybiBOVUxMOwo+IC19Cj4gLQo+ICBzdGF0aWMgdm9pZAo+ICBzZXRfYmVzdF9l bmNvZGVyKHN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICpzdGF0ZSwKPiAgCQkgc3RydWN0IGRybV9j b25uZWN0b3Jfc3RhdGUgKmNvbm5fc3RhdGUsCj4gQEAgLTE2OCwzOCArMTQ5LDE4IEBAIHNldF9i ZXN0X2VuY29kZXIoc3RydWN0IGRybV9hdG9taWNfc3RhdGUgKnN0YXRlLAo+ICAKPiAgc3RhdGlj IGludAo+ICBzdGVhbF9lbmNvZGVyKHN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICpzdGF0ZSwKPiAt CSAgICAgIHN0cnVjdCBkcm1fZW5jb2RlciAqZW5jb2RlciwKPiAtCSAgICAgIHN0cnVjdCBkcm1f Y3J0YyAqZW5jb2Rlcl9jcnRjKQo+ICsJICAgICAgc3RydWN0IGRybV9lbmNvZGVyICplbmNvZGVy KQo+ICB7Cj4gLQlzdHJ1Y3QgZHJtX21vZGVfY29uZmlnICpjb25maWcgPSAmc3RhdGUtPmRldi0+ bW9kZV9jb25maWc7Cj4gIAlzdHJ1Y3QgZHJtX2NydGNfc3RhdGUgKmNydGNfc3RhdGU7Cj4gIAlz dHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9yOwo+ICAJc3RydWN0IGRybV9jb25uZWN0b3Jf c3RhdGUgKmNvbm5lY3Rvcl9zdGF0ZTsKPiAgCj4gLQkvKgo+IC0JICogV2UgY2FuIG9ubHkgc3Rl YWwgYW4gZW5jb2RlciBjb21pbmcgZnJvbSBhIGNvbm5lY3Rvciwgd2hpY2ggbWVhbnMgd2UKPiAt CSAqIG11c3QgYWxyZWFkeSBob2xkIHRoZSBjb25uZWN0aW9uX211dGV4Lgo+IC0JICovCj4gLQlX QVJOX09OKCFkcm1fbW9kZXNldF9pc19sb2NrZWQoJmNvbmZpZy0+Y29ubmVjdGlvbl9tdXRleCkp Owo+IC0KPiAtCURSTV9ERUJVR19BVE9NSUMoIltFTkNPREVSOiVkOiVzXSBpbiB1c2Ugb24gW0NS VEM6JWQ6JXNdLCBzdGVhbGluZyBpdFxuIiwKPiAtCQkJIGVuY29kZXItPmJhc2UuaWQsIGVuY29k ZXItPm5hbWUsCj4gLQkJCSBlbmNvZGVyX2NydGMtPmJhc2UuaWQsIGVuY29kZXJfY3J0Yy0+bmFt ZSk7Cj4gKwlkcm1fZm9yX2VhY2hfY29ubmVjdG9yKGNvbm5lY3Rvciwgc3RhdGUtPmRldikgewo+ ICsJCXN0cnVjdCBkcm1fY3J0YyAqZW5jb2Rlcl9jcnRjOwo+ICAKPiAtCWNydGNfc3RhdGUgPSBk cm1fYXRvbWljX2dldF9jcnRjX3N0YXRlKHN0YXRlLCBlbmNvZGVyX2NydGMpOwo+IC0JaWYgKElT X0VSUihjcnRjX3N0YXRlKSkKPiAtCQlyZXR1cm4gUFRSX0VSUihjcnRjX3N0YXRlKTsKPiAtCj4g LQljcnRjX3N0YXRlLT5jb25uZWN0b3JzX2NoYW5nZWQgPSB0cnVlOwo+IC0KPiAtCWxpc3RfZm9y X2VhY2hfZW50cnkoY29ubmVjdG9yLCAmY29uZmlnLT5jb25uZWN0b3JfbGlzdCwgaGVhZCkgewo+ ICAJCWlmIChjb25uZWN0b3ItPnN0YXRlLT5iZXN0X2VuY29kZXIgIT0gZW5jb2RlcikKPiAgCQkJ Y29udGludWU7Cj4gIAo+IC0JCURSTV9ERUJVR19BVE9NSUMoIlN0ZWFsaW5nIGVuY29kZXIgZnJv bSBbQ09OTkVDVE9SOiVkOiVzXVxuIiwKPiAtCQkJCSBjb25uZWN0b3ItPmJhc2UuaWQsCj4gLQkJ CQkgY29ubmVjdG9yLT5uYW1lKTsKPiAtCj4gIAkJY29ubmVjdG9yX3N0YXRlID0gZHJtX2F0b21p Y19nZXRfY29ubmVjdG9yX3N0YXRlKHN0YXRlLAo+ICAJCQkJCQkJCSBjb25uZWN0b3IpOwo+ICAJ CWlmIChJU19FUlIoY29ubmVjdG9yX3N0YXRlKSkKPiBAQCAtMjA4LDcgKzE2OSwxOCBAQCBzdGVh bF9lbmNvZGVyKHN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICpzdGF0ZSwKPiAgCQlpZiAoY29ubmVj dG9yX3N0YXRlLT5iZXN0X2VuY29kZXIgIT0gZW5jb2RlcikKPiAgCQkJY29udGludWU7Cj4gIAo+ ICsJCWVuY29kZXJfY3J0YyA9IGNvbm5lY3Rvci0+c3RhdGUtPmNydGM7Cj4gKwo+ICsJCURSTV9E RUJVR19BVE9NSUMoIltFTkNPREVSOiVkOiVzXSBpbiB1c2Ugb24gW0NSVEM6JWQ6JXNdLCBzdGVh bGluZyBpdFxuIiwKPiArCQkJCSBlbmNvZGVyLT5iYXNlLmlkLCBlbmNvZGVyLT5uYW1lLAo+ICsJ CQkJIGVuY29kZXJfY3J0Yy0+YmFzZS5pZCwgZW5jb2Rlcl9jcnRjLT5uYW1lKTsKPiArCj4gIAkJ c2V0X2Jlc3RfZW5jb2RlcihzdGF0ZSwgY29ubmVjdG9yX3N0YXRlLCBOVUxMKTsKPiArCj4gKwkJ Y3J0Y19zdGF0ZSA9IGRybV9hdG9taWNfZ2V0X2V4aXN0aW5nX2NydGNfc3RhdGUoc3RhdGUsIGVu Y29kZXJfY3J0Yyk7Cj4gKwkJY3J0Y19zdGF0ZS0+Y29ubmVjdG9yc19jaGFuZ2VkID0gdHJ1ZTsK PiArCj4gKwkJcmV0dXJuIDA7Cj4gIAl9Cj4gIAo+ICAJcmV0dXJuIDA7Cj4gQEAgLTIyMSw3ICsx OTMsNiBAQCB1cGRhdGVfY29ubmVjdG9yX3JvdXRpbmcoc3RydWN0IGRybV9hdG9taWNfc3RhdGUg KnN0YXRlLAo+ICB7Cj4gIAljb25zdCBzdHJ1Y3QgZHJtX2Nvbm5lY3Rvcl9oZWxwZXJfZnVuY3Mg KmZ1bmNzOwo+ICAJc3RydWN0IGRybV9lbmNvZGVyICpuZXdfZW5jb2RlcjsKPiAtCXN0cnVjdCBk cm1fY3J0YyAqZW5jb2Rlcl9jcnRjOwo+ICAJc3RydWN0IGRybV9jcnRjX3N0YXRlICpjcnRjX3N0 YXRlOwo+ICAJaW50IGlkeCwgcmV0Owo+ICAKPiBAQCAtMjk5LDE3ICsyNzAsMTIgQEAgdXBkYXRl X2Nvbm5lY3Rvcl9yb3V0aW5nKHN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICpzdGF0ZSwKPiAgCQly ZXR1cm4gLUVJTlZBTDsKPiAgCX0KPiAgCj4gLQllbmNvZGVyX2NydGMgPSBnZXRfY3VycmVudF9j cnRjX2Zvcl9lbmNvZGVyKHN0YXRlLT5kZXYsCj4gLQkJCQkJCSAgICBuZXdfZW5jb2Rlcik7Cj4g LQo+IC0JaWYgKGVuY29kZXJfY3J0Yykgewo+IC0JCXJldCA9IHN0ZWFsX2VuY29kZXIoc3RhdGUs IG5ld19lbmNvZGVyLCBlbmNvZGVyX2NydGMpOwo+IC0JCWlmIChyZXQpIHsKPiAtCQkJRFJNX0RF QlVHX0FUT01JQygiRW5jb2RlciBzdGVhbGluZyBmYWlsZWQgZm9yIFtDT05ORUNUT1I6JWQ6JXNd XG4iLAo+IC0JCQkJCSBjb25uZWN0b3ItPmJhc2UuaWQsCj4gLQkJCQkJIGNvbm5lY3Rvci0+bmFt ZSk7Cj4gLQkJCXJldHVybiByZXQ7Cj4gLQkJfQo+ICsJcmV0ID0gc3RlYWxfZW5jb2RlcihzdGF0 ZSwgbmV3X2VuY29kZXIpOwo+ICsJaWYgKHJldCkgewo+ICsJCURSTV9ERUJVR19BVE9NSUMoIkVu Y29kZXIgc3RlYWxpbmcgZmFpbGVkIGZvciBbQ09OTkVDVE9SOiVkOiVzXVxuIiwKPiArCQkJCSBj b25uZWN0b3ItPmJhc2UuaWQsCj4gKwkJCQkgY29ubmVjdG9yLT5uYW1lKTsKPiArCQlyZXR1cm4g cmV0Owo+ICAJfQo+ICAKPiAgCWlmIChXQVJOX09OKCFjb25uZWN0b3Jfc3RhdGUtPmNydGMpKQo+ IAo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gSW50 ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBo dHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAoK LS0gCkRhbmllbCBWZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBvcmF0aW9uCmh0 dHA6Ly9ibG9nLmZmd2xsLmNoCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNr dG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2lu dGVsLWdmeAo=