From: Dan Carpenter <dan.carpenter@oracle.com>
To: lionel.g.landwerlin@intel.com
Cc: dri-devel@lists.freedesktop.org
Subject: re: drm: introduce pipe color correction properties
Date: Wed, 9 Mar 2016 22:18:30 +0300 [thread overview]
Message-ID: <20160309191830.GA13630@mwanda> (raw)
Hello Lionel Landwerlin,
The patch 5488dc16fde7: "drm: introduce pipe color correction
properties" from Feb 26, 2016, leads to the following static checker
warning:
drivers/gpu/drm/drm_atomic_helper.c:2933 drm_atomic_helper_legacy_gamma_set()
error: 'blob' dereferencing possible ERR_PTR()
drivers/gpu/drm/drm_atomic_helper.c
2924 blob = drm_property_create_blob(dev,
2925 sizeof(struct drm_color_lut) * size,
2926 NULL);
2927 if (!blob) {
This should be a check for IS_ERR().
2928 ret = -ENOMEM;
2929 goto fail;
"goto fail" heh...
2930 }
2931
2932 /* Prepare GAMMA_LUT with the legacy values. */
2933 blob_data = (struct drm_color_lut *) blob->data;
2934 for (i = 0; i < size; i++) {
regards,
dan carpenter
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
reply other threads:[~2016-03-09 19:18 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160309191830.GA13630@mwanda \
--to=dan.carpenter@oracle.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=lionel.g.landwerlin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox