From: Daniel Vetter <daniel@ffwll.ch>
To: Paulo Zanoni <przanoni@gmail.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
Emil Velikov <emil.l.velikov@gmail.com>,
Paulo Zanoni <paulo.r.zanoni@intel.com>,
DRI Development <dri-devel@lists.freedesktop.org>,
Daniel Vetter <daniel.vetter@intel.com>
Subject: Re: [PATCH 3/3] drm: Move DRM_MODE_OBJECT_* to uapi headers
Date: Wed, 30 Mar 2016 21:07:27 +0200 [thread overview]
Message-ID: <20160330190727.GT2510@phenom.ffwll.local> (raw)
In-Reply-To: <CA+gsUGTkCAk=+FtDYjTTmcar9XTpCPmBef6an2dJKdjjRKTn8A@mail.gmail.com>
On Wed, Mar 30, 2016 at 02:55:17PM -0300, Paulo Zanoni wrote:
> 2016-03-30 13:07 GMT-03:00 Emil Velikov <emil.l.velikov@gmail.com>:
> > On 30 March 2016 at 15:19, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> >> These type defines are officially part of the uapi, but ended up in
> >> the wrong headers somehow when we split them all.
> >>
> >> Cc: Emil Velikov <emil.l.velikov@gmail.com>
> >> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> > The way it was done originally (by Paulo) with commit
> > c543188afb7a83e66161c026dc6fd5eb38dc0b63 it seemed deliberate. At the
> > same time the libdrm got a different treatment
> > 8c75703df0fdf65b3851f8eb5822705638decff3. Would be swell Paulo can
> > confirm (re: unintentional or deliberate difference), if he recalls
> > any of this :-)
> >
> > Barring any objections from Paulo
>
> No objections from Paulo. The include/uapi directory didn't even exist
> at that time, and I guess I was just trying to make things work,
> without any specific coding philosophy in mind.
Yeah, I suspect that this was actually fumbled in the uapi split-up
somehow ...
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-03-30 19:07 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-30 14:19 [PATCH 1/3] drm: Make drm.h uapi header safe for C++ Daniel Vetter
2016-03-30 14:19 ` [PATCH 2/3] drm: align #include directives with libdrm in uapi headers Daniel Vetter
2016-03-30 15:05 ` Emil Velikov
2016-03-30 15:11 ` Daniel Vetter
2016-03-30 15:22 ` Emil Velikov
2016-03-30 15:54 ` [PATCH] " Daniel Vetter
2016-03-30 16:08 ` Emil Velikov
2016-03-30 14:19 ` [PATCH 3/3] drm: Move DRM_MODE_OBJECT_* to " Daniel Vetter
2016-03-30 16:07 ` Emil Velikov
2016-03-30 17:55 ` Paulo Zanoni
2016-03-30 19:07 ` Daniel Vetter [this message]
2016-03-30 14:42 ` [PATCH 1/2] drm: Untangle __KERNEL__ guards Daniel Vetter
2016-03-30 14:42 ` [PATCH 2/2] drm: Make uapi headers C89 pendantic compliant Daniel Vetter
2016-03-30 20:06 ` Emil Velikov
2016-03-31 5:58 ` Daniel Vetter
2016-03-30 15:56 ` [PATCH 1/2] drm: Untangle __KERNEL__ guards Emil Velikov
2016-03-30 19:11 ` Daniel Vetter
2016-03-30 15:12 ` [PATCH] drm: Make drm.h uapi header safe for C++ Daniel Vetter
2016-03-30 15:56 ` Emil Velikov
2016-04-06 15:58 ` [PATCH 1/3] " Gabriel Laskar
2016-04-06 16:35 ` Emil Velikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160330190727.GT2510@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=emil.l.velikov@gmail.com \
--cc=paulo.r.zanoni@intel.com \
--cc=przanoni@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox