dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel@ffwll.ch>
To: "Noralf Trønnes" <noralf@tronnes.org>
Cc: thomas.petazzoni@free-electrons.com, dri-devel@lists.freedesktop.org
Subject: Re: [RFC v2 0/8] drm: Add support for tiny LCD displays
Date: Wed, 13 Apr 2016 13:11:46 +0200	[thread overview]
Message-ID: <20160413111146.GA2510@phenom.ffwll.local> (raw)
In-Reply-To: <1460135110-24121-1-git-send-email-noralf@tronnes.org>

On Fri, Apr 08, 2016 at 07:05:02PM +0200, Noralf Trønnes wrote:
> This is an attempt at providing a DRM version of drivers/staging/fbtft.
> 
> I'm sending this early before cleaning up the code hoping to get some
> feedback in case there are better ways to structure this.
> 
> The tinydrm module provides a very simplified view of DRM for displays that
> has onboard video memory and is connected through a slow bus like SPI/I2C.
> A driver using tinydrm has to provide a function that will be called from
> the dirtyfb ioctl (or fbdev deferred io) and optional drm_panel functions
> which can be used to set up the display controller and control backlight.
> 
> Display controllers that have a similar register interface as the MIPI DBI/DCS
> controllers can use the lcdreg module for register access.

I like this a lot. For the panel stuff itself I think it'd be good to have
comments from Thierry Redding too. Otherwise I'd say let's polish the def
io and simple kms stuff and start get that merged meanwhile.
-Daniel

> 
> Changes since RFC v1:
> - Add fb_deferred_io support to drm_fb_helper and drm_fb_cma_helper,
>   and use drm_fb_cma_helper instead.
> - Move display pipeline code to drm_simple_kms_helper.
> - Don't use (struct drm_driver *)->load().
> - Make tinydrm more like a library, exporting the internals.
> - Move the struct drm_driver definition from the tinydrm module to the
>   driver using a helper macro: TINYDRM_DRM_DRIVER.
> - Remove dirtyfb() async code.
> - Added support for partial display updates.
> 
> Noralf Trønnes (8):
>   drm/fb-helper: Add fb_deferred_io support
>   drm/fb-cma-helper: Add fb_deferred_io support
>   drm: Add helper for simple kms drivers
>   drm: Add DRM support for tiny LCD displays
>   drm/tinydrm: Add lcd register abstraction
>   drm/tinydrm/lcdreg: Add SPI support
>   drm/tinydrm: Add mipi-dbi support
>   drm/tinydrm: Add support for several Adafruit TFT displays
> 
>  drivers/gpu/drm/Kconfig                            |   9 +
>  drivers/gpu/drm/Makefile                           |   2 +
>  drivers/gpu/drm/drm_fb_cma_helper.c                | 149 ++++-
>  drivers/gpu/drm/drm_fb_helper.c                    | 189 +++++-
>  drivers/gpu/drm/drm_simple_kms_helper.c            | 262 ++++++++
>  drivers/gpu/drm/tinydrm/Kconfig                    |  25 +
>  drivers/gpu/drm/tinydrm/Makefile                   |   8 +
>  drivers/gpu/drm/tinydrm/adafruit-tft.c             | 257 ++++++++
>  drivers/gpu/drm/tinydrm/core/Makefile              |   6 +
>  drivers/gpu/drm/tinydrm/core/tinydrm-core.c        | 155 +++++
>  .../gpu/drm/tinydrm/core/tinydrm-display-pipe.c    |  82 +++
>  drivers/gpu/drm/tinydrm/core/tinydrm-fbdev.c       |  94 +++
>  drivers/gpu/drm/tinydrm/core/tinydrm-framebuffer.c |  99 +++
>  drivers/gpu/drm/tinydrm/core/tinydrm-helpers.c     |  95 +++
>  drivers/gpu/drm/tinydrm/lcdreg/Kconfig             |   8 +
>  drivers/gpu/drm/tinydrm/lcdreg/Makefile            |   5 +
>  drivers/gpu/drm/tinydrm/lcdreg/internal.h          |   8 +
>  drivers/gpu/drm/tinydrm/lcdreg/lcdreg-core.c       | 190 ++++++
>  drivers/gpu/drm/tinydrm/lcdreg/lcdreg-debugfs.c    | 281 ++++++++
>  drivers/gpu/drm/tinydrm/lcdreg/lcdreg-spi.c        | 720 +++++++++++++++++++++
>  drivers/gpu/drm/tinydrm/mipi-dbi.c                 | 253 ++++++++
>  include/drm/drm_fb_cma_helper.h                    |  14 +
>  include/drm/drm_fb_helper.h                        |  15 +
>  include/drm/drm_simple_kms_helper.h                |  44 ++
>  include/drm/tinydrm/ili9340.h                      |  47 ++
>  include/drm/tinydrm/lcdreg-spi.h                   |  63 ++
>  include/drm/tinydrm/lcdreg.h                       | 126 ++++
>  include/drm/tinydrm/mipi-dbi.h                     |  24 +
>  include/drm/tinydrm/tinydrm.h                      | 143 ++++
>  29 files changed, 3360 insertions(+), 13 deletions(-)
>  create mode 100644 drivers/gpu/drm/drm_simple_kms_helper.c
>  create mode 100644 drivers/gpu/drm/tinydrm/Kconfig
>  create mode 100644 drivers/gpu/drm/tinydrm/Makefile
>  create mode 100644 drivers/gpu/drm/tinydrm/adafruit-tft.c
>  create mode 100644 drivers/gpu/drm/tinydrm/core/Makefile
>  create mode 100644 drivers/gpu/drm/tinydrm/core/tinydrm-core.c
>  create mode 100644 drivers/gpu/drm/tinydrm/core/tinydrm-display-pipe.c
>  create mode 100644 drivers/gpu/drm/tinydrm/core/tinydrm-fbdev.c
>  create mode 100644 drivers/gpu/drm/tinydrm/core/tinydrm-framebuffer.c
>  create mode 100644 drivers/gpu/drm/tinydrm/core/tinydrm-helpers.c
>  create mode 100644 drivers/gpu/drm/tinydrm/lcdreg/Kconfig
>  create mode 100644 drivers/gpu/drm/tinydrm/lcdreg/Makefile
>  create mode 100644 drivers/gpu/drm/tinydrm/lcdreg/internal.h
>  create mode 100644 drivers/gpu/drm/tinydrm/lcdreg/lcdreg-core.c
>  create mode 100644 drivers/gpu/drm/tinydrm/lcdreg/lcdreg-debugfs.c
>  create mode 100644 drivers/gpu/drm/tinydrm/lcdreg/lcdreg-spi.c
>  create mode 100644 drivers/gpu/drm/tinydrm/mipi-dbi.c
>  create mode 100644 include/drm/drm_simple_kms_helper.h
>  create mode 100644 include/drm/tinydrm/ili9340.h
>  create mode 100644 include/drm/tinydrm/lcdreg-spi.h
>  create mode 100644 include/drm/tinydrm/lcdreg.h
>  create mode 100644 include/drm/tinydrm/mipi-dbi.h
>  create mode 100644 include/drm/tinydrm/tinydrm.h
> 
> --
> 2.2.2
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

      parent reply	other threads:[~2016-04-13 11:11 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-08 17:05 [RFC v2 0/8] drm: Add support for tiny LCD displays Noralf Trønnes
2016-04-08 17:05 ` [RFC v2 1/8] drm/fb-helper: Add fb_deferred_io support Noralf Trønnes
2016-04-13 10:57   ` Daniel Vetter
2016-04-13 11:09   ` Daniel Vetter
2016-04-18 15:15     ` Noralf Trønnes
2016-04-20 11:12       ` Daniel Vetter
2016-04-20 15:22         ` Noralf Trønnes
2016-04-20 22:29       ` Dave Airlie
2016-04-21  6:53         ` Daniel Vetter
2016-04-08 17:05 ` [RFC v2 2/8] drm/fb-cma-helper: " Noralf Trønnes
2016-04-13 11:19   ` Daniel Vetter
2016-04-08 17:05 ` [RFC v2 3/8] drm: Add helper for simple kms drivers Noralf Trønnes
2016-04-13 11:05   ` Daniel Vetter
2016-05-02 15:55     ` Noralf Trønnes
2016-05-02 20:20       ` Daniel Vetter
2016-04-08 17:05 ` [RFC v2 4/8] drm: Add DRM support for tiny LCD displays Noralf Trønnes
2016-04-08 17:05 ` [RFC v2 5/8] drm/tinydrm: Add lcd register abstraction Noralf Trønnes
2016-04-08 17:05 ` [RFC v2 6/8] drm/tinydrm/lcdreg: Add SPI support Noralf Trønnes
2016-04-08 17:05 ` [RFC v2 7/8] drm/tinydrm: Add mipi-dbi support Noralf Trønnes
2016-04-08 17:05 ` [RFC v2 8/8] drm/tinydrm: Add support for several Adafruit TFT displays Noralf Trønnes
2016-04-13 11:11 ` Daniel Vetter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160413111146.GA2510@phenom.ffwll.local \
    --to=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=noralf@tronnes.org \
    --cc=thomas.petazzoni@free-electrons.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox