From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 09/15] drm/modes: move reference taking into object lookup. Date: Thu, 21 Apr 2016 11:05:20 +0200 Message-ID: <20160421090520.GL2510@phenom.ffwll.local> References: <1460697046-23781-1-git-send-email-airlied@gmail.com> <1460697046-23781-10-git-send-email-airlied@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x235.google.com (mail-wm0-x235.google.com [IPv6:2a00:1450:400c:c09::235]) by gabe.freedesktop.org (Postfix) with ESMTPS id 934B86EC3A for ; Thu, 21 Apr 2016 09:05:24 +0000 (UTC) Received: by mail-wm0-x235.google.com with SMTP id n3so121655776wmn.0 for ; Thu, 21 Apr 2016 02:05:24 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1460697046-23781-10-git-send-email-airlied@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Dave Airlie Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCBBcHIgMTUsIDIwMTYgYXQgMDM6MTA6NDBQTSArMTAwMCwgRGF2ZSBBaXJsaWUgd3Jv dGU6Cj4gRnJvbTogRGF2ZSBBaXJsaWUgPGFpcmxpZWRAcmVkaGF0LmNvbT4KPiAKPiBXaGVuIHdl IGxvb2t1cCBhbiByZWYgY291bnRlZCBvYmplY3Qgd2Ugbm93IHRha2UgYSBwcm9wZXIgcmVmZXJl bmNlCj4gdXNpbmcga3JlZl9nZXRfdW5sZXNzX3plcm8uCj4gCj4gRnJhbWVidWZmZXIgbG9va3Vw IG5vIGxvbmdlciBuZWVkcyBkbyB0aGlzIGl0c2VsZi4KPiAKPiBDb252ZXJ0IHJtZmIgdG8gdXNp bmcgZnJhbWVidWZmZXIgbG9va3VwIGFuZCBkZWFsIHdpdGggdGhlIGZhY3QKPiBpdCBub3cgZ2V0 cyBhbiBleHRyYSByZWZlcmVuY2UgdGhhdCB3ZSBoYXZlIHRvIGNsZWFudXAuIFRoaXMgc2hvdWxk Cj4gbWVhbiB3ZSBjYW4gYXZvaWQgaG9sZGluZyBmYl9sb2NrIGFjcm9zcyBybWZiLiAoaWYgSSdt IHdyb25nIGxldCBtZQo+IGtub3cpLgo+IAo+IFdlIGFsc28gbm93IG9ubHkgaG9sZCB0aGUgZmJz X2xvY2sgYXJvdW5kIHRoZSBsaXN0IG1hbmlwdWxhdGlvbi4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBE YXZlIEFpcmxpZSA8YWlybGllZEByZWRoYXQuY29tPgoKTmVlZHMgdGhlIHNhbWUgY29tbWVudCBh cyBwYXRjaCA3IGFkZGVkIHRvIHRoZSBjb21taXQgbWVzc2FnZToKCiJQcmV2aW91c2x5IGZiIHJl ZmNvdW50aW5nLCBhbmQgZXNwZWNpYWxseSB0aGUgd2VhayByZWZlcmVuY2UKKGtyZWZfZ2V0X3Vu bGVzc196ZXJvKSB1c2VkIGluIGZiIGxvb2t1cHMgaGF2ZSBiZWVuIHByb3RlY3RlZCBieSBmYl9s b2NrLgpCdXQgd2l0aCB0aGUgcmVmYWN0b3JpbmcgdG8gc2hhcmUgcmVmY291bnRpbmcgaW4gdGhl IGRybV9tb2RlX29iamVjdCBiYXNlCmNsYXNzIHRoYXQgc3dpdGNoZWQgdG8gYmVpbmcgcHJvdGVj dGVkIGJ5IGlkcl9tdXRleCwgd2hpY2ggbWVhbnMgZmJfbG9jawpjcml0aWNhbCBzZWN0aW9ucyBj YW4gYmUgcmVkdWNlZC4iCgpXaXRoIHRoYXQ6IFJldmlld2VkLWJ5OiBEYW5pZWwgVmV0dGVyIDxk YW5pZWwudmV0dGVyQGZmd2xsLmNoPgoKPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2RybV9jcnRj LmMgfCAzNyArKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0tCj4gIDEgZmlsZSBj aGFuZ2VkLCAyMCBpbnNlcnRpb25zKCspLCAxNyBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0 IGEvZHJpdmVycy9ncHUvZHJtL2RybV9jcnRjLmMgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2NydGMu Ywo+IGluZGV4IDIxY2I5OTguLmU0N2M0YTIgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJt L2RybV9jcnRjLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2NydGMuYwo+IEBAIC0zNjQs NiArMzY0LDExIEBAIHN0YXRpYyBzdHJ1Y3QgZHJtX21vZGVfb2JqZWN0ICpfb2JqZWN0X2ZpbmQo c3RydWN0IGRybV9kZXZpY2UgKmRldiwKPiAgCWlmIChvYmogJiYKPiAgCSAgICBvYmotPnR5cGUg PT0gRFJNX01PREVfT0JKRUNUX0JMT0IpCj4gIAkJb2JqID0gTlVMTDsKPiArCj4gKwlpZiAob2Jq ICYmIG9iai0+ZnJlZV9jYikgewo+ICsJCWlmICgha3JlZl9nZXRfdW5sZXNzX3plcm8oJm9iai0+ cmVmY291bnQpKQo+ICsJCQlvYmogPSBOVUxMOwo+ICsJfQo+ICAJbXV0ZXhfdW5sb2NrKCZkZXYt Pm1vZGVfY29uZmlnLmlkcl9tdXRleCk7Cj4gIAo+ICAJcmV0dXJuIG9iajsKPiBAQCAtNDk1LDEx ICs1MDAsOCBAQCBzdHJ1Y3QgZHJtX2ZyYW1lYnVmZmVyICpkcm1fZnJhbWVidWZmZXJfbG9va3Vw KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4gIAo+ICAJbXV0ZXhfbG9jaygmZGV2LT5tb2RlX2Nv bmZpZy5mYl9sb2NrKTsKPiAgCW9iaiA9IF9vYmplY3RfZmluZChkZXYsIGlkLCBEUk1fTU9ERV9P QkpFQ1RfRkIpOwo+IC0JaWYgKG9iaikgewo+ICsJaWYgKG9iaikKPiAgCQlmYiA9IG9ial90b19m YihvYmopOwo+IC0JCWlmICgha3JlZl9nZXRfdW5sZXNzX3plcm8oJmZiLT5iYXNlLnJlZmNvdW50 KSkKPiAtCQkJZmIgPSBOVUxMOwo+IC0JfQo+ICAJbXV0ZXhfdW5sb2NrKCZkZXYtPm1vZGVfY29u ZmlnLmZiX2xvY2spOwo+ICAKPiAgCXJldHVybiBmYjsKPiBAQCAtMzQzNCwzNyArMzQzNiwzOCBA QCBpbnQgZHJtX21vZGVfcm1mYihzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+ICB7Cj4gIAlzdHJ1 Y3QgZHJtX2ZyYW1lYnVmZmVyICpmYiA9IE5VTEw7Cj4gIAlzdHJ1Y3QgZHJtX2ZyYW1lYnVmZmVy ICpmYmwgPSBOVUxMOwo+IC0Jc3RydWN0IGRybV9tb2RlX29iamVjdCAqb2JqOwo+ICAJdWludDMy X3QgKmlkID0gZGF0YTsKPiAgCWludCBmb3VuZCA9IDA7Cj4gIAo+ICAJaWYgKCFkcm1fY29yZV9j aGVja19mZWF0dXJlKGRldiwgRFJJVkVSX01PREVTRVQpKQo+ICAJCXJldHVybiAtRUlOVkFMOwo+ ICAKPiArCWZiID0gZHJtX2ZyYW1lYnVmZmVyX2xvb2t1cChkZXYsICppZCk7Cj4gKwlpZiAoIWZi KQo+ICsJCXJldHVybiAtRU5PRU5UOwo+ICsKPiAgCW11dGV4X2xvY2soJmZpbGVfcHJpdi0+ZmJz X2xvY2spOwo+IC0JbXV0ZXhfbG9jaygmZGV2LT5tb2RlX2NvbmZpZy5mYl9sb2NrKTsKPiAtCW9i aiA9IF9vYmplY3RfZmluZChkZXYsICppZCwgRFJNX01PREVfT0JKRUNUX0ZCKTsKPiAtCWlmICgh b2JqKQo+IC0JCWdvdG8gZmFpbF9sb29rdXA7Cj4gLQlmYiA9IG9ial90b19mYihvYmopOwo+ICAJ bGlzdF9mb3JfZWFjaF9lbnRyeShmYmwsICZmaWxlX3ByaXYtPmZicywgZmlscF9oZWFkKQo+ICAJ CWlmIChmYiA9PSBmYmwpCj4gIAkJCWZvdW5kID0gMTsKPiAtCWlmICghZm91bmQpCj4gLQkJZ290 byBmYWlsX2xvb2t1cDsKPiArCWlmICghZm91bmQpIHsKPiArCQltdXRleF91bmxvY2soJmZpbGVf cHJpdi0+ZmJzX2xvY2spOwo+ICsJCWdvdG8gZmFpbF91bnJlZjsKPiArCX0KPiAgCj4gIAlsaXN0 X2RlbF9pbml0KCZmYi0+ZmlscF9oZWFkKTsKPiAtCW11dGV4X3VubG9jaygmZGV2LT5tb2RlX2Nv bmZpZy5mYl9sb2NrKTsKPiAgCW11dGV4X3VubG9jaygmZmlsZV9wcml2LT5mYnNfbG9jayk7Cj4g IAo+ICsJLyogd2Ugbm93IG93biB0aGUgcmVmZXJlbmNlIHRoYXQgd2FzIHN0b3JlZCBpbiB0aGUg ZmJzIGxpc3QgKi8KPiAgCWRybV9mcmFtZWJ1ZmZlcl91bnJlZmVyZW5jZShmYik7Cj4gIAo+IC0J cmV0dXJuIDA7Cj4gKwkvKiBkcm9wIHRoZSByZWZlcmVuY2Ugd2UgcGlja2VkIHVwIGluIGZyYW1l YnVmZmVyIGxvb2t1cCAqLwo+ICsJZHJtX2ZyYW1lYnVmZmVyX3VucmVmZXJlbmNlKGZiKTsKPiAg Cj4gLWZhaWxfbG9va3VwOgo+IC0JbXV0ZXhfdW5sb2NrKCZkZXYtPm1vZGVfY29uZmlnLmZiX2xv Y2spOwo+IC0JbXV0ZXhfdW5sb2NrKCZmaWxlX3ByaXYtPmZic19sb2NrKTsKPiArCXJldHVybiAw Owo+ICAKPiArZmFpbF91bnJlZjoKPiArCWRybV9mcmFtZWJ1ZmZlcl91bnJlZmVyZW5jZShmYik7 Cj4gIAlyZXR1cm4gLUVOT0VOVDsKPiAgfQo+ICAKPiAtLSAKPiAyLjUuNQo+IAo+IF9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gZHJpLWRldmVsIG1haWxp bmcgbGlzdAo+IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwczovL2xpc3Rz LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAoKLS0gCkRhbmllbCBW ZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBvcmF0aW9uCmh0dHA6Ly9ibG9nLmZm d2xsLmNoCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRy aS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRw czovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=