dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Mihai Donțu" <mihai.dontu@gmail.com>
To: Rodrigo Vivi <rodrigo.vivi@gmail.com>
Cc: dri-devel@lists.freedesktop.org,
	Daniel Vetter <daniel.vetter@intel.com>,
	"Pandiyan, Dhinakaran" <dhinakaran.pandiyan@intel.com>
Subject: Re: i915: screen flicker
Date: Wed, 27 Apr 2016 20:36:13 +0300	[thread overview]
Message-ID: <20160427203613.7c394878@mdontu-l> (raw)
In-Reply-To: <CABVU7+t7anmtg6382dudWeQy-nyDbejmzJqYy5NjmtuNOKUv2g@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1402 bytes --]

On Wed, 27 Apr 2016 08:28:20 -0700 Rodrigo Vivi wrote:
> Hi Mihai,
> 
> What platform do you have? HSW or BDW?

I have an i7, Haswell CPU.

> If you don't know please provide lspci -nn

I have attached the output of lspci, just in case. :-)

> What happens if you boot with i915.enable_psr=2?

I'll try now.

> In case it helps, could you please boot with default
> i915.enable_psr=-1 appying this patch to your kernel to know what your
> VBT recommends:
> diff --git a/drivers/gpu/drm/i915/intel_psr.c
> b/drivers/gpu/drm/i915/intel_psr.c
> index c3abae4..68bc405 100644
> --- a/drivers/gpu/drm/i915/intel_psr.c
> +++ b/drivers/gpu/drm/i915/intel_psr.c
> @@ -798,6 +798,8 @@ void intel_psr_init(struct drm_device *dev)
>                 /* For new platforms let's respect VBT back again */
>                 dev_priv->psr.link_standby =
> dev_priv->vbt.psr.full_link;
> 
> +       DRM_ERROR("PSR: VBT recommends link_standby %d, using %d\n",
> dev_priv->vbt.psr.full_link, dev_priv->psr.link_standby);
> +
>         /* Override link_standby x link_off defaults */
>         if (i915.enable_psr == 2 && !dev_priv->psr.link_standby) {
>                 DRM_DEBUG_KMS("PSR: Forcing link standby\n");
> 

I applied your patch and booted with enable_psr=-1

[    0.763651] [drm:intel_psr_init] *ERROR* PSR: VBT recommends link_standby 0, using 0

-- 
Mihai Donțu

[-- Attachment #2: lspci.txt --]
[-- Type: text/plain, Size: 1461 bytes --]

00:00.0 Host bridge [0600]: Intel Corporation Haswell-ULT DRAM Controller [8086:0a04] (rev 0b)
00:02.0 VGA compatible controller [0300]: Intel Corporation Haswell-ULT Integrated Graphics Controller [8086:0a16] (rev 0b)
00:03.0 Audio device [0403]: Intel Corporation Haswell-ULT HD Audio Controller [8086:0a0c] (rev 0b)
00:14.0 USB controller [0c03]: Intel Corporation 8 Series USB xHCI HC [8086:9c31] (rev 04)
00:16.0 Communication controller [0780]: Intel Corporation 8 Series HECI #0 [8086:9c3a] (rev 04)
00:16.3 Serial controller [0700]: Intel Corporation 8 Series HECI KT [8086:9c3d] (rev 04)
00:19.0 Ethernet controller [0200]: Intel Corporation Ethernet Connection I218-LM [8086:155a] (rev 04)
00:1b.0 Audio device [0403]: Intel Corporation 8 Series HD Audio Controller [8086:9c20] (rev 04)
00:1c.0 PCI bridge [0604]: Intel Corporation 8 Series PCI Express Root Port 1 [8086:9c10] (rev e4)
00:1c.3 PCI bridge [0604]: Intel Corporation 8 Series PCI Express Root Port 4 [8086:9c16] (rev e4)
00:1d.0 USB controller [0c03]: Intel Corporation 8 Series USB EHCI #1 [8086:9c26] (rev 04)
00:1f.0 ISA bridge [0601]: Intel Corporation 8 Series LPC Controller [8086:9c43] (rev 04)
00:1f.2 SATA controller [0106]: Intel Corporation 8 Series SATA Controller 1 [AHCI mode] [8086:9c03] (rev 04)
00:1f.3 SMBus [0c05]: Intel Corporation 8 Series SMBus Controller [8086:9c22] (rev 04)
02:00.0 Network controller [0280]: Intel Corporation Wireless 7260 [8086:08b1] (rev 73)

[-- Attachment #3: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2016-04-27 17:37 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-26 21:46 i915: screen flicker Mihai Donțu
2016-04-27  7:09 ` Jani Nikula
2016-04-27 10:07   ` Mihai Donțu
2016-04-27 10:35     ` Jani Nikula
2016-04-27 15:28       ` Rodrigo Vivi
2016-04-27 17:36         ` Mihai Donțu [this message]
2016-04-27 17:42           ` Mihai Donțu
2016-04-28  8:02             ` Jani Nikula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160427203613.7c394878@mdontu-l \
    --to=mihai.dontu@gmail.com \
    --cc=daniel.vetter@intel.com \
    --cc=dhinakaran.pandiyan@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=rodrigo.vivi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox