From: Daniel Vetter <daniel@ffwll.ch>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: linux-renesas-soc@vger.kernel.org,
laurent.pinchart@ideasonboard.com,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 1/4] drm_mode: add TCON encoder/connector
Date: Fri, 29 Apr 2016 11:13:23 +0200 [thread overview]
Message-ID: <20160429083529.GA14148@phenom.ffwll.local> (raw)
In-Reply-To: <19760070.fVPA1G30uu@wasted.cogentembedded.com>
On Fri, Apr 29, 2016 at 12:02:15AM +0300, Sergei Shtylyov wrote:
> TCON (Timing Controller) usually means a chip that drives a LCD panel.
> In our case, such controller is a part of the Renesas R-Car SoCs. Add
> the TCON encoder/connector #define's to be used by the TCON support code
> in the Renesas R-Car Display Unit (DU) driver.
>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>
> ---
> include/uapi/drm/drm_mode.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> Index: linux/include/uapi/drm/drm_mode.h
> ===================================================================
> --- linux.orig/include/uapi/drm/drm_mode.h
> +++ linux/include/uapi/drm/drm_mode.h
> @@ -202,6 +202,7 @@ struct drm_mode_get_plane_res {
> #define DRM_MODE_ENCODER_VIRTUAL 5
> #define DRM_MODE_ENCODER_DSI 6
> #define DRM_MODE_ENCODER_DPMST 7
> +#define DRM_MODE_ENCODER_TCON 8
>
> struct drm_mode_get_encoder {
> __u32 encoder_id;
> @@ -241,6 +242,7 @@ struct drm_mode_get_encoder {
> #define DRM_MODE_CONNECTOR_eDP 14
> #define DRM_MODE_CONNECTOR_VIRTUAL 15
> #define DRM_MODE_CONNECTOR_DSI 16
> +#define DRM_MODE_CONNECTOR_TCON 17
>
> struct drm_mode_get_connector {
The trouble with adding more here is that everytime you do this all the
userspace needs to be extended to print something reasonable for this type
of connector. For external connectors that makes sense (since users need
to know whether it's the hdmi or DP plug), but for internal panels I'd
honestly just go with lvds for anything that's not a more complex standard
like eDP or DSI.
Just my 2 cents really, not strong opinion, and we'll not run out of
connector type numbers anytime soon ;-)
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-04-29 9:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-28 21:00 [PATCH 0/4] Add TCON support to the R-Car DU driver Sergei Shtylyov
2016-04-28 21:02 ` [PATCH 1/4] drm_mode: add TCON encoder/connector Sergei Shtylyov
2016-04-29 9:13 ` Daniel Vetter [this message]
2016-04-28 21:03 ` [PATCH 2/4] rcar-du: add TCON encoder driver Sergei Shtylyov
2016-05-27 21:28 ` Laurent Pinchart
2016-04-28 21:04 ` [PATCH 3/4] rcar-du: add TCON connector driver Sergei Shtylyov
2016-04-28 21:05 ` [PATCH 4/4] rcar-du: add R8A7794 TCON support Sergei Shtylyov
2016-05-27 21:33 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160429083529.GA14148@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox