From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: Jianwei Wang <jianwei.wang.chn@gmail.com>,
Meng Yi <meng.yi@nxp.com>,
Xiubo Li <lixiubo@cmss.chinamobile.com>,
Emil Velikov <emil.l.velikov@gmail.com>,
Alison Wang <alison.wang@nxp.com>,
Nicolas Ferre <nicolas.ferre@atmel.com>,
dri-devel <dri-devel@lists.freedesktop.org>,
Alexandre Belloni <alexandre.belloni@free-electrons.com>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>
Subject: Re: [PATCH v3 1/2] drm: bridge: Add sii902x driver
Date: Tue, 3 May 2016 12:03:08 +0200 [thread overview]
Message-ID: <20160503120308.269cd9a7@bbrezillon> (raw)
In-Reply-To: <CAKMK7uHCKbLN=pddNQPcYQDTMtjovF8-tb64=YqHkp0C7mFRWA@mail.gmail.com>
On Tue, 3 May 2016 11:53:18 +0200
Daniel Vetter <daniel@ffwll.ch> wrote:
> On Tue, May 3, 2016 at 11:39 AM, Boris Brezillon
> <boris.brezillon@free-electrons.com> wrote:
> >> > + .detect = sii902x_connector_detect,
> >> > + .fill_modes = drm_helper_probe_single_connector_modes,
> >> > + .destroy = sii902x_connector_destroy,
> >> > +};
> >>
> >> I'm guessing this is to support both atomic and !atomic drivers. I
> >> thought it was working automatically?
> >
> > Hm, the dw-hdmi driver is providing both, but maybe it's not needed.
> > Daniel, any comments?
>
> You only need this in case you actually have atomic and !atomic users
> of your bridge. We discussed whether we should have a dpms helper that
> dtrt automatically, but with just 1 driver that doesn't seem worth it.
> You wouldn't need to have 2 entier vfunc tables, you could just switch
> on DRIVER_ATOMIC.
Ok, I'll drop the !atomic helpers. Should I still test
drm_core_check_feature(drm, DRIVER_ATOMIC) in the ->attach()
implementation and return an error if the DRM device does not support
atomic operations?
--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-05-03 10:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-16 14:14 [PATCH v3 1/2] drm: bridge: Add sii902x driver Boris Brezillon
2016-03-16 14:14 ` [PATCH v3 2/2] drm: bridge: add sii902x DT bindings doc Boris Brezillon
2016-04-22 9:58 ` [PATCH v3 1/2] drm: bridge: Add sii902x driver Meng Yi
2016-04-22 11:32 ` Boris Brezillon
2016-05-02 11:05 ` Maxime Ripard
2016-05-03 9:39 ` Boris Brezillon
2016-05-03 9:53 ` Daniel Vetter
2016-05-03 10:03 ` Boris Brezillon [this message]
2016-05-03 12:54 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160503120308.269cd9a7@bbrezillon \
--to=boris.brezillon@free-electrons.com \
--cc=alexandre.belloni@free-electrons.com \
--cc=alison.wang@nxp.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=emil.l.velikov@gmail.com \
--cc=jianwei.wang.chn@gmail.com \
--cc=lixiubo@cmss.chinamobile.com \
--cc=maxime.ripard@free-electrons.com \
--cc=meng.yi@nxp.com \
--cc=nicolas.ferre@atmel.com \
--cc=plagnioj@jcrosoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox