From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 3/4] drm: Add helper for simple display pipeline Date: Tue, 10 May 2016 08:59:34 +0200 Message-ID: <20160510065934.GG27098@phenom.ffwll.local> References: <1462454674-2246-1-git-send-email-noralf@tronnes.org> <1462454674-2246-4-git-send-email-noralf@tronnes.org> <20160509144648.GA27098@phenom.ffwll.local> <8b885635-4df5-e902-a755-3f32cab75131@tronnes.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x236.google.com (mail-wm0-x236.google.com [IPv6:2a00:1450:400c:c09::236]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3B8F86E57D for ; Tue, 10 May 2016 06:59:36 +0000 (UTC) Received: by mail-wm0-x236.google.com with SMTP id e201so164236254wme.0 for ; Mon, 09 May 2016 23:59:36 -0700 (PDT) Content-Disposition: inline In-Reply-To: <8b885635-4df5-e902-a755-3f32cab75131@tronnes.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Noralf =?iso-8859-1?Q?Tr=F8nnes?= Cc: treding@nvidia.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org T24gTW9uLCBNYXkgMDksIDIwMTYgYXQgMDg6Mzc6MzlQTSArMDIwMCwgTm9yYWxmIFRyw7hubmVz IHdyb3RlOgo+IAo+IERlbiAwOS4wNS4yMDE2IDE2OjQ2LCBza3JldiBEYW5pZWwgVmV0dGVyOgo+ ID5PbiBUaHUsIE1heSAwNSwgMjAxNiBhdCAwMzoyNDozM1BNICswMjAwLCBOb3JhbGYgVHLDuG5u ZXMgd3JvdGU6Cj4gPj5Qcm92aWRlcyBoZWxwZXIgZnVuY3Rpb25zIGZvciBkcml2ZXJzIHRoYXQg aGF2ZSBhIHNpbXBsZSBkaXNwbGF5Cj4gPj5waXBlbGluZS4gUGxhbmUsIGNydGMgYW5kIGVuY29k ZXIgYXJlIGNvbGxhcHNlZCBpbnRvIG9uZSBlbnRpdHkuCj4gPj4KPiA+PlNpZ25lZC1vZmYtYnk6 IE5vcmFsZiBUcsO4bm5lcyA8bm9yYWxmQHRyb25uZXMub3JnPgo+ID4+K3N0YXRpYyBpbnQgZHJt X3NpbXBsZV9rbXNfcGxhbmVfYXRvbWljX2NoZWNrKHN0cnVjdCBkcm1fcGxhbmUgKnBsYW5lLAo+ ID4+KwkJCQkJc3RydWN0IGRybV9wbGFuZV9zdGF0ZSAqcHN0YXRlKQo+ID4+K3sKPiA+PisJc3Ry dWN0IGRybV9zaW1wbGVfZGlzcGxheV9waXBlICpwaXBlOwo+ID4+KwlzdHJ1Y3QgZHJtX2NydGNf c3RhdGUgKmNzdGF0ZTsKPiA+PisKPiA+PisJcGlwZSA9IGNvbnRhaW5lcl9vZihwbGFuZSwgc3Ry dWN0IGRybV9zaW1wbGVfZGlzcGxheV9waXBlLCBwbGFuZSk7Cj4gPj4rCWlmICghcGlwZS0+ZnVu Y3MgfHwgIXBpcGUtPmZ1bmNzLT5jaGVjaykKPiA+PisJCXJldHVybiAwOwo+ID4+Kwo+ID4+Kwlj c3RhdGUgPSBkcm1fYXRvbWljX2dldF9leGlzdGluZ19jcnRjX3N0YXRlKHBzdGF0ZS0+c3RhdGUs Cj4gPj4rCQkJCQkJICAgICZwaXBlLT5jcnRjKTsKPiA+PisKPiA+PisJcmV0dXJuIHBpcGUtPmZ1 bmNzLT5jaGVjayhwaXBlLCBwc3RhdGUsIGNzdGF0ZSk7Cj4gPj4rfQo+ID5PayBvbmUgdGhpbmcg SSd2ZSBtaXNzZWQgaGVyZSBpcyB0aGF0IGZvciBtb3N0IGRyaXZlcnMgdGhpcyBpcyB3YXkgdG9v Cj4gPnNpbXBsZSBhIGNoZWNrIGZ1bmN0aW9uLCB3aGljaCBtZWFucyB3ZSdsbCBlbmQgdXAgd2l0 aCB0b25zIG9mIGR1cGxpY2F0ZWQKPiA+Y29kZS4gVGhpbmdzIHdoaWNoIHRoZSBkcm0gY29yZSBh bGxvd3MsIGJ1dCBzaW1wbGUgcGlwZWxpbmVzIGFsbCBkb24ndAo+ID5yZWFsbHkgY29wZSB3aXRo Ogo+ID4tIHBsYW5lIHNjYWxpbmcKPiA+LSBkaXNhYmxpbmcgdGhlIHBsYW5lIHdpdGhvdXQgdGhl IGNydGMgKGkuZS4gc2NhbiBvdXQgYmxhY2spCj4gPi0gcGxhbmUgbm90IHNpemVkIHRvIGZpbGwg dGhlIGVudGlyZSBoYWN0aXZlL3ZhY3RpdmUKPiA+Cj4gPlRoZXJlJ3MgYSBoZWxwZXIgdG8gZG8g bW9zdCBvZiB0aGVzZSBjaGVja3MgZm9yIHlvdSAtCj4gPmRybV9wbGFuZV9oZWxwZXJfY2hlY2tf dXBkYXRlLiBJIHRoaW5rIGl0J2QgYmUgZ29vZCB0byBwbGFjZSBhIGNhbGwgZm9yCj4gPnRoYXQg aW4gaGVyZSwgYmVmb3JlIHdlIGNhbGwgZG93biBpbnRvIHRoZSBkcml2ZXIncyAtPmNoZWNrIGNh bGxiYWNrLiBCdXQKPiA+b2ZjIGJlZm9yZSB3ZSByZXR1cm4gMDsgd2Ugd2FudCB0aGVzZSBjaGVj a3MgYWx3YXlzIGRvbmUuIEFuZCBjYXRjaCBhbGwKPiA+dGhlc2UgdGhpbmdzIHNvIHRoYXQgZHJp dmVycyBuZXZlciBmYWxsIG92ZXIgdGhpcyBwaXRmYWxsLgo+IAo+IERvZXMgdGhpcyByZXNlbWJs ZSB3aGF0IHlvdSdyZSBhZnRlcj8gSSdtIGp1c3QgZ3Vlc3NpbmcgaGVyZS4KPiAKPiBzdGF0aWMg aW50IGRybV9zaW1wbGVfa21zX3BsYW5lX2F0b21pY19jaGVjayhzdHJ1Y3QgZHJtX3BsYW5lICpw bGFuZSwKPiAgICAgICAgICAgICAgICAgICAgIHN0cnVjdCBkcm1fcGxhbmVfc3RhdGUgKnBzdGF0 ZSkKPiB7Cj4gICAgIHN0cnVjdCBkcm1fcmVjdCBzcmMgPSB7Cj4gICAgICAgICAueDEgPSBwc3Rh dGUtPnNyY194LAo+ICAgICAgICAgLnkxID0gcHN0YXRlLT5zcmNfeSwKPiAgICAgICAgIC54MiA9 IHBzdGF0ZS0+c3JjX3ggKyBwc3RhdGUtPnNyY193LAo+ICAgICAgICAgLnkyID0gcHN0YXRlLT5z cmNfeSArIHBzdGF0ZS0+c3JjX2gsCj4gICAgIH07Cj4gICAgIHN0cnVjdCBkcm1fcmVjdCBkZXN0 ID0gewo+ICAgICAgICAgLngxID0gcHN0YXRlLT5jcnRjX3gsCj4gICAgICAgICAueTEgPSBwc3Rh dGUtPmNydGNfeSwKPiAgICAgICAgIC54MiA9IHBzdGF0ZS0+Y3J0Y194ICsgcHN0YXRlLT5jcnRj X3csCj4gICAgICAgICAueTIgPSBwc3RhdGUtPmNydGNfeSArIHBzdGF0ZS0+Y3J0Y19oLAo+ICAg ICB9Owo+ICAgICBzdHJ1Y3QgZHJtX3JlY3QgY2xpcCA9IHsgMCB9OwoKQ2xpcCByZWN0IG5lZWRz IHRvIGJlIHNldCB0byBjcnRjX3N0YXRlLT5hZGp1c3RlZF9tb2RlLmgvdmRpc3BsYXksIHNlZQpy b2NrY2hpcCBvciBhcm1hZGEuIE90aGVyd2lzZSB5b3UnbGwgY2xpcCB0byBub3RoaW5nIGFuZCBh bHdheXMgZmFpbC4KCj4gICAgIHN0cnVjdCBkcm1fc2ltcGxlX2Rpc3BsYXlfcGlwZSAqcGlwZTsK PiAgICAgc3RydWN0IGRybV9jcnRjX3N0YXRlICpjc3RhdGU7Cj4gICAgIGJvb2wgdmlzaWJsZTsK PiAgICAgaW50IHJldDsKPiAKPiAgICAgcGlwZSA9IGNvbnRhaW5lcl9vZihwbGFuZSwgc3RydWN0 IGRybV9zaW1wbGVfZGlzcGxheV9waXBlLCBwbGFuZSk7Cj4gICAgIGNsaXAueDIgPSBwaXBlLT5j cnRjLm1vZGUuaGRpc3BsYXk7Cj4gICAgIGNsaXAueTIgPSBwaXBlLT5jcnRjLm1vZGUudmRpc3Bs YXk7Cj4gICAgIHJldCA9IGRybV9wbGFuZV9oZWxwZXJfY2hlY2tfdXBkYXRlKHBsYW5lLCAmcGlw ZS0+Y3J0YywgcGxhbmUtPmZiLAo+ICAgICAgICAgICAgICAgICAgICAgICAgICZzcmMsICZkZXN0 LCAmY2xpcCwKPiAgICAgICAgICAgICAgICAgICAgICAgICBEUk1fUExBTkVfSEVMUEVSX05PX1ND QUxJTkcsCj4gICAgICAgICAgICAgICAgICAgICAgICAgRFJNX1BMQU5FX0hFTFBFUl9OT19TQ0FM SU5HLAo+ICAgICAgICAgICAgICAgICAgICAgICAgIGZhbHNlLCBmYWxzZSwgJnZpc2libGUpOwoK Y2FuX3VwZGF0ZV9kaXNhYmxlZCA9IHRydWUgc2hvdWxkIHdvcmssIE9ubHkgY2F2ZWF0IGlzIHRo YXQgeW91IG1pZ2h0IGdldAphIGNhbGwgdG8gdXBkYXRlIHRoZSBwcmltYXJ5IHBsYW5lIHdoZW4g dGhlIGRpc3BsYXkgaXMgdHVybmVkIG9mZi4KUHJvYmFibHkgYmVzdCB0aG91Z2ggaWYgd2UgaGFu ZGxlIHRoYXQgaW4gdGhlIHNpbXBsZSBwaXBlIGRyaXZlciB0b28uIEp1c3QKY2FsbCBkcm1fYXRv bWljX2hlbHBlcl9jb21taXRfcGxhbmVzIHdpdGggYWN0aXZlX29ubHkgPSB0cnVlLgoKPiAgICAg aWYgKHJldCkKPiAgICAgICAgIHJldHVybiByZXQ7Cj4gCj4gICAgIC8qIEhvdyB0byBoYW5kbGUg IXZpc2libGUsIGlzIGl0IGV2ZW4gcG9zc2libGU/ICovCgoJaWYgKCF2aXNpYmxlKQoJCXJldHVy biAtRUlOVkFMOwoKWW91IGNhbid0LCBzbyBuZWVkIHRvIHJlamVjdCBpdC4KPiAKPiAgICAgaWYg KCFwaXBlLT5mdW5jcyB8fCAhcGlwZS0+ZnVuY3MtPmNoZWNrKQo+ICAgICAgICAgcmV0dXJuIDA7 Cj4gCj4gICAgIGNzdGF0ZSA9IGRybV9hdG9taWNfZ2V0X2V4aXN0aW5nX2NydGNfc3RhdGUocHN0 YXRlLT5zdGF0ZSwKPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJnBpcGUtPmNydGMpOwo+ IAo+ICAgICByZXR1cm4gcGlwZS0+ZnVuY3MtPmNoZWNrKHBpcGUsIHBzdGF0ZSwgY3N0YXRlKTsK PiB9CgpDaGVlcnMsIERhbmllbAotLSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwg SW50ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmkt ZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3Jn L21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==