From: Russell King - ARM Linux <linux@armlinux.org.uk>
To: "Lothar Waßmann" <LW@KARO-electronics.de>
Cc: "Sascha Hauer" <kernel@pengutronix.de>,
"Dennis Gilmore" <dennis@ausil.us>,
dri-devel <dri-devel@lists.freedesktop.org>,
"Philipp Zabel" <p.zabel@pengutronix.de>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Dave Airlie" <airlied@redhat.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: imx-drm: regression due to commit 503fe87bd0a8 ("gpu: ipu-v3: Fix imx-ipuv3-crtc module autoloading")
Date: Fri, 13 May 2016 11:44:37 +0100 [thread overview]
Message-ID: <20160513104437.GT19428@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20160513123336.6996dd89@ipc1.ka-ro>
On Fri, May 13, 2016 at 12:33:36PM +0200, Lothar Waßmann wrote:
> I'm always very suspicious when seeing code moving of_node's from
> one device to another or assigning of_node's to platform devices that
> weren't instantiated via DT.
It's completely wrong to add an of_node to a device on the same bus
that already has a device with the same of_node - doing so means
that the bus matching code will match the same device driver to both
devices, which may not be what you want to happen.
Just don't do it, it's a bug waiting to happen.
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
next prev parent reply other threads:[~2016-05-13 10:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-13 10:33 imx-drm: regression due to commit 503fe87bd0a8 ("gpu: ipu-v3: Fix imx-ipuv3-crtc module autoloading") Lothar Waßmann
2016-05-13 10:44 ` Russell King - ARM Linux [this message]
2016-05-13 11:04 ` Philipp Zabel
2016-05-18 9:12 ` Lothar Waßmann
2016-05-18 12:50 ` Philipp Zabel
2016-05-17 14:27 ` Marcel Ziswiler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160513104437.GT19428@n2100.arm.linux.org.uk \
--to=linux@armlinux.org.uk \
--cc=LW@KARO-electronics.de \
--cc=airlied@redhat.com \
--cc=dennis@ausil.us \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=p.zabel@pengutronix.de \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox