From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] checkpatch fixes Date: Tue, 17 May 2016 15:07:25 +0200 Message-ID: <20160517130725.GM27098@phenom.ffwll.local> References: <1463435125-9635-1-git-send-email-me@tobin.cc> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x241.google.com (mail-wm0-x241.google.com [IPv6:2a00:1450:400c:c09::241]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0C8856E6D5 for ; Tue, 17 May 2016 13:07:27 +0000 (UTC) Received: by mail-wm0-x241.google.com with SMTP id w143so4647826wmw.3 for ; Tue, 17 May 2016 06:07:26 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1463435125-9635-1-git-send-email-me@tobin.cc> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Tobin C Harding Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBNYXkgMTcsIDIwMTYgYXQgMDc6NDU6MjVBTSArMTAwMCwgVG9iaW4gQyBIYXJkaW5n IHdyb3RlOgo+IEZpeCBhIGNvdXBsZSBvZiBjaGVja3BhdGNoIGVycm9ycyBhbmQgYSBidW5jaCBv ZiB3YXJuaW5ncy4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBUb2JpbiBDIEhhcmRpbmcgPG1lQHRvYmlu LmNjPgoKUGF0Y2ggbmVlZHMgYSBkcm0vZ21hNTAwOiBwcmVmaXggaW4gdGhlIHN1bW1hcnkuIEFs c28gcGxlYXNlIGxpc3QgaW4gdGhlCmNvbW1pdCBtZXNzYWdlIGl0c2VsZiB3aGF0IGtpbmRzIG9m IHdhcm5pbmdzIGV4YWN0bHkgeW91J3ZlIGZpeGVkLiBNb3N0Cm1haW50YWluZXJzIGFsc28gd2Fu dCB0aGF0IHlvdSBzcGxpdCB0aGUgcGF0Y2ggdXAgaW50byBvbmUgYWRkcmVzc2luZyBlYWNoCmlz c3VlIHNlcGFyYXRlbHkgKGUuZy4gb25lIGZvciB3aGl0ZXNwYWNlLCBvbmUgZm9yIHByaW50aywg b25lIGZvciAhPSBOVUxMCnJlbW92YWwpLgotRGFuaWVsCgo+IC0tLQo+IAo+IFR3byBvY2N1cmVu Y2VzIG9mIChmb28gIT0gTlVMTCkgY2hhbmdlZCB0byAoIWZvbykgZXZlbiB0aG91Z2ggbm90IHBp Y2tlZCB1cCBieSBjaGVja3BhdGNoLnBsCj4gCj4gIGRyaXZlcnMvZ3B1L2RybS9nbWE1MDAvY2R2 X2ludGVsX2x2ZHMuYyB8IDM5ICsrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0tLQo+ICAx IGZpbGUgY2hhbmdlZCwgMTggaW5zZXJ0aW9ucygrKSwgMjEgZGVsZXRpb25zKC0pCj4gCj4gZGlm ZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9nbWE1MDAvY2R2X2ludGVsX2x2ZHMuYyBiL2RyaXZl cnMvZ3B1L2RybS9nbWE1MDAvY2R2X2ludGVsX2x2ZHMuYwo+IGluZGV4IDgxM2VmMjMuLjM0ZjY5 NWMgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2dtYTUwMC9jZHZfaW50ZWxfbHZkcy5j Cj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2dtYTUwMC9jZHZfaW50ZWxfbHZkcy5jCj4gQEAgLTIy OSw2ICsyMjksNyBAQCBzdGF0aWMgdm9pZCBjZHZfaW50ZWxfbHZkc19zZXRfcG93ZXIoc3RydWN0 IGRybV9kZXZpY2UgKmRldiwKPiAgc3RhdGljIHZvaWQgY2R2X2ludGVsX2x2ZHNfZW5jb2Rlcl9k cG1zKHN0cnVjdCBkcm1fZW5jb2RlciAqZW5jb2RlciwgaW50IG1vZGUpCj4gIHsKPiAgCXN0cnVj dCBkcm1fZGV2aWNlICpkZXYgPSBlbmNvZGVyLT5kZXY7Cj4gKwo+ICAJaWYgKG1vZGUgPT0gRFJN X01PREVfRFBNU19PTikKPiAgCQljZHZfaW50ZWxfbHZkc19zZXRfcG93ZXIoZGV2LCBlbmNvZGVy LCB0cnVlKTsKPiAgCWVsc2UKPiBAQCAtMjg0LDcgKzI4NSw3IEBAIHN0YXRpYyBib29sIGNkdl9p bnRlbF9sdmRzX21vZGVfZml4dXAoc3RydWN0IGRybV9lbmNvZGVyICplbmNvZGVyLAo+ICAJCQkg ICAgaGVhZCkgewo+ICAJCWlmICh0bXBfZW5jb2RlciAhPSBlbmNvZGVyCj4gIAkJICAgICYmIHRt cF9lbmNvZGVyLT5jcnRjID09IGVuY29kZXItPmNydGMpIHsKPiAtCQkJcHJpbnRrKEtFUk5fRVJS ICJDYW4ndCBlbmFibGUgTFZEUyBhbmQgYW5vdGhlciAiCj4gKwkJCXByX2VycigiQ2FuJ3QgZW5h YmxlIExWRFMgYW5kIGFub3RoZXIgIgo+ICAJCQkgICAgICAgImVuY29kZXIgb24gdGhlIHNhbWUg cGlwZVxuIik7Cj4gIAkJCXJldHVybiBmYWxzZTsKPiAgCQl9Cj4gQEAgLTI5Niw3ICsyOTcsNyBA QCBzdGF0aWMgYm9vbCBjZHZfaW50ZWxfbHZkc19tb2RlX2ZpeHVwKHN0cnVjdCBkcm1fZW5jb2Rl ciAqZW5jb2RlciwKPiAgCSAqIHdpdGggdGhlIHBhbmVsIHNjYWxpbmcgc2V0IHVwIHRvIHNvdXJj ZSBmcm9tIHRoZSBIL1ZEaXNwbGF5Cj4gIAkgKiBvZiB0aGUgb3JpZ2luYWwgbW9kZS4KPiAgCSAq Lwo+IC0JaWYgKHBhbmVsX2ZpeGVkX21vZGUgIT0gTlVMTCkgewo+ICsJaWYgKHBhbmVsX2ZpeGVk X21vZGUpIHsKPiAgCQlhZGp1c3RlZF9tb2RlLT5oZGlzcGxheSA9IHBhbmVsX2ZpeGVkX21vZGUt PmhkaXNwbGF5Owo+ICAJCWFkanVzdGVkX21vZGUtPmhzeW5jX3N0YXJ0ID0gcGFuZWxfZml4ZWRf bW9kZS0+aHN5bmNfc3RhcnQ7Cj4gIAkJYWRqdXN0ZWRfbW9kZS0+aHN5bmNfZW5kID0gcGFuZWxf Zml4ZWRfbW9kZS0+aHN5bmNfZW5kOwo+IEBAIC00MTAsNyArNDExLDggQEAgc3RhdGljIGludCBj ZHZfaW50ZWxfbHZkc19nZXRfbW9kZXMoc3RydWN0IGRybV9jb25uZWN0b3IgKmNvbm5lY3RvcikK PiAgCXN0cnVjdCBwc2JfaW50ZWxfbW9kZV9kZXZpY2UgKm1vZGVfZGV2ID0gJmRldl9wcml2LT5t b2RlX2RldjsKPiAgCWludCByZXQ7Cj4gIAo+IC0JcmV0ID0gcHNiX2ludGVsX2RkY19nZXRfbW9k ZXMoY29ubmVjdG9yLCAmZ21hX2VuY29kZXItPmkyY19idXMtPmFkYXB0ZXIpOwo+ICsJcmV0ID0g cHNiX2ludGVsX2RkY19nZXRfbW9kZXMoY29ubmVjdG9yLAo+ICsJCQkJICAgICAgJmdtYV9lbmNv ZGVyLT5pMmNfYnVzLT5hZGFwdGVyKTsKPiAgCj4gIAlpZiAocmV0KQo+ICAJCXJldHVybiByZXQ7 Cj4gQEAgLTQyMyw3ICs0MjUsNyBAQCBzdGF0aWMgaW50IGNkdl9pbnRlbF9sdmRzX2dldF9tb2Rl cyhzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9yKQo+ICAJY29ubmVjdG9yLT5kaXNwbGF5 X2luZm8ubWF4X3ZmcmVxID0gMjAwOwo+ICAJY29ubmVjdG9yLT5kaXNwbGF5X2luZm8ubWluX2hm cmVxID0gMDsKPiAgCWNvbm5lY3Rvci0+ZGlzcGxheV9pbmZvLm1heF9oZnJlcSA9IDIwMDsKPiAt CWlmIChtb2RlX2Rldi0+cGFuZWxfZml4ZWRfbW9kZSAhPSBOVUxMKSB7Cj4gKwlpZiAobW9kZV9k ZXYtPnBhbmVsX2ZpeGVkX21vZGUpIHsKPiAgCQlzdHJ1Y3QgZHJtX2Rpc3BsYXlfbW9kZSAqbW9k ZSA9Cj4gIAkJICAgIGRybV9tb2RlX2R1cGxpY2F0ZShkZXYsIG1vZGVfZGV2LT5wYW5lbF9maXhl ZF9tb2RlKTsKPiAgCQlkcm1fbW9kZV9wcm9iZWRfYWRkKGNvbm5lY3RvciwgbW9kZSk7Cj4gQEAg LTUwMyw3ICs1MDUsNyBAQCBzdGF0aWMgaW50IGNkdl9pbnRlbF9sdmRzX3NldF9wcm9wZXJ0eShz dHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9yLAo+ICAJCQkJCQkJdmFsdWUpKQo+ICAJCQly ZXR1cm4gLTE7Cj4gIAkJZWxzZQo+IC0gICAgICAgICAgICAgICAgICAgICAgICBnbWFfYmFja2xp Z2h0X3NldChlbmNvZGVyLT5kZXYsIHZhbHVlKTsKPiArCQkJZ21hX2JhY2tsaWdodF9zZXQoZW5j b2Rlci0+ZGV2LCB2YWx1ZSk7Cj4gIAl9IGVsc2UgaWYgKCFzdHJjbXAocHJvcGVydHktPm5hbWUs ICJEUE1TIikgJiYgZW5jb2Rlcikgewo+ICAJCWNvbnN0IHN0cnVjdCBkcm1fZW5jb2Rlcl9oZWxw ZXJfZnVuY3MgKmhlbHBlcnMgPQo+ICAJCQkJCWVuY29kZXItPmhlbHBlcl9wcml2YXRlOwo+IEBA IC01NzQsNyArNTc2LDcgQEAgc3RhdGljIGJvb2wgbHZkc19pc19wcmVzZW50X2luX3ZidChzdHJ1 Y3QgZHJtX2RldmljZSAqZGV2LAo+ICAJCQljb250aW51ZTsKPiAgCj4gIAkJaWYgKGNoaWxkLT5p MmNfcGluKQo+IC0JCSAgICAqaTJjX3BpbiA9IGNoaWxkLT5pMmNfcGluOwo+ICsJCQkqaTJjX3Bp biA9IGNoaWxkLT5pMmNfcGluOwo+ICAKPiAgCQkvKiBIb3dldmVyLCB3ZSBjYW5ub3QgdHJ1c3Qg dGhlIEJJT1Mgd3JpdGVycyB0byBwb3B1bGF0ZQo+ICAJCSAqIHRoZSBWQlQgY29ycmVjdGx5LiAg U2luY2UgTFZEUyByZXF1aXJlcyBhZGRpdGlvbmFsCj4gQEAgLTYyNCwxMyArNjI2LDExIEBAIHZv aWQgY2R2X2ludGVsX2x2ZHNfaW5pdChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+ICAJCXJldHVy bjsKPiAgCX0KPiAgCj4gLQlnbWFfZW5jb2RlciA9IGt6YWxsb2Moc2l6ZW9mKHN0cnVjdCBnbWFf ZW5jb2RlciksCj4gLQkJCQkgICAgR0ZQX0tFUk5FTCk7Cj4gKwlnbWFfZW5jb2RlciA9IGt6YWxs b2Moc2l6ZW9mKHN0cnVjdCBnbWFfZW5jb2RlciksIEdGUF9LRVJORUwpOwo+ICAJaWYgKCFnbWFf ZW5jb2RlcikKPiAgCQlyZXR1cm47Cj4gIAo+IC0JZ21hX2Nvbm5lY3RvciA9IGt6YWxsb2Moc2l6 ZW9mKHN0cnVjdCBnbWFfY29ubmVjdG9yKSwKPiAtCQkJCSAgICAgIEdGUF9LRVJORUwpOwo+ICsJ Z21hX2Nvbm5lY3RvciA9IGt6YWxsb2Moc2l6ZW9mKHN0cnVjdCBnbWFfY29ubmVjdG9yKSwgR0ZQ X0tFUk5FTCk7Cj4gIAlpZiAoIWdtYV9jb25uZWN0b3IpCj4gIAkJZ290byBmYWlsZWRfY29ubmVj dG9yOwo+ICAKPiBAQCAtNjY1LDcgKzY2NSw3IEBAIHZvaWQgY2R2X2ludGVsX2x2ZHNfaW5pdChz dHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+ICAJY29ubmVjdG9yLT5pbnRlcmxhY2VfYWxsb3dlZCA9 IGZhbHNlOwo+ICAJY29ubmVjdG9yLT5kb3VibGVzY2FuX2FsbG93ZWQgPSBmYWxzZTsKPiAgCj4g LQkvKkF0dGFjaCBjb25uZWN0b3IgcHJvcGVydGllcyovCj4gKwkvKiBBdHRhY2ggY29ubmVjdG9y IHByb3BlcnRpZXMgKi8KPiAgCWRybV9vYmplY3RfYXR0YWNoX3Byb3BlcnR5KCZjb25uZWN0b3It PmJhc2UsCj4gIAkJCQkgICAgICBkZXYtPm1vZGVfY29uZmlnLnNjYWxpbmdfbW9kZV9wcm9wZXJ0 eSwKPiAgCQkJCSAgICAgIERSTV9NT0RFX1NDQUxFX0ZVTExTQ1JFRU4pOwo+IEBAIC02NzcsMTIg KzY3NywxMCBAQCB2b2lkIGNkdl9pbnRlbF9sdmRzX2luaXQoc3RydWN0IGRybV9kZXZpY2UgKmRl diwKPiAgCSAqIFNldCB1cCBJMkMgYnVzCj4gIAkgKiBGSVhNRTogZGlzdHJveSBpMmNfYnVzIHdo ZW4gZXhpdAo+ICAJICovCj4gLQlnbWFfZW5jb2Rlci0+aTJjX2J1cyA9IHBzYl9pbnRlbF9pMmNf Y3JlYXRlKGRldiwKPiAtCQkJCQkJCSBHUElPQiwKPiAtCQkJCQkJCSAiTFZEU0JMQ19CIik7Cj4g KwlnbWFfZW5jb2Rlci0+aTJjX2J1cyA9IHBzYl9pbnRlbF9pMmNfY3JlYXRlKGRldiwgR1BJT0Is CSJMVkRTQkxDX0IiKTsKPiArCQkJCQkJICAgIAo+ICAJaWYgKCFnbWFfZW5jb2Rlci0+aTJjX2J1 cykgewo+IC0JCWRldl9wcmludGsoS0VSTl9FUlIsCj4gLQkJCSZkZXYtPnBkZXYtPmRldiwgIkky QyBidXMgcmVnaXN0cmF0aW9uIGZhaWxlZC5cbiIpOwo+ICsJCWRldl9lcnIoJmRldi0+cGRldi0+ ZGV2LCAiSTJDIGJ1cyByZWdpc3RyYXRpb24gZmFpbGVkLlxuIik7Cj4gIAkJZ290byBmYWlsZWRf YmxjX2kyYzsKPiAgCX0KPiAgCWdtYV9lbmNvZGVyLT5pMmNfYnVzLT5zbGF2ZV9hZGRyID0gMHgy QzsKPiBAQCAtNzAzLDggKzcwMSw3IEBAIHZvaWQgY2R2X2ludGVsX2x2ZHNfaW5pdChzdHJ1Y3Qg ZHJtX2RldmljZSAqZGV2LAo+ICAJCQkJCQkJIEdQSU9DLAo+ICAJCQkJCQkJICJMVkRTRERDX0Mi KTsKPiAgCWlmICghZ21hX2VuY29kZXItPmRkY19idXMpIHsKPiAtCQlkZXZfcHJpbnRrKEtFUk5f RVJSLCAmZGV2LT5wZGV2LT5kZXYsCj4gLQkJCSAgICJEREMgYnVzIHJlZ2lzdHJhdGlvbiAiICJm YWlsZWQuXG4iKTsKPiArCQlkZXZfZXJyKCZkZXYtPnBkZXYtPmRldiwgIkREQyBidXMgcmVnaXN0 cmF0aW9uIGZhaWxlZC5cbiIpOwo+ICAJCWdvdG8gZmFpbGVkX2RkYzsKPiAgCX0KPiAgCj4gQEAg LTc3OSwxNSArNzc2LDE1IEBAIG91dDoKPiAgCj4gIGZhaWxlZF9maW5kOgo+ICAJbXV0ZXhfdW5s b2NrKCZkZXYtPm1vZGVfY29uZmlnLm11dGV4KTsKPiAtCXByaW50ayhLRVJOX0VSUiAiRmFpbGVk IGZpbmRcbiIpOwo+ICsJcHJfZXJyKCJGYWlsZWQgZmluZFxuIik7Cj4gIAlpZiAoZ21hX2VuY29k ZXItPmRkY19idXMpCj4gIAkJcHNiX2ludGVsX2kyY19kZXN0cm95KGdtYV9lbmNvZGVyLT5kZGNf YnVzKTsKPiAgZmFpbGVkX2RkYzoKPiAtCXByaW50ayhLRVJOX0VSUiAiRmFpbGVkIEREQ1xuIik7 Cj4gKwlwcl9lcnIoIkZhaWxlZCBERENcbiIpOwo+ICAJaWYgKGdtYV9lbmNvZGVyLT5pMmNfYnVz KQo+ICAJCXBzYl9pbnRlbF9pMmNfZGVzdHJveShnbWFfZW5jb2Rlci0+aTJjX2J1cyk7Cj4gIGZh aWxlZF9ibGNfaTJjOgo+IC0JcHJpbnRrKEtFUk5fRVJSICJGYWlsZWQgQkxDXG4iKTsKPiArCXBy X2VycigiRmFpbGVkIEJMQ1xuIik7Cj4gIAlkcm1fZW5jb2Rlcl9jbGVhbnVwKGVuY29kZXIpOwo+ ICAJZHJtX2Nvbm5lY3Rvcl9jbGVhbnVwKGNvbm5lY3Rvcik7Cj4gIAlrZnJlZShsdmRzX3ByaXYp Owo+IC0tIAo+IDIuOC4yCj4gCj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KPiBkcmktZGV2ZWwgbWFpbGluZyBsaXN0Cj4gZHJpLWRldmVsQGxpc3RzLmZy ZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz dGluZm8vZHJpLWRldmVsCgotLSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50 ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2 ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h aWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==