From: Muhammad Falak R Wani <falakreyaz@gmail.com>
To: "Christian König" <christian.koenig@amd.com>
Cc: David Airlie <airlied@linux.ie>,
Alex Deucher <alexander.deucher@amd.com>,
Chunming Zhou <David1.Zhou@amd.com>,
Jammy Zhou <Jammy.Zhou@amd.com>, Leo Liu <leo.liu@amd.com>,
Sonny Jiang <sonny.jiang@amd.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] amdgpu/uvd: use kmemdup
Date: Thu, 19 May 2016 17:19:21 +0530 [thread overview]
Message-ID: <20160519114921.GA14314@kp> (raw)
In-Reply-To: <573DA0F2.2020503@amd.com>
On Thu, May 19, 2016 at 01:18:10PM +0200, Christian König wrote:
> Am 19.05.2016 um 13:11 schrieb Muhammad Falak R Wani:
> >Use kmemdup when some other buffer is immediately copied into allocated
> >region. It replaces call to allocation followed by memcpy, by a single
> >call to kmemdup.
> >
> >Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
>
> NAK, actually using memcpy() is wrong in the first place.
>
> The UVD BO is in VRAM so the pointer is pointing to IO memory here,
> so this should be memcpy_fromio() instead of memcpy().
>
> Christian.
>
Should I send V2 with the required changes, and I had a query,
If memcpy was wrong, did it still work or it just got un-noticed ?
next prev parent reply other threads:[~2016-05-19 11:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-19 11:11 [PATCH] amdgpu/uvd: use kmemdup Muhammad Falak R Wani
2016-05-19 11:18 ` Christian König
2016-05-19 11:49 ` Muhammad Falak R Wani [this message]
2016-05-19 12:08 ` Christian König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160519114921.GA14314@kp \
--to=falakreyaz@gmail.com \
--cc=David1.Zhou@amd.com \
--cc=Jammy.Zhou@amd.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=leo.liu@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sonny.jiang@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).