From mboxrd@z Thu Jan  1 00:00:00 1970
From: Muhammad Falak R Wani <falakreyaz@gmail.com>
Subject: Re: [PATCH] amdgpu/uvd: use kmemdup
Date: Thu, 19 May 2016 17:19:21 +0530
Message-ID: <20160519114921.GA14314@kp>
References: <1463656317-13828-1-git-send-email-falakreyaz@gmail.com>
 <573DA0F2.2020503@amd.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: QUOTED-PRINTABLE
Return-path: <linux-kernel-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <573DA0F2.2020503@amd.com>
Sender: linux-kernel-owner@vger.kernel.org
To: Christian =?iso-8859-1?Q?K=F6nig?= <christian.koenig@amd.com>
Cc: David Airlie <airlied@linux.ie>, Alex Deucher <alexander.deucher@amd.com>, Chunming Zhou <David1.Zhou@amd.com>, Jammy Zhou <Jammy.Zhou@amd.com>, Leo Liu <leo.liu@amd.com>, Sonny Jiang <sonny.jiang@amd.com>, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
List-Id: dri-devel@lists.freedesktop.org

On Thu, May 19, 2016 at 01:18:10PM +0200, Christian K=F6nig wrote:
> Am 19.05.2016 um 13:11 schrieb Muhammad Falak R Wani:
> >Use kmemdup when some other buffer is immediately copied into alloca=
ted
> >region. It replaces call to allocation followed by memcpy, by a sing=
le
> >call to kmemdup.
> >
> >Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
>=20
> NAK, actually using memcpy() is wrong in the first place.
>=20
> The UVD BO is in VRAM so the pointer is pointing to IO memory here,
> so this should be memcpy_fromio() instead of memcpy().
>=20
> Christian.
>=20
Should I send V2 with the required changes, and I had a query,=20
If memcpy was wrong, did it still work or it just got un-noticed ?