From: Daniel Vetter <daniel@ffwll.ch>
To: Emil Velikov <emil.l.velikov@gmail.com>
Cc: peter.ujfalusi@ti.com,
ML dri-devel <dri-devel@lists.freedesktop.org>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Jyri Sarha <jsarha@ti.com>
Subject: Re: [PATCH v4 4/7] drm: Add drm_crtc_enable_color_mgmt()
Date: Thu, 26 May 2016 10:07:03 +0200 [thread overview]
Message-ID: <20160526080703.GQ27098@phenom.ffwll.local> (raw)
In-Reply-To: <CACvgo53B0nAMo1WiHqQ1EjE89iz3DbknOar=J7wzPNVcPJnt6w@mail.gmail.com>
On Wed, May 25, 2016 at 10:19:50PM +0100, Emil Velikov wrote:
> On 25 May 2016 at 22:05, Emil Velikov <emil.l.velikov@gmail.com> wrote:
> > On 25 May 2016 at 21:43, Jyri Sarha <jsarha@ti.com> wrote:
> >> Add drm_crtc_enable_color_mgmt() to. The new function makes the old
> >> drm_helper_crtc_enable_color_mgmt() obsolete. The new function is more
> >> flexible. It allows driver to enable only the feature it has without
> >> forcing to enable all three color management features: gegamma lut, csc
> >> matrix (ctm), and gamma lut.
> >>
> > Why don't we just update the existing one ? In one step (patch) or two
> > - a) don't register property if respective _lut_size is zero b) bring
> > in has_ctm.
> >
> Ouch I missed that the goal here is to move the function out of
> drm_crtc_helper.c. Sorry about that.
The goal still was to move it, and update the existing callers. Adding a
new without removing the old one is not what I suggested really ;-)
-Daniel
>
> Perhaps the commit message can be reworded a bit - something like the
> following comes to mind.
>
> "Introduce drm_crtc_enable_color_mgmt() function which supersedes the
> crtc_helper one (xxx: add name). The latter always creates all
> properties (xxx: list props) and is not really a helper.
> The new version allows explicit control of the properties created as
> required by some hardware/drivers (xxx: name driver)."
>
> Feel free to reuse and/tweak.
>
> Thanks
> Emil
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-05-26 8:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-25 20:43 [PATCH v4 0/7] drm/omapdrm: gamma table support + drm_crtc_enable_color_mgmt() Jyri Sarha
2016-05-25 20:43 ` [PATCH v4 1/7] drm/omapdrm: Add gamma table support to DSS dispc Jyri Sarha
2016-05-25 20:43 ` [PATCH v4 2/7] drm/omapdrm: Workaround for errata i734 (LCD1 Gamma) in " Jyri Sarha
2016-05-25 20:43 ` [PATCH v4 3/7] drm/omapdrm: Implement gamma_lut atomic crtc properties Jyri Sarha
2016-05-25 20:43 ` [PATCH v4 4/7] drm: Add drm_crtc_enable_color_mgmt() Jyri Sarha
2016-05-25 21:05 ` Emil Velikov
2016-05-25 21:19 ` Emil Velikov
2016-05-26 8:07 ` Daniel Vetter [this message]
2016-05-25 20:43 ` [PATCH v4 5/7] drm/omapdrm: Use drm_crtc_enable_color_mgmt() to enable gamma properties Jyri Sarha
2016-05-26 6:33 ` Tomi Valkeinen
2016-05-25 20:43 ` [PATCH v4 6/7] drm/i915: Use drm_crtc_enable_color_mgmt() Jyri Sarha
2016-05-25 20:43 ` [PATCH v4 7/7] drm: Remove obsolete drm_helper_crtc_enable_color_mgmt() Jyri Sarha
2016-05-26 8:08 ` Daniel Vetter
2016-05-26 8:15 ` Jyri Sarha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160526080703.GQ27098@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=emil.l.velikov@gmail.com \
--cc=jsarha@ti.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=peter.ujfalusi@ti.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox