From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: fsl-dcu not works on latest "drm-next" Date: Fri, 27 May 2016 20:50:48 +0100 Message-ID: <20160527195048.GA29837@sirena.org.uk> References: <20160525104103.GV8206@sirena.org.uk> <2397536.bIp6BuhYPD@ws-stein> <20160527122010.GH16172@sirena.org.uk> <40626c17a4e8960d20bfa07c59892bfa@agner.ch> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Nq2Wo0NMKNjxTN9z" Return-path: Content-Disposition: inline In-Reply-To: <40626c17a4e8960d20bfa07c59892bfa@agner.ch> Sender: linux-kernel-owner@vger.kernel.org To: Stefan Agner Cc: Alexander Stein , linux-kernel@vger.kernel.org, Meng Yi , dri-devel@lists.freedesktop.org, David Airlie , airlied@redhat.com List-Id: dri-devel@lists.freedesktop.org --Nq2Wo0NMKNjxTN9z Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, May 27, 2016 at 10:36:21AM -0700, Stefan Agner wrote: > On 2016-05-27 05:20, Mark Brown wrote: > > That's another way of addressing it of course, but unless the register > > map actually is sparse it's probably still sensible to send the > > conversion to flat cache as a fix. > The regcache is used for suspend, but the suspend implementation in its > current form is not in not working. Hence I felt it is not worth fixing > part of something which is broken as a whole anyway. > So far I was under the impression the "only" issue using REGCACHE_RBTREE > is that it triggers a warning when enabling lockdep.=20 The warning is warning about a real issue that might crop up - it's not just cosmetic, it's doing allocations inside a spinlock which could break badly. Even if it doesn't help this issue I'd recommend getting a fix in if you can to avoid it blowing up on people (unless the more complete set of changes can go in as a bugfix of course in which case it's moot). --Nq2Wo0NMKNjxTN9z Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXSKUWAAoJECTWi3JdVIfQ+KEH/2jJoR8VArD7FRcfIRbzzz83 jeT0Kh64xbB4I1N+6ltNrfJJmfstEFUpoKgsI5dnLpb2VlAU7EDZ+/u97s3J2qUH OeBBoNhXVG4ey5laSvF/W5+ozo+k7cwpFcxhtS8lXSOAnVgxj2saSd2jqQuOqbQI NtdUJBkHmDoQmcdRfWjVMlaZ/DgjGnzFrxLFJQgKaCrbob5ft8Xt+T341n9w0rKV gDv9atkcAI5fGDL+DeUZqbLr4/oqK2d39r5BbNRp4H201sy5zNVI9rU17G/hsST3 w3vmr3UhI9YMz728xoHl/4jXYh1RFX+P3Ql4ciDj7rl4ERSmcCns9fMmuvPuxGY= =jXIc -----END PGP SIGNATURE----- --Nq2Wo0NMKNjxTN9z--