dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: tomi.valkeinen@ti.com, plagnioj@jcrosoft.com,
	robdclark@gmail.com, airlied@linux.ie, tony@atomide.com
Cc: linux-fbdev@vger.kernel.org, linux-omap@vger.kernel.org,
	linux-kernel@vger.kernel.org, laurent.pinchart@ideasonboard.com,
	jsarha@ti.com, dri-devel@lists.freedesktop.org
Subject: [PATCH v2 05/27] omapfb: panel-lgphilips-lb035q02: Remove legacy boot support
Date: Wed, 1 Jun 2016 11:35:27 +0300	[thread overview]
Message-ID: <20160601083549.10549-6-peter.ujfalusi@ti.com> (raw)
In-Reply-To: <20160601083549.10549-1-peter.ujfalusi@ti.com>

The panel is not used by any legacy board files so the legacy (pdata) boot
support can be dropped.

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
 .../omapfb/displays/panel-lgphilips-lb035q02.c     | 56 +++-------------------
 include/video/omap-panel-data.h                    | 18 -------
 2 files changed, 6 insertions(+), 68 deletions(-)

diff --git a/drivers/video/fbdev/omap2/omapfb/displays/panel-lgphilips-lb035q02.c b/drivers/video/fbdev/omap2/omapfb/displays/panel-lgphilips-lb035q02.c
index 18eb60e9c9ec..6d5207c7b22c 100644
--- a/drivers/video/fbdev/omap2/omapfb/displays/panel-lgphilips-lb035q02.c
+++ b/drivers/video/fbdev/omap2/omapfb/displays/panel-lgphilips-lb035q02.c
@@ -17,7 +17,6 @@
 #include <linux/gpio.h>
 
 #include <video/omapdss.h>
-#include <video/omap-panel-data.h>
 
 static struct omap_video_timings lb035q02_timings = {
 	.x_res = 320,
@@ -240,44 +239,6 @@ static struct omap_dss_driver lb035q02_ops = {
 	.get_resolution	= omapdss_default_get_resolution,
 };
 
-static int lb035q02_probe_pdata(struct spi_device *spi)
-{
-	const struct panel_lb035q02_platform_data *pdata;
-	struct panel_drv_data *ddata = dev_get_drvdata(&spi->dev);
-	struct omap_dss_device *dssdev, *in;
-	int r;
-
-	pdata = dev_get_platdata(&spi->dev);
-
-	in = omap_dss_find_output(pdata->source);
-	if (in == NULL) {
-		dev_err(&spi->dev, "failed to find video source '%s'\n",
-				pdata->source);
-		return -EPROBE_DEFER;
-	}
-
-	ddata->in = in;
-
-	ddata->data_lines = pdata->data_lines;
-
-	dssdev = &ddata->dssdev;
-	dssdev->name = pdata->name;
-
-	r = devm_gpio_request_one(&spi->dev, pdata->enable_gpio,
-					GPIOF_OUT_INIT_LOW, "panel enable");
-	if (r)
-		goto err_gpio;
-
-	ddata->enable_gpio = gpio_to_desc(pdata->enable_gpio);
-
-	ddata->backlight_gpio = pdata->backlight_gpio;
-
-	return 0;
-err_gpio:
-	omap_dss_put_device(ddata->in);
-	return r;
-}
-
 static int lb035q02_probe_of(struct spi_device *spi)
 {
 	struct device_node *node = spi->dev.of_node;
@@ -312,6 +273,9 @@ static int lb035q02_panel_spi_probe(struct spi_device *spi)
 	struct omap_dss_device *dssdev;
 	int r;
 
+	if (!spi->dev.of_node)
+		return -ENODEV;
+
 	ddata = devm_kzalloc(&spi->dev, sizeof(*ddata), GFP_KERNEL);
 	if (ddata == NULL)
 		return -ENOMEM;
@@ -320,17 +284,9 @@ static int lb035q02_panel_spi_probe(struct spi_device *spi)
 
 	ddata->spi = spi;
 
-	if (dev_get_platdata(&spi->dev)) {
-		r = lb035q02_probe_pdata(spi);
-		if (r)
-			return r;
-	} else if (spi->dev.of_node) {
-		r = lb035q02_probe_of(spi);
-		if (r)
-			return r;
-	} else {
-		return -ENODEV;
-	}
+	r = lb035q02_probe_of(spi);
+	if (r)
+		return r;
 
 	if (gpio_is_valid(ddata->backlight_gpio)) {
 		r = devm_gpio_request_one(&spi->dev, ddata->backlight_gpio,
diff --git a/include/video/omap-panel-data.h b/include/video/omap-panel-data.h
index 085b4171eb25..74486bcc754e 100644
--- a/include/video/omap-panel-data.h
+++ b/include/video/omap-panel-data.h
@@ -147,22 +147,4 @@ struct panel_acx565akm_platform_data {
 	int datapairs;
 };
 
-/**
- * panel_lb035q02 platform data
- * @name: name for this display entity
- * @source: name of the display entity used as a video source
- * @data_lines: number of DPI datalines
- * @backlight_gpio: gpio to enable/disable the backlight (or -1)
- * @enable_gpio: gpio to enable/disable the panel (or -1)
- */
-struct panel_lb035q02_platform_data {
-	const char *name;
-	const char *source;
-
-	int data_lines;
-
-	int backlight_gpio;
-	int enable_gpio;
-};
-
 #endif /* __OMAP_PANEL_DATA_H */
-- 
2.8.3

  parent reply	other threads:[~2016-06-01  8:35 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-01  8:35 [PATCH v2 00/27] fb/drm: omapdss: Clean up the headers and separate the two stack Peter Ujfalusi
2016-06-01  8:35 ` [PATCH v2 01/27] omapfb: panel-tpo-td028ttec1: Remove legacy boot support Peter Ujfalusi
2016-06-01  8:35 ` [PATCH v2 02/27] omapfb: panel-nec-nl8048hl11: " Peter Ujfalusi
2016-06-01  8:35 ` [PATCH v2 03/27] omapfb: panel-tpo-td043mtea1: " Peter Ujfalusi
2016-06-01  8:35 ` [PATCH v2 04/27] omapfb: panel-sharp-ls037v7dw01: " Peter Ujfalusi
2016-06-01  8:35 ` Peter Ujfalusi [this message]
2016-06-01  8:35 ` [PATCH v2 06/27] omapfb: panel-dsi-cm: " Peter Ujfalusi
2016-06-01  8:35 ` [PATCH v2 07/27] omapfb: connector-hdmi: " Peter Ujfalusi
2016-06-01  8:35 ` [PATCH v2 08/27] omapfb: connector-dvi: " Peter Ujfalusi
2016-06-01  8:35 ` [PATCH v2 09/27] omapfb: encoder-tfp410: " Peter Ujfalusi
2016-06-01  8:35 ` [PATCH v2 10/27] omapfb: encoder-tpd12s015: No need to include video/omap-panle-data.h Peter Ujfalusi
2016-06-01  8:35 ` [PATCH v2 11/27] drm/omap: displays: Do not include video/omap-panel-data.h if not needed Peter Ujfalusi
2016-06-01  8:35 ` [PATCH v2 12/27] omapdss: omap-panel-data.h: Remove struct omap_dss_device declaration Peter Ujfalusi
2016-06-01  8:35 ` [PATCH v2 13/27] drm/omap: connector-analog-tv: Support only Composite type in legacy boot Peter Ujfalusi
2016-06-01  8:35 ` [PATCH v2 14/27] omapfb: " Peter Ujfalusi
2016-06-01  8:35 ` [PATCH v2 15/27] ARM: OMAP: rx51-video: Do not set TV connector_type Peter Ujfalusi
2016-06-01  8:35 ` [PATCH v2 16/27] omapdss: omap-panel-data.h: Remove connector_type from atv pdata Peter Ujfalusi
2016-06-01  8:35 ` [PATCH v2 17/27] ARM/video: omap2: Move omap_display_init declaration to mach-omap2/display.h Peter Ujfalusi
2016-06-01  8:35 ` [PATCH v2 18/27] drm/omap: Remove reference to pdata->default_device Peter Ujfalusi
2016-06-01  8:35 ` [PATCH v2 19/27] omapfb: " Peter Ujfalusi
2016-06-01  8:35 ` [PATCH v2 20/27] video: omapdss: Remove unused members from struct omap_dss_board_info Peter Ujfalusi
2016-06-01  8:35 ` [PATCH v2 21/27] video/platform_data: omapdss: Create new header file for platform data Peter Ujfalusi
2016-06-01  8:35 ` [PATCH v2 22/27] ARM: OMAP2: Use the platform_data header for omapdss Peter Ujfalusi
2016-06-01  8:35 ` [PATCH v2 23/27] omapdss: hdmi audio: Make header file independent of video/omapdss.h Peter Ujfalusi
2016-06-01  8:35 ` [PATCH v2 24/27] drm/omap: Do not include video/omapdss.h directly in drivers Peter Ujfalusi
2016-06-01  8:35 ` [PATCH v2 25/27] omapfb: Create new header file for omapfb DSS implementation Peter Ujfalusi
2016-06-01  8:35 ` [PATCH v2 26/27] [media] omap_vout: Switch to use the video/omapfb_dss.h header file Peter Ujfalusi
2016-06-01  8:35 ` [PATCH v2 27/27] drm/omap: Remove the video/omapdss.h and move it's content to local " Peter Ujfalusi
2016-06-02 12:26 ` [PATCH v2 00/27] fb/drm: omapdss: Clean up the headers and separate the two stack Tomi Valkeinen
2016-06-02 15:23   ` Tony Lindgren
2016-06-03 10:51     ` Tomi Valkeinen
2016-06-07  5:51       ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160601083549.10549-6-peter.ujfalusi@ti.com \
    --to=peter.ujfalusi@ti.com \
    --cc=airlied@linux.ie \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jsarha@ti.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=plagnioj@jcrosoft.com \
    --cc=robdclark@gmail.com \
    --cc=tomi.valkeinen@ti.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox