From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v4] drm: Only create a cmdline mode if no probed modes match Date: Thu, 2 Jun 2016 15:12:26 +0200 Message-ID: <20160602131226.GF7231@phenom.ffwll.local> References: <20160601094353.GC4329@intel.com> <1464774651-20376-1-git-send-email-chris@chris-wilson.co.uk> <574FFE92.6060806@radekdostal.com> <20160602105217.GL10319@nuc-i3427.alporthouse.com> <20160602113040.GK4329@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <20160602113040.GK4329@intel.com> Sender: stable-owner@vger.kernel.org To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Cc: Chris Wilson , Radek =?iso-8859-1?Q?Dost=E1l?= , dri-devel@lists.freedesktop.org, Jesse Barnes , Daniel Vetter , Julia Lemire , Dave Airlie , stable@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org On Thu, Jun 02, 2016 at 02:30:40PM +0300, Ville Syrj=E4l=E4 wrote: > On Thu, Jun 02, 2016 at 11:52:17AM +0100, Chris Wilson wrote: > > On Thu, Jun 02, 2016 at 11:38:26AM +0200, Radek Dost=E1l wrote: > > > On 06/01/2016 11:50 AM, Chris Wilson wrote: > > > >Fixes regression from > > > > > > > >commit eaf99c749d43ae74ac7ffece5512f3c73f01dfd2 > > > >Author: Chris Wilson > > > >Date: Wed Aug 6 10:08:32 2014 +0200 > > > > > > > > drm: Perform cmdline mode parsing during connector initiali= sation > > > > > > > >that breaks HDMI output on BeagleBone Black with LG TV (model 19= LS4R-ZA). > > >=20 > > > please remove this from the commit message. The original bug is n= o > > > longer reproducible with 4.7-rc1 > >=20 > > If there's no motivation for the patch anymore, it can just wither = away > > in one of my old trees. > >=20 > > Does anyone care about pruning the autogenerated video=3D mode if a= probed > > one matches? Presumably, it is still visible to userspace and switc= hing > > to it will cause the same issue as before? Or was it always a drive= r > > bug (failing to set the mode)? >=20 > IMO the patch makes total sense even if it's not needed for this > particular bug. Feel free to add >=20 > Reviewed-by: Ville Syrj=E4l=E4 Agreed. I dropped the cc: stable and adjusted the commit message to explain the situation. Merged to drm-misc, thanks. -Daniel --=20 Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch