From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v2 2/2] drm/crtc: only store the necessary data for set_config rollback Date: Thu, 2 Jun 2016 22:26:50 +0200 Message-ID: <20160602202650.GT7231@phenom.ffwll.local> References: <1464888472-21581-1-git-send-email-p.zabel@pengutronix.de> <1464888472-21581-2-git-send-email-p.zabel@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x243.google.com (mail-wm0-x243.google.com [IPv6:2a00:1450:400c:c09::243]) by gabe.freedesktop.org (Postfix) with ESMTPS id E7C8B6EC46 for ; Thu, 2 Jun 2016 20:26:54 +0000 (UTC) Received: by mail-wm0-x243.google.com with SMTP id a20so7161639wma.3 for ; Thu, 02 Jun 2016 13:26:54 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1464888472-21581-2-git-send-email-p.zabel@pengutronix.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Philipp Zabel Cc: Daniel Vetter , kernel@pengutronix.de, Daniel Stone , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBKdW4gMDIsIDIwMTYgYXQgMDc6Mjc6NTJQTSArMDIwMCwgUGhpbGlwcCBaYWJlbCB3 cm90ZToKPiBkcm1fY3J0Y19oZWxwZXJfc2V0X2NvbmZpZyBvbmx5IHBvdGVudGlhbGx5IHRvdWNo ZXMgY29ubmVjdG9yLT5lbmNvZGVyCj4gYW5kIGVuY29kZXItPmNydGMsIHNvIHdlIG9ubHkgaGF2 ZSB0byBzdG9yZSB0aG9zZSBmb3IgYWxsIGNvbm5lY3RvcnMKPiBhbmQgZW5jb2RlcnMsIHJlc3Bl Y3RpdmVseS4KPiAKPiBTdWdnZXN0ZWQtYnk6IERhbmllbCBWZXR0ZXIgPGRhbmllbEBmZndsbC5j aD4KPiBTaWduZWQtb2ZmLWJ5OiBQaGlsaXBwIFphYmVsIDxwLnphYmVsQHBlbmd1dHJvbml4LmRl PgoKUmV2aWV3ZWQtYnk6IERhbmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJAZmZ3bGwuY2g+Cgo+ IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vZHJtX2NydGNfaGVscGVyLmMgfCAzNiArKysrKysrKysr KysrKysrKystLS0tLS0tLS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDE4IGluc2VydGlv bnMoKyksIDE4IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0v ZHJtX2NydGNfaGVscGVyLmMgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2NydGNfaGVscGVyLmMKPiBp bmRleCAxYzRkNjc0Li4yNmZlYjJmIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1f Y3J0Y19oZWxwZXIuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fY3J0Y19oZWxwZXIuYwo+ IEBAIC01MjgsMTEgKzUyOCwxMSBAQCBkcm1fY3J0Y19oZWxwZXJfZGlzYWJsZShzdHJ1Y3QgZHJt X2NydGMgKmNydGMpCj4gIGludCBkcm1fY3J0Y19oZWxwZXJfc2V0X2NvbmZpZyhzdHJ1Y3QgZHJt X21vZGVfc2V0ICpzZXQpCj4gIHsKPiAgCXN0cnVjdCBkcm1fZGV2aWNlICpkZXY7Cj4gLQlzdHJ1 Y3QgZHJtX2NydGMgKm5ld19jcnRjOwo+IC0Jc3RydWN0IGRybV9lbmNvZGVyICpzYXZlX2VuY29k ZXJzLCAqbmV3X2VuY29kZXIsICplbmNvZGVyOwo+ICsJc3RydWN0IGRybV9jcnRjICoqc2F2ZV9l bmNvZGVyX2NydGNzLCAqbmV3X2NydGM7Cj4gKwlzdHJ1Y3QgZHJtX2VuY29kZXIgKipzYXZlX2Nv bm5lY3Rvcl9lbmNvZGVycywgKm5ld19lbmNvZGVyLCAqZW5jb2RlcjsKPiAgCWJvb2wgbW9kZV9j aGFuZ2VkID0gZmFsc2U7IC8qIGlmIHRydWUgZG8gYSBmdWxsIG1vZGUgc2V0ICovCj4gIAlib29s IGZiX2NoYW5nZWQgPSBmYWxzZTsgLyogaWYgdHJ1ZSBhbmQgIW1vZGVfY2hhbmdlZCBqdXN0IGRv IGEgZmxpcCAqLwo+IC0Jc3RydWN0IGRybV9jb25uZWN0b3IgKnNhdmVfY29ubmVjdG9ycywgKmNv bm5lY3RvcjsKPiArCXN0cnVjdCBkcm1fY29ubmVjdG9yICpjb25uZWN0b3I7Cj4gIAlpbnQgY291 bnQgPSAwLCBybywgZmFpbCA9IDA7Cj4gIAljb25zdCBzdHJ1Y3QgZHJtX2NydGNfaGVscGVyX2Z1 bmNzICpjcnRjX2Z1bmNzOwo+ICAJc3RydWN0IGRybV9tb2RlX3NldCBzYXZlX3NldDsKPiBAQCAt NTc0LDE1ICs1NzQsMTUgQEAgaW50IGRybV9jcnRjX2hlbHBlcl9zZXRfY29uZmlnKHN0cnVjdCBk cm1fbW9kZV9zZXQgKnNldCkKPiAgCSAqIEFsbG9jYXRlIHNwYWNlIGZvciB0aGUgYmFja3VwIG9m IGFsbCAobm9uLXBvaW50ZXIpIGVuY29kZXIgYW5kCj4gIAkgKiBjb25uZWN0b3IgZGF0YS4KPiAg CSAqLwo+IC0Jc2F2ZV9lbmNvZGVycyA9IGt6YWxsb2MoZGV2LT5tb2RlX2NvbmZpZy5udW1fZW5j b2RlciAqCj4gLQkJCQlzaXplb2Yoc3RydWN0IGRybV9lbmNvZGVyKSwgR0ZQX0tFUk5FTCk7Cj4g LQlpZiAoIXNhdmVfZW5jb2RlcnMpCj4gKwlzYXZlX2VuY29kZXJfY3J0Y3MgPSBremFsbG9jKGRl di0+bW9kZV9jb25maWcubnVtX2VuY29kZXIgKgo+ICsJCQkJc2l6ZW9mKHN0cnVjdCBkcm1fY3J0 YyAqKSwgR0ZQX0tFUk5FTCk7Cj4gKwlpZiAoIXNhdmVfZW5jb2Rlcl9jcnRjcykKPiAgCQlyZXR1 cm4gLUVOT01FTTsKPiAgCj4gLQlzYXZlX2Nvbm5lY3RvcnMgPSBremFsbG9jKGRldi0+bW9kZV9j b25maWcubnVtX2Nvbm5lY3RvciAqCj4gLQkJCQlzaXplb2Yoc3RydWN0IGRybV9jb25uZWN0b3Ip LCBHRlBfS0VSTkVMKTsKPiAtCWlmICghc2F2ZV9jb25uZWN0b3JzKSB7Cj4gLQkJa2ZyZWUoc2F2 ZV9lbmNvZGVycyk7Cj4gKwlzYXZlX2Nvbm5lY3Rvcl9lbmNvZGVycyA9IGt6YWxsb2MoZGV2LT5t b2RlX2NvbmZpZy5udW1fY29ubmVjdG9yICoKPiArCQkJCXNpemVvZihzdHJ1Y3QgZHJtX2VuY29k ZXIgKiksIEdGUF9LRVJORUwpOwo+ICsJaWYgKCFzYXZlX2Nvbm5lY3Rvcl9lbmNvZGVycykgewo+ ICsJCWtmcmVlKHNhdmVfZW5jb2Rlcl9jcnRjcyk7Cj4gIAkJcmV0dXJuIC1FTk9NRU07Cj4gIAl9 Cj4gIAo+IEBAIC01OTMsMTIgKzU5MywxMiBAQCBpbnQgZHJtX2NydGNfaGVscGVyX3NldF9jb25m aWcoc3RydWN0IGRybV9tb2RlX3NldCAqc2V0KQo+ICAJICovCj4gIAljb3VudCA9IDA7Cj4gIAlk cm1fZm9yX2VhY2hfZW5jb2RlcihlbmNvZGVyLCBkZXYpIHsKPiAtCQlzYXZlX2VuY29kZXJzW2Nv dW50KytdID0gKmVuY29kZXI7Cj4gKwkJc2F2ZV9lbmNvZGVyX2NydGNzW2NvdW50KytdID0gZW5j b2Rlci0+Y3J0YzsKPiAgCX0KPiAgCj4gIAljb3VudCA9IDA7Cj4gIAlkcm1fZm9yX2VhY2hfY29u bmVjdG9yKGNvbm5lY3RvciwgZGV2KSB7Cj4gLQkJc2F2ZV9jb25uZWN0b3JzW2NvdW50KytdID0g KmNvbm5lY3RvcjsKPiArCQlzYXZlX2Nvbm5lY3Rvcl9lbmNvZGVyc1tjb3VudCsrXSA9IGNvbm5l Y3Rvci0+ZW5jb2RlcjsKPiAgCX0KPiAgCj4gIAlzYXZlX3NldC5jcnRjID0gc2V0LT5jcnRjOwo+ IEBAIC03NTgsMjAgKzc1OCwyMCBAQCBpbnQgZHJtX2NydGNfaGVscGVyX3NldF9jb25maWcoc3Ry dWN0IGRybV9tb2RlX3NldCAqc2V0KQo+ICAJCX0KPiAgCX0KPiAgCj4gLQlrZnJlZShzYXZlX2Nv bm5lY3RvcnMpOwo+IC0Ja2ZyZWUoc2F2ZV9lbmNvZGVycyk7Cj4gKwlrZnJlZShzYXZlX2Nvbm5l Y3Rvcl9lbmNvZGVycyk7Cj4gKwlrZnJlZShzYXZlX2VuY29kZXJfY3J0Y3MpOwo+ICAJcmV0dXJu IDA7Cj4gIAo+ICBmYWlsOgo+ICAJLyogUmVzdG9yZSBhbGwgcHJldmlvdXMgZGF0YS4gKi8KPiAg CWNvdW50ID0gMDsKPiAgCWRybV9mb3JfZWFjaF9lbmNvZGVyKGVuY29kZXIsIGRldikgewo+IC0J CSplbmNvZGVyID0gc2F2ZV9lbmNvZGVyc1tjb3VudCsrXTsKPiArCQllbmNvZGVyLT5jcnRjID0g c2F2ZV9lbmNvZGVyX2NydGNzW2NvdW50KytdOwo+ICAJfQo+ICAKPiAgCWNvdW50ID0gMDsKPiAg CWRybV9mb3JfZWFjaF9jb25uZWN0b3IoY29ubmVjdG9yLCBkZXYpIHsKPiAtCQkqY29ubmVjdG9y ID0gc2F2ZV9jb25uZWN0b3JzW2NvdW50KytdOwo+ICsJCWNvbm5lY3Rvci0+ZW5jb2RlciA9IHNh dmVfY29ubmVjdG9yX2VuY29kZXJzW2NvdW50KytdOwo+ICAJfQo+ICAKPiAgCS8qIGFmdGVyIGZh aWwgZHJvcCByZWZlcmVuY2Ugb24gYWxsIHVuYm91bmQgY29ubmVjdG9ycyBpbiBzZXQsIGxldAo+ IEBAIC03ODksOCArNzg5LDggQEAgZmFpbDoKPiAgCQkJCSAgICAgIHNhdmVfc2V0LnksIHNhdmVf c2V0LmZiKSkKPiAgCQlEUk1fRVJST1IoImZhaWxlZCB0byByZXN0b3JlIGNvbmZpZyBhZnRlciBt b2Rlc2V0IGZhaWx1cmVcbiIpOwo+ICAKPiAtCWtmcmVlKHNhdmVfY29ubmVjdG9ycyk7Cj4gLQlr ZnJlZShzYXZlX2VuY29kZXJzKTsKPiArCWtmcmVlKHNhdmVfY29ubmVjdG9yX2VuY29kZXJzKTsK PiArCWtmcmVlKHNhdmVfZW5jb2Rlcl9jcnRjcyk7Cj4gIAlyZXR1cm4gcmV0Owo+ICB9Cj4gIEVY UE9SVF9TWU1CT0woZHJtX2NydGNfaGVscGVyX3NldF9jb25maWcpOwo+IC0tIAo+IDIuOC4xCj4g CgotLSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24K aHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRl c2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v ZHJpLWRldmVsCg==