dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Russell King - ARM Linux <linux@armlinux.org.uk>
To: Liviu Dudau <liviu.dudau@arm.com>
Cc: David Airlie <airlied@linux.ie>, Rob Clark <robdclark@gmail.com>,
	Mark Yao <mark.yao@rock-chips.com>,
	Heiko Stuebner <heiko@sntech.de>,
	Benjamin Gaignard <benjamin.gaignard@linaro.org>,
	Vincent Abriou <vincent.abriou@st.com>,
	dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org,
	freedreno@lists.freedesktop.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org
Subject: Re: [PATCH] drm: convert DT component matching to component_match_add_release()
Date: Fri, 3 Jun 2016 11:36:33 +0100	[thread overview]
Message-ID: <20160603103633.GA1041@n2100.armlinux.org.uk> (raw)
In-Reply-To: <20160603094048.GI23566@e106497-lin.cambridge.arm.com>

On Fri, Jun 03, 2016 at 10:40:48AM +0100, Liviu Dudau wrote:
> On Fri, Jun 03, 2016 at 08:58:10AM +0100, Russell King wrote:
> > Convert DT component matching to use component_match_add_release().
> 
> Hi Russell,
> 
> Any reason for not keeping the component_match_add() calls in the drivers?

Sorry, I don't understand your comment.

If we kept component_match_add() in these drivers, then this patch
would not exist, because there wouldn't be any changes to the drivers.

> Planning to remove it?

Possibly in the longer term, but at the moment there are drivers where
the match data that is passed does not need any release functionality
eg, data allocated with devm_k*alloc(), or

	component_match_add(dev->parent, match, dss_component_compare, dev);

There are some new cases that need converting which have cropped up
during the last merge window, and I expect this to be an on-going
educational point for driver authors, so I'm not too bothered about
capturing all existing cases in this patch.

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.

  reply	other threads:[~2016-06-03 10:36 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-03  7:58 [PATCH] drm: convert DT component matching to component_match_add_release() Russell King
2016-06-03  9:40 ` Liviu Dudau
2016-06-03 10:36   ` Russell King - ARM Linux [this message]
2016-06-03 11:19     ` Liviu Dudau
2016-06-03 11:48       ` Russell King - ARM Linux
2016-06-03 10:56 ` Robin Murphy
2016-06-03 14:15   ` Russell King - ARM Linux
2016-06-03 14:21     ` [PATCH v2 1/3] of: add common OF-based component functionality Russell King
     [not found]       ` <E1b8pyR-0005OJ-V3-eh5Bv4kxaXIk46pC+1QYvQNdhmdF6hFW@public.gmane.org>
2016-06-03 15:29         ` Rob Herring
2016-06-03 15:36           ` Russell King - ARM Linux
2016-06-03 19:52             ` Rob Herring
2016-06-03 15:44         ` Thierry Reding
2016-06-03 16:11           ` Russell King - ARM Linux
2016-06-03 14:21     ` [PATCH v2 2/3] drm: convert DT component matching to component_match_add_release() Russell King
2016-06-03 15:10       ` Lucas Stach
     [not found]       ` <E1b8pyX-0005OP-2s-eh5Bv4kxaXIk46pC+1QYvQNdhmdF6hFW@public.gmane.org>
2016-06-07 13:39         ` Liviu Dudau
2016-06-07 14:26         ` Vincent ABRIOU
2016-06-03 14:21     ` [PATCH v2 3/3] iommu: " Russell King
2016-06-03 15:20       ` Matthias Brugger
2016-06-15 13:31       ` Joerg Roedel
  -- strict thread matches above, loose matches on Subject: below --
2016-10-19 10:28 [PATCH] drm: " Russell King
2016-10-20  6:36 ` Daniel Vetter
2016-10-20 20:39 ` Sean Paul
2016-10-20 21:50   ` Russell King - ARM Linux
2016-10-20 23:15     ` Sean Paul
     [not found]       ` <CAOw6vbJ64JOugR2b3R87pFRDGDVs9HM3uZJM2z1-jHyhPf6WOA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-10-21 15:23         ` Russell King - ARM Linux
2016-10-24 13:21 ` Jyri Sarha
2016-10-25 16:44 ` Sean Paul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160603103633.GA1041@n2100.armlinux.org.uk \
    --to=linux@armlinux.org.uk \
    --cc=airlied@linux.ie \
    --cc=benjamin.gaignard@linaro.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=heiko@sntech.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=liviu.dudau@arm.com \
    --cc=mark.yao@rock-chips.com \
    --cc=robdclark@gmail.com \
    --cc=vincent.abriou@st.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox