From: Thierry Reding <thierry.reding@gmail.com>
To: Philipp Zabel <p.zabel@pengutronix.de>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
dri-devel@lists.freedesktop.org
Subject: [PATCH] drm/mediatek: Do not select IOMMU_DMA
Date: Fri, 3 Jun 2016 17:31:48 +0200 [thread overview]
Message-ID: <20160603153148.20727-1-thierry.reding@gmail.com> (raw)
From: Thierry Reding <treding@nvidia.com>
The IOMMU_DMA symbol depends on IOMMU_API, but DRM_MEDIATEK itself does
not have a dependency on that symbol.
Furthermore the driver doesn't use any of the code enabled by IOMMU_DMA
and the only IOMMU API call that it uses, iommu_present(), has a dummy
implementation if IOMMU_API isn't selected. Effectively there really is
no build time dependency on the IOMMU API.
Because of all of the above, the dependency on IOMMU_DMA or IOMMU_API
doesn't belong in the Mediatek DRM driver, but is really a matter of
platform integration. A default configuration should be enabling IOMMU
support if the driver should take advantage of it.
Note that the driver currently defers probe indefinitely if no IOMMU is
registered on the parent bus. There's really no reason for it to do that
since the driver exclusively uses the DMA API to allocate and map memory
and should therefore work even if no IOMMU is registered and for example
the contiguous memory allocator is enabled instead.
Signed-off-by: Thierry Reding <treding@nvidia.com>
---
drivers/gpu/drm/mediatek/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/mediatek/Kconfig b/drivers/gpu/drm/mediatek/Kconfig
index eeefc971801a..9eefecedc3da 100644
--- a/drivers/gpu/drm/mediatek/Kconfig
+++ b/drivers/gpu/drm/mediatek/Kconfig
@@ -6,7 +6,6 @@ config DRM_MEDIATEK
select DRM_KMS_HELPER
select DRM_MIPI_DSI
select DRM_PANEL
- select IOMMU_DMA
select MEMORY
select MTK_SMI
help
--
2.8.3
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
reply other threads:[~2016-06-03 15:31 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160603153148.20727-1-thierry.reding@gmail.com \
--to=thierry.reding@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=matthias.bgg@gmail.com \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox