From: Daniel Vetter <daniel@ffwll.ch>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: dri-devel@lists.freedesktop.org, Jyri Sarha <jsarha@ti.com>,
laurent.pinchart@ideasonboard.com
Subject: Re: [PATCH v6 1/4] drm: drm_helper_crtc_enable_color_mgmt() => drm_crtc_enable_color_mgmt()
Date: Tue, 7 Jun 2016 21:42:34 +0200 [thread overview]
Message-ID: <20160607194234.GE3363@phenom.ffwll.local> (raw)
In-Reply-To: <5756FC4B.1050700@ti.com>
On Tue, Jun 07, 2016 at 07:54:35PM +0300, Tomi Valkeinen wrote:
> On 07/06/16 15:09, Jyri Sarha wrote:
> > Add drm_crtc_enable_color_mgmt(), remove drm_helper_crtc_enable_color_mgmt()
> > and update drm/i915-driver (the only user of the old function).
> >
> > The new function is more flexible. It allows driver to enable only the
> > features it has without forcing to enable all three color management
> > properties: degamma lut, csc matrix (ctm), and gamma lut.
> >
> > Suggested-by: Daniel Vetter <daniel@ffwll.ch>
> > Signed-off-by: Jyri Sarha <jsarha@ti.com>
> > ---
> > drivers/gpu/drm/drm_crtc.c | 45 ++++++++++++++++++++++++++++++++++++++
> > drivers/gpu/drm/drm_crtc_helper.c | 33 ----------------------------
> > drivers/gpu/drm/i915/intel_color.c | 3 ++-
> > include/drm/drm_crtc.h | 5 ++++-
> > include/drm/drm_crtc_helper.h | 3 ---
> > 5 files changed, 51 insertions(+), 38 deletions(-)
>
> Looks good to me. I can queue this up with the omapdrm patches in this
> series, if no one complains.
btw would be good if you send a pull for omapdrm in 1-2 weeks latest once
this is merged, to avoid unecessary conflicts and other hilarity.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-06-07 19:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-07 12:09 [PATCH v6 0/4] drm/omapdrm: gamma table support + drm_crtc_enable_color_mgmt() Jyri Sarha
2016-06-07 12:09 ` [PATCH v6 1/4] drm: drm_helper_crtc_enable_color_mgmt() => drm_crtc_enable_color_mgmt() Jyri Sarha
2016-06-07 16:54 ` Tomi Valkeinen
2016-06-07 19:42 ` Daniel Vetter [this message]
2016-06-07 12:09 ` [PATCH v6 2/4] drm/omapdrm: Add gamma table support to DSS dispc Jyri Sarha
2016-06-07 12:09 ` [PATCH v6 3/4] drm/omapdrm: Workaround for errata i734 (LCD1 Gamma) in " Jyri Sarha
2016-06-07 12:09 ` [PATCH v6 4/4] drm/omapdrm: Implement gamma_lut atomic crtc properties Jyri Sarha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160607194234.GE3363@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jsarha@ti.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox