From: Daniel Vetter <daniel@ffwll.ch>
To: Eric Engestrom <eric.engestrom@imgtec.com>
Cc: Dave Airlie <airlied@redhat.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/qxl: Remove useless drm_fb_get_bpp_depth() call
Date: Wed, 8 Jun 2016 09:37:46 +0200 [thread overview]
Message-ID: <20160608073746.GJ3363@phenom.ffwll.local> (raw)
In-Reply-To: <20160607165002.GB9217@imgtec.com>
On Tue, Jun 07, 2016 at 05:50:02PM +0100, Eric Engestrom wrote:
> On Mon, Jun 06, 2016 at 09:14:51PM +0300, Laurent Pinchart wrote:
> > The function has no side effect and its returned values are ignored,
> > don't call it.
> >
> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> Reviewed-by: Eric Engestrom <eric.engestrom@imgtec.com>
Both of Laurent's patches applied, thanks.
-Daniel
>
> > ---
> > drivers/gpu/drm/qxl/qxl_fb.c | 4 ----
> > 1 file changed, 4 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/qxl/qxl_fb.c b/drivers/gpu/drm/qxl/qxl_fb.c
> > index 5ea57f6320b8..df2657051afd 100644
> > --- a/drivers/gpu/drm/qxl/qxl_fb.c
> > +++ b/drivers/gpu/drm/qxl/qxl_fb.c
> > @@ -131,10 +131,6 @@ static int qxlfb_create_pinned_object(struct qxl_fbdev *qfbdev,
> > int ret;
> > int aligned_size, size;
> > int height = mode_cmd->height;
> > - int bpp;
> > - int depth;
> > -
> > - drm_fb_get_bpp_depth(mode_cmd->pixel_format, &bpp, &depth);
> >
> > size = mode_cmd->pitches[0] * height;
> > aligned_size = ALIGN(size, PAGE_SIZE);
> > --
> > Regards,
> >
> > Laurent Pinchart
> >
> > _______________________________________________
> > dri-devel mailing list
> > dri-devel@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/dri-devel
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2016-06-08 7:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-06 18:14 [PATCH] drm/qxl: Remove useless drm_fb_get_bpp_depth() call Laurent Pinchart
2016-06-07 16:50 ` Eric Engestrom
2016-06-08 7:37 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160608073746.GJ3363@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=airlied@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=eric.engestrom@imgtec.com \
--cc=laurent.pinchart@ideasonboard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox