From: Daniel Vetter <daniel@ffwll.ch>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: bcousson@baylibre.com, dri-devel@lists.freedesktop.org,
Jyri Sarha <jsarha@ti.com>,
laurent.pinchart@ideasonboard.com
Subject: Re: [PATCH 1/5] drm/tilcdc: Restore old dmps state in pm_resume()
Date: Tue, 14 Jun 2016 18:22:43 +0200 [thread overview]
Message-ID: <20160614162243.GX1338@phenom.ffwll.local> (raw)
In-Reply-To: <575FEF1C.3090603@ti.com>
On Tue, Jun 14, 2016 at 02:48:44PM +0300, Tomi Valkeinen wrote:
> On 14/06/16 14:45, Jyri Sarha wrote:
> > Restore old dpms state in pm_resume(). The dpms is turned off in
> > pm_suspend() and it should be restored to its original state in
> > pm_resume().
> >
> > Fixes commit 614b3cfeb8d2 ("drm/tilcdc: disable the lcd controller/dma
> > engine when suspend invoked")
>
> "dmps" in the subject.
>
> It would be good to mention what the problem seen is, what does this fix.
With atomic you get this all for free, using
drm_atomic_helper_suspend/resume ...
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-06-14 16:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-14 11:45 [PATCH 0/5] drm/tilcdc Fixes and cleanups Jyri Sarha
2016-06-14 11:45 ` [PATCH 1/5] drm/tilcdc: Restore old dmps state in pm_resume() Jyri Sarha
2016-06-14 11:48 ` Tomi Valkeinen
2016-06-14 16:22 ` Daniel Vetter [this message]
2016-06-14 11:45 ` [PATCH 2/5] drm/tilcdc: Write to LCDC_END_OF_INT_IND_REG at the end of IRQ function Jyri Sarha
2016-06-14 11:45 ` [PATCH 3/5] drm/tilcdc: Move waiting of LCDC_FRAME_DONE IRQ into stop() Jyri Sarha
2016-06-14 16:24 ` Daniel Vetter
2016-06-14 11:45 ` [PATCH 4/5] drm/tilcdc: Refer to panel.txt and tfp410.txt bindings in tilcdc.txt Jyri Sarha
2016-06-14 11:45 ` [PATCH 5/5] drm/tilcdc: Avoid error print by of_graph_get_next_endpoint() Jyri Sarha
2016-06-14 11:50 ` Jyri Sarha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160614162243.GX1338@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=bcousson@baylibre.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jsarha@ti.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox