Re: [PATCH v2 00/15] Runtime pm ref leak bonanza

[Lukas Wunner <lukas-JFq808J9C/izQB+pC5nmwQ@public.gmane.org>]

On Tue, Jun 14, 2016 at 04:18:00PM -0400, Alex Deucher wrote:
> On Thu, Jun 9, 2016 at 2:50 AM, Daniel Vetter <daniel@ffwll.ch> wrote:
> > On Wed, Jun 08, 2016 at 06:47:27PM +0200, Lukas Wunner wrote:
> >> Second iteration of my endeavour to rid nouveau, radeon and amdgpu of
> >> runtime pm ref leaks.
> >>
> >> Patches 1 to 8 are identical to v1.
> >>
> >> Patch 9 of v1 modified the DRM core to turn off all CRTCs on driver
> >> unload. Based on feedback by Daniel Vetter, I've replaced this with
> >> a helper to turn off all CRTCs, which is called by nouveau, radeon
> >> and amdgpu on unload. In other words, this is now opt-in.
> >> So patch 9 of v1 is replaced with new patches 9 to 12.
> >>
> >> A by-product of patch 9 is a helper which turns off a *single* CRTC.
> >> This is open coded in three other places in the DRM tree and patches
> >> 13 to 15 refactor those to use the new helper.
> >
> > Yeah I think this makes much more sense. Please poke amd/nouveau folks for
> > reviews/acks, then I can merge.
> 
> The amdgpu, radeon, and drm patches are:
> Acked-by: Alex Deucher <alexander.deucher@amd.com>

Great, thank you. That means all patches are either acked or reviewed:

* Patches 1, 2, 10 and 15 are
  Acked-by: Ben Skeggs <bskeggs@redhat.com>
  Message-ID: <b4e3a8a6-cb44-80bf-8834-419afc2d1cb4@gmail.com>
  Link: https://lists.freedesktop.org/archives/nouveau/2016-June/025350.html

* Patches 3 - 9 and 11 - 13 are
  Acked-by: Alex Deucher <alexander.deucher@amd.com>
  Message-ID: <CADnq5_NENZukwJg-CACQ-djWsP4e299gnr4aWrEJkdcVMeaZWA@mail.gmail.com>
  Link: https://lists.freedesktop.org/archives/dri-devel/2016-June/110876.html

* Patch 14 is
  Reviewed-by: Francisco Jerez <currojerez@riseup.net>
  Message-ID: <87ziqrtml5.fsf@riseup.net>
  Link: https://lists.freedesktop.org/archives/dri-devel/2016-June/110588.html


Dave, Daniel, could one of you pick this up?

I've pushed another branch to GitHub which is amended with all the
Acked-by and Reviewed-by tags. It's also rebased on latest drm-next.
Otherwise this is identical to what I've posted. So in case you don't
want to apply all tags manually, you can cherry-pick from or merge
this branch (barring any objections of course):
https://github.com/l1k/linux/commits/drm_runpm_fixes_v2_acked

Thanks everyone!

Lukas
_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau