From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: [patch v2] drm/amdgpu: missing bounds check in amdgpu_set_pp_force_state() Date: Thu, 16 Jun 2016 11:30:23 +0300 Message-ID: <20160616083023.GA7046@mwanda> References: <20160616080949.GI32247@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from aserp1040.oracle.com (aserp1040.oracle.com [141.146.126.69]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6CF316E254 for ; Thu, 16 Jun 2016 08:30:48 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20160616080949.GI32247@mwanda> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Alex Deucher Cc: Jammy Zhou , kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org, Geliang Tang , Eric Huang , Rex Zhu , Christian =?iso-8859-1?Q?K=F6nig?= List-Id: dri-devel@lists.freedesktop.org VGhlcmUgaXMgbm8gbGltaXQgb24gaGlnaCAiaWR4IiBjYW4gZ28uICBJdCBzaG91bGQgYmUgbGVz cyB0aGFuCkFSUkFZX1NJWkUoZGF0YS5zdGF0ZXMpIHdoaWNoIGlzIDE2LgoKVGhlICJkYXRhIiB2 YXJpYWJsZSB3YXNuJ3QgZGVjbGFyZWQgaW4gdGhhdCBzY29wZSBzbyBJIHNoaWZ0ZWQgdGhlIGNv ZGUKYXJvdW5kIGEgYml0IHRvIG1ha2UgaXQgd29yay4gIEFsc28gSSBtYWRlICJpZHgiIHVuc2ln bmVkLgoKRml4ZXM6IGYzODk4ZWExMmZjMSAoJ2RybS9hbWQvcG93ZXJwbGF5OiBhZGQgc29tZSBz eXNmcyBpbnRlcmZhY2VzIGZvciBwb3dlcnBsYXkuJykKU2lnbmVkLW9mZi1ieTogRGFuIENhcnBl bnRlciA8ZGFuLmNhcnBlbnRlckBvcmFjbGUuY29tPgotLS0KdjI6IG1ha2UgaWR4IHVuc2lnbmVk CgpkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X3BtLmMgYi9k cml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfcG0uYwppbmRleCA1ODliMzZlLi4wZTEz ZDgwIDEwMDY0NAotLS0gYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfcG0uYwor KysgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfcG0uYwpAQCAtMjcwLDMwICsy NzAsMjggQEAgc3RhdGljIHNzaXplX3QgYW1kZ3B1X3NldF9wcF9mb3JjZV9zdGF0ZShzdHJ1Y3Qg ZGV2aWNlICpkZXYsCiAJc3RydWN0IGRybV9kZXZpY2UgKmRkZXYgPSBkZXZfZ2V0X2RydmRhdGEo ZGV2KTsKIAlzdHJ1Y3QgYW1kZ3B1X2RldmljZSAqYWRldiA9IGRkZXYtPmRldl9wcml2YXRlOwog CWVudW0gYW1kX3BtX3N0YXRlX3R5cGUgc3RhdGUgPSAwOwotCWxvbmcgaWR4OworCXVuc2lnbmVk IGxvbmcgaWR4OwogCWludCByZXQ7CiAKIAlpZiAoc3RybGVuKGJ1ZikgPT0gMSkKIAkJYWRldi0+ cHBfZm9yY2Vfc3RhdGVfZW5hYmxlZCA9IGZhbHNlOwotCWVsc2UgewotCQlyZXQgPSBrc3RydG9s KGJ1ZiwgMCwgJmlkeCk7CisJZWxzZSBpZiAoYWRldi0+cHBfZW5hYmxlZCkgeworCQlzdHJ1Y3Qg cHBfc3RhdGVzX2luZm8gZGF0YTsKIAotCQlpZiAocmV0KSB7CisJCXJldCA9IGtzdHJ0b3VsKGJ1 ZiwgMCwgJmlkeCk7CisJCWlmIChyZXQgfHwgaWR4ID49IEFSUkFZX1NJWkUoZGF0YS5zdGF0ZXMp KSB7CiAJCQljb3VudCA9IC1FSU5WQUw7CiAJCQlnb3RvIGZhaWw7CiAJCX0KIAotCQlpZiAoYWRl di0+cHBfZW5hYmxlZCkgewotCQkJc3RydWN0IHBwX3N0YXRlc19pbmZvIGRhdGE7Ci0JCQlhbWRn cHVfZHBtX2dldF9wcF9udW1fc3RhdGVzKGFkZXYsICZkYXRhKTsKLQkJCXN0YXRlID0gZGF0YS5z dGF0ZXNbaWR4XTsKLQkJCS8qIG9ubHkgc2V0IHVzZXIgc2VsZWN0ZWQgcG93ZXIgc3RhdGVzICov Ci0JCQlpZiAoc3RhdGUgIT0gUE9XRVJfU1RBVEVfVFlQRV9JTlRFUk5BTF9CT09UICYmCi0JCQkJ c3RhdGUgIT0gUE9XRVJfU1RBVEVfVFlQRV9ERUZBVUxUKSB7Ci0JCQkJYW1kZ3B1X2RwbV9kaXNw YXRjaF90YXNrKGFkZXYsCi0JCQkJCQlBTURfUFBfRVZFTlRfRU5BQkxFX1VTRVJfU1RBVEUsICZz dGF0ZSwgTlVMTCk7Ci0JCQkJYWRldi0+cHBfZm9yY2Vfc3RhdGVfZW5hYmxlZCA9IHRydWU7Ci0J CQl9CisJCWFtZGdwdV9kcG1fZ2V0X3BwX251bV9zdGF0ZXMoYWRldiwgJmRhdGEpOworCQlzdGF0 ZSA9IGRhdGEuc3RhdGVzW2lkeF07CisJCS8qIG9ubHkgc2V0IHVzZXIgc2VsZWN0ZWQgcG93ZXIg c3RhdGVzICovCisJCWlmIChzdGF0ZSAhPSBQT1dFUl9TVEFURV9UWVBFX0lOVEVSTkFMX0JPT1Qg JiYKKwkJICAgIHN0YXRlICE9IFBPV0VSX1NUQVRFX1RZUEVfREVGQVVMVCkgeworCQkJYW1kZ3B1 X2RwbV9kaXNwYXRjaF90YXNrKGFkZXYsCisJCQkJCUFNRF9QUF9FVkVOVF9FTkFCTEVfVVNFUl9T VEFURSwgJnN0YXRlLCBOVUxMKTsKKwkJCWFkZXYtPnBwX2ZvcmNlX3N0YXRlX2VuYWJsZWQgPSB0 cnVlOwogCQl9CiAJfQogZmFpbDoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRl c2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v ZHJpLWRldmVsCg==