From: Thierry Reding <thierry.reding@gmail.com>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/omap: dsi: Remove unused variable
Date: Tue, 21 Jun 2016 16:01:38 +0200 [thread overview]
Message-ID: <20160621140138.GA21079@ulmo.ba.sec> (raw)
In-Reply-To: <5769486F.9010006@ti.com>
[-- Attachment #1.1: Type: text/plain, Size: 1260 bytes --]
On Tue, Jun 21, 2016 at 05:00:15PM +0300, Tomi Valkeinen wrote:
> Hi Thierry,
>
> On 21/06/16 16:56, Thierry Reding wrote:
> > From: Thierry Reding <treding@nvidia.com>
> >
> > Commit 973999aa0140 ("drm/omap: Remove regulator API abuse") removed the
> > only user of the local 'r' variable, which thus became unused.
> >
> > Signed-off-by: Thierry Reding <treding@nvidia.com>
> > ---
> > drivers/gpu/drm/omapdrm/dss/dsi.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c b/drivers/gpu/drm/omapdrm/dss/dsi.c
> > index 6f45e9d00b41..e1be5e795cd8 100644
> > --- a/drivers/gpu/drm/omapdrm/dss/dsi.c
> > +++ b/drivers/gpu/drm/omapdrm/dss/dsi.c
> > @@ -1167,7 +1167,6 @@ static int dsi_regulator_init(struct platform_device *dsidev)
> > {
> > struct dsi_data *dsi = dsi_get_dsidrv_data(dsidev);
> > struct regulator *vdds_dsi;
> > - int r;
> >
> > if (dsi->vdds_dsi_reg != NULL)
> > return 0;
> >
>
> Thanks, but there's already 85332739628fe4beafecdb713438c7cb1454c2f5
> ("drm/omap: fix unused variable warning in dsi & hdmi") in the mainline
> (-rc3).
Bah... that's what I get for not generating patches against linux-next.
Thanks for letting me know.
Thierry
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2016-06-21 14:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-21 13:56 [PATCH 1/2] drm/omap: dsi: Remove unused variable Thierry Reding
2016-06-21 13:56 ` [PATCH 2/2] drm/omap: hdmi: " Thierry Reding
2016-06-21 14:00 ` [PATCH 1/2] drm/omap: dsi: " Tomi Valkeinen
2016-06-21 14:01 ` Thierry Reding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160621140138.GA21079@ulmo.ba.sec \
--to=thierry.reding@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=peter.ujfalusi@ti.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox