From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCHv3 1/1] drm/imx: convey the pixelclk-active and de-active flags from DT to the ipu-di driver Date: Tue, 12 Jul 2016 16:39:25 +0200 Message-ID: <20160712143925.GA26274@ulmo.ba.sec> References: <1464182296-23812-1-git-send-email-LW@KARO-electronics.de> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0479787743==" Return-path: Received: from mail-pf0-x235.google.com (mail-pf0-x235.google.com [IPv6:2607:f8b0:400e:c00::235]) by gabe.freedesktop.org (Postfix) with ESMTPS id AAD9C6E215 for ; Tue, 12 Jul 2016 14:39:30 +0000 (UTC) Received: by mail-pf0-x235.google.com with SMTP id c2so7731321pfa.2 for ; Tue, 12 Jul 2016 07:39:30 -0700 (PDT) In-Reply-To: <1464182296-23812-1-git-send-email-LW@KARO-electronics.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Lothar =?utf-8?Q?Wa=C3=9Fmann?= Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org --===============0479787743== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="jI8keyz6grp/JLjh" Content-Disposition: inline --jI8keyz6grp/JLjh Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, May 25, 2016 at 03:18:16PM +0200, Lothar Wa=C3=9Fmann wrote: > The 'de-active' and 'pixelclk-active' DT properties are evaluated > by of_parse_display_timing() called from of_get_drm_display_mode(), > but later lost in the conversion from videomode.flags to > drm_display_mode.flags. > Use an open coded version of of_get_drm_display_mode() to get access > to these flags and make sure they are passed on to the ipu-di driver. >=20 > Changes vs. v2: > - removed patches which have already been applied > - created a drm_bus_flags_from_videomode() helper to prevent code > duplication as suggested by Philipp Zabel >=20 > Changes vs. v1: > - rebased on top of https://patchwork.kernel.org/patch/9113791/ as > per Philipp Zabel's request >=20 > GIT: [PATCHv2 1/3] drm/imx: imx-ldb: honor 'native-mode' property when > GIT: [PATCHv2 2/3] drm/imx: convey the pixelclk-active and de-active flags > GIT: [PATCHv2 3/3] drm/imx: remove dead code > Signed-off-by: Lothar Wa=C3=9Fmann > --- > drivers/gpu/drm/drm_modes.c | 20 +++++++++++++++++++- > drivers/gpu/drm/imx/imx-ldb.c | 15 ++++++++++----- > drivers/gpu/drm/imx/parallel-display.c | 16 +++++++++++++--- > include/drm/drm_modes.h | 5 +++-- > 4 files changed, 45 insertions(+), 11 deletions(-) Maybe a stupid question, but why does i.MX even allow video timings to be specified in DT instead of going through panel drivers like everyone else? Thierry --jI8keyz6grp/JLjh Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJXhQEdAAoJEN0jrNd/PrOhgzEQALuOzd7yMt/+ChcR6rigAWT3 X3zqkRIW0rZEq4tQ5tj03XxVCPtJh4bwcWoWMbSEp06T0dDAfzcdw/WECekr7W16 AosuFX7/T7YIzqYYUxQyC0PHSm/mrvnbstrzjN+97CFd/dIrG+RwcXxZvObWMH0J Lpoq+8mo2UswQYPpXjORq4iJWFMZonRZkeyUFKAoWYdGQx8Gqg1nuX+8S3Vdp70P 3U6g8Z5J5qjNhia1QKDK85VsElg97uIb4MzqdqC1Y055zFkrkOvCLWH3lFrj12PG W4XRxKvs5CBZkVtHeovrUH5jB8Nur2ywpG0SclBGBhirwUexH0F6GnycUJncEcAP vqs5ndkGar0I6sD+OZBeYmwIEFelYi60yXF5Sf0gMIZCFocBPx/cb3xyr5zzB+40 uoG04x0cmsZlqsxwK2AnTMch1ulZixHcIhCXa9UQhZS55Gjr6yB79+cI9USa96Jl 4vaYNmOBd1rBxd6kQ7Z/D90MuQ7dqBBIjS6XQABgsz89Rvfr2x24/2WcWQ/LoWAy yY1vXhrluCZ84fDCqttrbLHu3wREGtun9xgVjMzjWc1o/CkXB1wNtxxWenGy3KnN z5FPMokkMZ0woIr4a1zzZ2/RG7mGlj+rs7/7ZQXuglj76H4Si3V8MzBFylaFgGdJ a1tWp2QVNPkVnx0rowj9 =tdIh -----END PGP SIGNATURE----- --jI8keyz6grp/JLjh-- --===============0479787743== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============0479787743==--