From: Shawn Guo <shawnguo@kernel.org>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: Zheng Yang <zhengyang@rock-chips.com>, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/edid: move DDC_SEGMENT_ADDR into drm_edid.h
Date: Thu, 14 Jul 2016 21:21:03 +0800 [thread overview]
Message-ID: <20160714132103.GA4382@tiger> (raw)
In-Reply-To: <20160714124541.GB14408@phenom.ffwll.local>
On Thu, Jul 14, 2016 at 02:45:41PM +0200, Daniel Vetter wrote:
> On Thu, Jul 14, 2016 at 05:00:28PM +0800, Shawn Guo wrote:
> > The same definition of DDC_SEGMENT_ADDR is currently defined in two
> > places, drm_edid.c and inno_hdmi.h. Let's consolidate the definition
> > into drm_edid.h in the same way that DDC_ADDR is defined.
> >
> > Signed-off-by: Shawn Guo <shawnguo@kernel.org>
>
> What really should be done here is nuke the fake i2c adapter in
> inno_hdmi.c and instead just directly read the edid from the hdim IP.
> Using drm_get_edid for something that's not backed by a real i2c bus is
> bonghits.
This patch just makes some change literally. I do not understand how
the IP block works at all. I thought the HDMI IP talks to monitors
using I2C protocol implemented inside the IP block. I added Rockchip
folks to see if we can get any clarifications from them.
Shawn
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-07-14 13:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-14 9:00 [PATCH] drm/edid: move DDC_SEGMENT_ADDR into drm_edid.h Shawn Guo
2016-07-14 12:45 ` Daniel Vetter
2016-07-14 13:21 ` Shawn Guo [this message]
2016-07-15 7:24 ` Daniel Vetter
2016-07-15 11:31 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160714132103.GA4382@tiger \
--to=shawnguo@kernel.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=zhengyang@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox