From: Daniel Vetter <daniel@ffwll.ch>
To: Eric Anholt <eric@anholt.net>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: Some more VC4 vblank fixes and timestamping improvements.
Date: Fri, 22 Jul 2016 10:31:36 +0200 [thread overview]
Message-ID: <20160722083136.GC25486@phenom.ffwll.local> (raw)
In-Reply-To: <87invybw6f.fsf@eliezer.anholt.net>
On Thu, Jul 21, 2016 at 12:58:16PM -0700, Eric Anholt wrote:
> Mario Kleiner <mario.kleiner.de@gmail.com> writes:
>
> > Hi Eric and all,
> >
> > this batch prevents setting modes one shouldn't set,
> > adds precise vblank timestamping for interlaced video
> > modes, and one fix for vblank en/disable during crtc
> > en/disable.
> >
> > All successfully tested, also with timing measurement equipment,
> > on the RPi 2B.
>
> This all seems pretty reasonable to me. My question for modesetting
> gurus would be: Is mode_fixup the place to be filtering out
> unsupportable modes from the user (or their displays)?
Yup. And I wanted to forever add some glue so that drivers could share the
same validation logic between mode_fixup (for modesets) and mode_valid
(for probing). But never came up with a helper scaffolding that looked
satisfactory. The icky bit is that mode_fixup wants an adjusted mode, and
we'd need to fake that somehow to reuse the same code in mode_valid. It's
even worse for atomic, where atomic_check (the new mode_fixup) gets an
entire atomic state. But I still think for simpler hw (anything which
doesn't have funny crtc/encoder specific restrictions) we should be able
to create something that just works.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-07-22 8:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-19 18:58 Some more VC4 vblank fixes and timestamping improvements Mario Kleiner
2016-07-19 18:58 ` [PATCH 1/5] drm/vc4: Disallow interlaced modes on DPI Mario Kleiner
2016-07-19 18:58 ` [PATCH 2/5] drm/vc4: Fix handling of interlaced video modes Mario Kleiner
2016-07-19 18:58 ` [PATCH 3/5] drm/vc4: Reject doublescan modes Mario Kleiner
2016-07-19 18:59 ` [PATCH 4/5] drm/vc4: Enable precise vblank timestamping for interlaced modes Mario Kleiner
2016-07-19 18:59 ` [PATCH 5/5] drm/vc4: Enable/Disable vblanks properly in crtc en/disable Mario Kleiner
2016-07-21 19:58 ` Some more VC4 vblank fixes and timestamping improvements Eric Anholt
2016-07-22 8:31 ` Daniel Vetter [this message]
2016-08-20 2:08 ` Eric Anholt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160722083136.GC25486@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=eric@anholt.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox