From: Daniel Vetter <daniel@ffwll.ch>
To: Philipp Zabel <p.zabel@pengutronix.de>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
dri-devel@lists.freedesktop.org, kernel@pengutronix.de
Subject: Re: [PATCH] drm/imx: imx-ldb: do not try to dereference crtc->state->state in encoder mode_set
Date: Fri, 22 Jul 2016 18:49:15 +0200 [thread overview]
Message-ID: <20160722164915.GF25486@phenom.ffwll.local> (raw)
In-Reply-To: <1469185035.27223.14.camel@pengutronix.de>
On Fri, Jul 22, 2016 at 12:57:15PM +0200, Philipp Zabel wrote:
> Am Freitag, den 22.07.2016, 11:35 +0200 schrieb Daniel Vetter:
> [...]
> > Proper fix would be to roll out atomic_ versions of all teh encoder
> > callbacks where we additionally pass both the crtc state and the connector
> > state. Then there's no need for walking connector lists like that. And in
> > the atomic helpers those two states are always readily available, and
> > passing them down to callbacks is also what we will do in i915. I'd be
> > happy to merge such a patch.
>
> Thanks, that is a good idea. Which encoder callbacks besides mode_set ->
> atomic_mode_set are you thinking of, though? enable/disable?
Yes. The only other one is mode_fixup, and we already have atomic_check as
the fancy replacement for that. Please align the parameter ordering with
encoder->atomic_check for consistency.
Also when you do that patch, pls don't forget the vtable kerneldoc
comments, and make sure there's no warnings/issues and it renders nicely
using
$ make htmldocs
Since 4.8 will feature a new sphinx-based toolchain, pls run that command
on top of linux-next (for the latest sphinx fixes from docs-next).
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-07-22 16:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-22 8:59 [PATCH] drm/imx: imx-ldb: do not try to dereference crtc->state->state in encoder mode_set Philipp Zabel
2016-07-22 9:09 ` Philipp Zabel
2016-07-22 9:35 ` Daniel Vetter
2016-07-22 10:57 ` Philipp Zabel
2016-07-22 16:49 ` Daniel Vetter [this message]
2016-07-25 10:42 ` Philipp Zabel
2016-07-25 15:02 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160722164915.GF25486@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel@pengutronix.de \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox