From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/9] drm: Warn about negative sizes when calculating scale factor
Date: Tue, 26 Jul 2016 19:39:30 +0300 [thread overview]
Message-ID: <20160726163930.GJ4329@intel.com> (raw)
In-Reply-To: <20160726162442.GB31051@nuc-i3427.alporthouse.com>
On Tue, Jul 26, 2016 at 05:24:42PM +0100, Chris Wilson wrote:
> On Tue, Jul 26, 2016 at 07:06:56PM +0300, ville.syrjala@linux.intel.com wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > Passing negative width/hight to scale factor calculations is not
> > legal. Let's WARN if that happens.
>
> Does this get called with user controllable inputs?
User controllable to a degree. width/height can only ever be positive
though.
> A quick grep leads
> me to drm_primary_helper_update() which suggests no. Did I miss a
> potential user controllable WARN->panic?
I just landed in the BUG_ON in intel_sprite.c on account of a typo I
made in the user src/crtc coordinate -> drm_rect conversion. Should
probably replace the BUG_ON() with WARN_ON() in i915 as well...
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-07-26 16:39 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-26 16:06 [PATCH 0/9] drm: Store clipped coordinates in drm_plane_state ville.syrjala
2016-07-26 16:06 ` [PATCH 1/9] drm: Warn about negative sizes when calculating scale factor ville.syrjala
2016-07-26 16:24 ` Chris Wilson
2016-07-26 16:39 ` Ville Syrjälä [this message]
2016-07-29 20:41 ` [Intel-gfx] " Sean Paul
2016-07-26 16:06 ` [PATCH 2/9] drm: Store clipped src/dst coordinatee in drm_plane_state ville.syrjala
2016-08-01 15:10 ` Sean Paul
2016-07-26 16:06 ` [PATCH 3/9] drm/plane-helper: Add drm_plane_helper_check_state() ville.syrjala
2016-07-26 16:33 ` Chris Wilson
2016-07-26 16:42 ` Ville Syrjälä
2016-07-27 7:22 ` [Intel-gfx] " Daniel Vetter
2016-07-26 17:34 ` [PATCH v2 " ville.syrjala
2016-08-01 15:10 ` [Intel-gfx] " Sean Paul
2016-08-08 7:29 ` Daniel Kurtz
2016-08-08 7:44 ` [Intel-gfx] " Ville Syrjälä
2016-08-08 7:55 ` [PATCH v3 " ville.syrjala
2016-07-26 16:06 ` [PATCH 4/9] drm/i915: Use drm_plane_state.{src,dst,visible} ville.syrjala
2016-07-26 16:20 ` Chris Wilson
2016-08-01 15:10 ` [PATCH 4/9] drm/i915: Use drm_plane_state.{src, dst, visible} Sean Paul
2016-07-26 16:07 ` [PATCH 5/9] drm/i915: Use drm_plane_helper_check_state() ville.syrjala
2016-08-01 15:10 ` Sean Paul
[not found] ` <1469549224-1860-1-git-send-email-ville.syrjala-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2016-07-26 16:07 ` [PATCH 6/9] drm/rockchip: Use drm_plane_state.{src,dst} ville.syrjala-VuQAYsv1563Yd54FQh9/CA
2016-07-27 1:08 ` Mark yao
2016-08-01 15:10 ` [Intel-gfx] [PATCH 6/9] drm/rockchip: Use drm_plane_state.{src, dst} Sean Paul
2016-07-26 16:07 ` [PATCH 7/9] drm/rockchip: Use drm_plane_helper_check_state() ville.syrjala
2016-07-27 1:09 ` Mark yao
2016-08-01 15:10 ` [Intel-gfx] " Sean Paul
2016-07-26 16:07 ` [PATCH 8/9] drm/mediatek: " ville.syrjala
2016-08-01 15:10 ` Sean Paul
2016-08-02 5:31 ` Bibby Hsieh
2016-08-02 5:45 ` CK Hu
2016-07-26 16:07 ` [PATCH 9/9] drm/simple_kms_helper: " ville.syrjala
2016-08-01 15:10 ` Sean Paul
2016-08-01 15:12 ` [PATCH 0/9] drm: Store clipped coordinates in drm_plane_state Sean Paul
2016-08-01 15:19 ` Ville Syrjälä
2016-08-02 13:24 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160726163930.GJ4329@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).