From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH v3 2/3] drm: Add API for capturing frame CRCs
Date: Fri, 5 Aug 2016 14:42:02 +0300
Message-ID: <20160805114202.GU4329@intel.com>
References: <1469196645-3061-1-git-send-email-tomeu.vizoso@collabora.com>
 <1469196645-3061-3-git-send-email-tomeu.vizoso@collabora.com>
 <20160803070638.GE4329@intel.com>
 <CAAObsKBAQP3isZejezEFgEDrXFMFWvGEOhYLCxHP4cZxzzt-4g@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by gabe.freedesktop.org (Postfix) with ESMTP id 1AA3E6EB74
 for <dri-devel@lists.freedesktop.org>; Fri,  5 Aug 2016 11:42:12 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <CAAObsKBAQP3isZejezEFgEDrXFMFWvGEOhYLCxHP4cZxzzt-4g@mail.gmail.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Cc: "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>, Jonathan Corbet <corbet@lwn.net>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>, Daniel Vetter <daniel.vetter@intel.com>, Emil Velikov <emil.velikov@collabora.com>
List-Id: dri-devel@lists.freedesktop.org

T24gRnJpLCBBdWcgMDUsIDIwMTYgYXQgMTI6NDY6MjlQTSArMDIwMCwgVG9tZXUgVml6b3NvIHdy
b3RlOgo+IE9uIDMgQXVndXN0IDIwMTYgYXQgMDk6MDYsIFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUu
c3lyamFsYUBsaW51eC5pbnRlbC5jb20+IHdyb3RlOgo+ID4gT24gRnJpLCBKdWwgMjIsIDIwMTYg
YXQgMDQ6MTA6NDRQTSArMDIwMCwgVG9tZXUgVml6b3NvIHdyb3RlOgo+ID4+IEFkZHMgZmlsZXMg
YW5kIGRpcmVjdG9yaWVzIHRvIGRlYnVnZnMgZm9yIGNvbnRyb2xsaW5nIGFuZCByZWFkaW5nIGZy
YW1lCj4gPj4gQ1JDcywgcGVyIENSVEM6Cj4gPj4KPiA+PiBkcmkvMC9jcnRjLTAvY3JjCj4gPj4g
ZHJpLzAvY3J0Yy0wL2NyYy9jb250cm9sCj4gPj4gZHJpLzAvY3J0Yy0wL2NyYy9kYXRhCj4gPj4K
PiA+PiBEcml2ZXJzIGNhbiBpbXBsZW1lbnQgdGhlIHNldF9jcmNfc291cmNlIGNhbGxiYWNrKCkg
aW4gZHJtX2NydGNfZnVuY3MgdG8KPiA+PiBzdGFydCBhbmQgc3RvcCBnZW5lcmF0aW5nIGZyYW1l
IENSQ3MgYW5kIGNhbiBhZGQgZW50cmllcyB0byB0aGUgb3V0cHV0Cj4gPj4gYnkgY2FsbGluZyBk
cm1fY3J0Y19hZGRfY3JjX2VudHJ5Lgo+ID4+Cj4gPj4gdjI6Cj4gPj4gICAgIC0gTG90cyBvZiBn
b29kIGZpeGVzIHN1Z2dlc3RlZCBieSBUaGllcnJ5Lgo+ID4+ICAgICAtIEFkZGVkIGRvY3VtZW50
YXRpb24uCj4gPj4gICAgIC0gQ2hhbmdlZCB0aGUgZGVidWdmcyBsYXlvdXQuCj4gPj4gICAgIC0g
TW92ZWQgdG8gYWxsb2NhdGUgdGhlIGVudHJpZXMgY2lyY3VsYXIgcXVldWUgb25jZSB3aGVuIGZy
YW1lCj4gPj4gICAgICAgZ2VuZXJhdGlvbiBnZXRzIGVuYWJsZWQgZm9yIHRoZSBmaXJzdCB0aW1l
Lgo+ID4+IHYzOgo+ID4+ICAgICAtIFVzZSB0aGUgY29udHJvbCBmaWxlIGp1c3QgdG8gc2VsZWN0
IHRoZSBzb3VyY2UsIGFuZCBzdGFydCBhbmQgc3RvcAo+ID4+ICAgICAgIGNhcHR1cmUgd2hlbiB0
aGUgZGF0YSBmaWxlIGlzIG9wZW5lZCBhbmQgY2xvc2VkLCByZXNwZWN0aXZlbHkuCj4gPj4gICAg
IC0gTWFrZSB2YXJpYWJsZSB0aGUgbnVtYmVyIG9mIENSQyB2YWx1ZXMgcGVyIGVudHJ5LCBwZXIg
c291cmNlLgo+ID4+ICAgICAtIEFsbG9jYXRlIGVudHJpZXMgcXVldWUgZWFjaCB0aW1lIHdlIHN0
YXJ0IGNhcHR1cmluZyBhcyBub3cgdGhlcmUKPiA+PiAgICAgICBpc24ndCBhIGZpeGVkIG51bWJl
ciBvZiBDUkMgdmFsdWVzIHBlciBlbnRyeS4KPiA+PiAgICAgLSBTdG9yZSB0aGUgZnJhbWUgY291
bnRlciBpbiB0aGUgZGF0YSBmaWxlIGFzIGEgOC1kaWdpdCBoZXggbnVtYmVyLgo+ID4+ICAgICAt
IEZvciBzb3VyY2VzIHRoYXQgY2Fubm90IHByb3ZpZGUgdXNlZnVsIGZyYW1lIG51bWJlcnMsIHBs
YWNlCj4gPj4gICAgICAgWFhYWFhYWFggaW4gdGhlIGZyYW1lIGZpZWxkLgo+ID4+Cj4gPj4gU2ln
bmVkLW9mZi1ieTogVG9tZXUgVml6b3NvIDx0b21ldS52aXpvc29AY29sbGFib3JhLmNvbT4KPiA+
PiAtLS0KPiAuLi4KPiA+PiArc3RhdGljIHNzaXplX3QgY3JjX2NvbnRyb2xfd3JpdGUoc3RydWN0
IGZpbGUgKmZpbGUsIGNvbnN0IGNoYXIgX191c2VyICp1YnVmLAo+ID4+ICsgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICBzaXplX3QgbGVuLCBsb2ZmX3QgKm9mZnApCj4gPj4gK3sKPiA+PiAr
ICAgICBzdHJ1Y3Qgc2VxX2ZpbGUgKm0gPSBmaWxlLT5wcml2YXRlX2RhdGE7Cj4gPj4gKyAgICAg
c3RydWN0IGRybV9jcnRjICpjcnRjID0gbS0+cHJpdmF0ZTsKPiA+PiArICAgICBzdHJ1Y3QgZHJt
X2NydGNfY3JjICpjcmMgPSAmY3J0Yy0+Y3JjOwo+ID4+ICsgICAgIGNoYXIgKnNvdXJjZTsKPiA+
PiArCj4gPj4gKyAgICAgaWYgKGxlbiA9PSAwKQo+ID4+ICsgICAgICAgICAgICAgcmV0dXJuIDA7
Cj4gPj4gKwo+ID4+ICsgICAgIGlmIChsZW4gPiBQQUdFX1NJWkUgLSAxKSB7Cj4gPj4gKyAgICAg
ICAgICAgICBEUk1fREVCVUdfS01TKCJFeHBlY3RlZCA8ICVsdSBieXRlcyBpbnRvIGNydGMgY3Jj
IGNvbnRyb2xcbiIsCj4gPj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgIFBBR0VfU0laRSk7
Cj4gPj4gKyAgICAgICAgICAgICByZXR1cm4gLUUyQklHOwo+ID4+ICsgICAgIH0KPiA+PiArCj4g
Pj4gKyAgICAgc291cmNlID0ga21hbGxvYyhsZW4gKyAxLCBHRlBfS0VSTkVMKTsKPiA+PiArICAg
ICBpZiAoIXNvdXJjZSkKPiA+PiArICAgICAgICAgICAgIHJldHVybiAtRU5PTUVNOwo+ID4+ICsK
PiA+PiArICAgICBpZiAoY29weV9mcm9tX3VzZXIoc291cmNlLCB1YnVmLCBsZW4pKSB7Cj4gPj4g
KyAgICAgICAgICAgICBrZnJlZShzb3VyY2UpOwo+ID4+ICsgICAgICAgICAgICAgcmV0dXJuIC1F
RkFVTFQ7Cj4gPj4gKyAgICAgfQo+ID4KPiA+IG1lbWR1cF91c2VyX251bCgpID8KPiAKPiBHb29k
IGNhbGwuCj4gCj4gPj4gKwo+ID4+ICsgICAgIGlmIChzb3VyY2VbbGVuIC0gMV0gPT0gJ1xuJykK
PiA+PiArICAgICAgICAgICAgIHNvdXJjZVtsZW4gLSAxXSA9ICdcMCc7Cj4gPj4gKyAgICAgZWxz
ZQo+ID4+ICsgICAgICAgICAgICAgc291cmNlW2xlbl0gPSAnXDAnOwo+ID4+ICsKPiA+PiArICAg
ICBzcGluX2xvY2tfaXJxKCZjcmMtPmxvY2spOwo+ID4+ICsKPiA+PiArICAgICBpZiAoY3JjLT5v
cGVuZWQpIHsKPiA+PiArICAgICAgICAgICAgIGtmcmVlKHNvdXJjZSk7Cj4gPj4gKyAgICAgICAg
ICAgICByZXR1cm4gLUVCVVNZOwo+ID4+ICsgICAgIH0KPiA+Cj4gPiBXaHkgbm90IGp1c3Qgc3Rh
cnQgdGhlIHRoaW5nIGhlcmU/Cj4gCj4gRm9yIHRoZSBzYWtlIG9mIHN5bW1ldHJ5LCBhcyB3ZSBh
cmUgc3RvcHBpbmcgd2hlbiB0aGUgZGF0YSBmaWxlIGlzIGNsb3NlZC4KClllcywgYnV0IGlmIHRo
ZSBkYXRhIGZpbGUgaXMgYWxyZWFkeSBvcGVuLCB3ZSBzaG91bGQgc3RhcnQgYXMgc29vbiBhcwp0
aGUgc291cmNlIGlzIGNvbmZpZ3VyZWQuIE9yIGFyZSB5b3UgcmVkdXNpbmcgdG8gb3BlbiB0aGUg
ZGF0YSBmaWxlIHcvbwphIHNvdXJjZSBzZWxlY3RlZD8KCj4gCj4gPj4gK3N0YXRpYyBzdHJ1Y3Qg
ZHJtX2NydGNfY3JjX2VudHJ5ICpjcnRjX2dldF9jcmNfZW50cnkoc3RydWN0IGRybV9jcnRjX2Ny
YyAqY3JjLAo+ID4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgIGludCBpbmRleCkKPiA+PiArewo+ID4+ICsgICAgIHZvaWQgKnAgPSBjcmMtPmVudHJp
ZXM7Cj4gPj4gKyAgICAgc2l6ZV90IGVudHJ5X3NpemUgPSAoc2l6ZW9mKCpjcmMtPmVudHJpZXMp
ICsKPiA+PiArICAgICAgICAgICAgICAgICAgICAgICAgICBzaXplb2YoKmNyYy0+ZW50cmllc1sw
XS5jcmNzKSAqIGNyYy0+dmFsdWVzX2NudCk7Cj4gPgo+ID4gVGhpcyBjb21wdXRhdGlvbiBpcyBk
dXBsaWNhdGVkIGFsc28gaW4gY3J0Y19jcmNfb3BlbigpLiBjb3VsZCB1c2UgYQo+ID4gY29tbW9u
IGhlbHBlciB0byBkbyBpdC4KPiA+Cj4gPiBTaGFtZSB0aGUgbGFuZ3VhZ2UgZG9lc24ndCBoYXZl
IGEgd2F5IHRvIGRlYWwgd2l0aCBhcnJheXMgb2YgdmFyaWFibGUKPiA+IHNpemVkIGFycmF5cyBp
biBhIG5pY2Ugd2F5Lgo+IAo+IE9rLgo+IAo+ID4+ICsKPiA+PiArICAgICByZXR1cm4gcCArIGVu
dHJ5X3NpemUgKiBpbmRleDsKPiA+PiArfQo+ID4+ICsKPiA+PiArI2RlZmluZSBNQVhfTElORV9M
RU4gKDggKyA5ICogRFJNX01BWF9DUkNfTlIgKyAxICsgMSkKPiA+PiArCj4gPj4gK3N0YXRpYyBz
c2l6ZV90IGNydGNfY3JjX3JlYWQoc3RydWN0IGZpbGUgKmZpbGVwLCBjaGFyIF9fdXNlciAqdXNl
cl9idWYsCj4gPj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgc2l6ZV90IGNvdW50LCBsb2Zm
X3QgKnBvcykKPiA+PiArewo+ID4+ICsgICAgIHN0cnVjdCBkcm1fY3J0YyAqY3J0YyA9IGZpbGVw
LT5mX2lub2RlLT5pX3ByaXZhdGU7Cj4gPj4gKyAgICAgc3RydWN0IGRybV9jcnRjX2NyYyAqY3Jj
ID0gJmNydGMtPmNyYzsKPiA+PiArICAgICBzdHJ1Y3QgZHJtX2NydGNfY3JjX2VudHJ5ICplbnRy
eTsKPiA+PiArICAgICBjaGFyIGJ1ZltNQVhfTElORV9MRU5dOwo+ID4+ICsgICAgIGludCByZXQs
IGk7Cj4gPj4gKwo+ID4+ICsgICAgIHNwaW5fbG9ja19pcnEoJmNyYy0+bG9jayk7Cj4gPj4gKwo+
ID4+ICsgICAgIGlmICghY3JjLT5zb3VyY2UpIHsKPiA+PiArICAgICAgICAgICAgIHNwaW5fdW5s
b2NrX2lycSgmY3JjLT5sb2NrKTsKPiA+PiArICAgICAgICAgICAgIHJldHVybiAwOwo+ID4+ICsg
ICAgIH0KPiA+PiArCj4gPj4gKyAgICAgLyogTm90aGluZyB0byByZWFkPyAqLwo+ID4+ICsgICAg
IHdoaWxlIChjcnRjX2NyY19kYXRhX2NvdW50KGNyYykgPT0gMCkgewo+ID4+ICsgICAgICAgICAg
ICAgaWYgKGZpbGVwLT5mX2ZsYWdzICYgT19OT05CTE9DSykgewo+ID4+ICsgICAgICAgICAgICAg
ICAgICAgICBzcGluX3VubG9ja19pcnEoJmNyYy0+bG9jayk7Cj4gPj4gKyAgICAgICAgICAgICAg
ICAgICAgIHJldHVybiAtRUFHQUlOOwo+ID4+ICsgICAgICAgICAgICAgfQo+ID4+ICsKPiA+PiAr
ICAgICAgICAgICAgIHJldCA9IHdhaXRfZXZlbnRfaW50ZXJydXB0aWJsZV9sb2NrX2lycShjcmMt
PndxLAo+ID4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgIGNydGNfY3JjX2RhdGFfY291bnQoY3JjKSwKPiA+PiArICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjcmMtPmxvY2spOwo+ID4+ICsgICAg
ICAgICAgICAgaWYgKHJldCkgewo+ID4+ICsgICAgICAgICAgICAgICAgICAgICBzcGluX3VubG9j
a19pcnEoJmNyYy0+bG9jayk7Cj4gPj4gKyAgICAgICAgICAgICAgICAgICAgIHJldHVybiByZXQ7
Cj4gPj4gKyAgICAgICAgICAgICB9Cj4gPj4gKyAgICAgfQo+ID4+ICsKPiA+PiArICAgICAvKiBX
ZSBrbm93IHdlIGhhdmUgYW4gZW50cnkgdG8gYmUgcmVhZCAqLwo+ID4+ICsgICAgIGVudHJ5ID0g
Y3J0Y19nZXRfY3JjX2VudHJ5KGNyYywgY3JjLT50YWlsKTsKPiA+PiArCj4gPj4gKyAgICAgLyoK
PiA+PiArICAgICAgKiAxIGZyYW1lIGZpZWxkIG9mIDggY2hhcnMgcGx1cyBhIG51bWJlciBvZiBD
UkMgZmllbGRzIG9mIDgKPiA+PiArICAgICAgKiBjaGFycyBlYWNoLCBzcGFjZSBzZXBhcmF0ZWQg
YW5kIHdpdGggYSBuZXdsaW5lIGF0IHRoZSBlbmQuCj4gPj4gKyAgICAgICovCj4gPj4gKyAgICAg
aWYgKGNvdW50IDwgOCArIDkgKiBjcmMtPnZhbHVlc19jbnQgKyAxICsgMSkgewo+ID4KPiA+IEp1
c3QgPCBNQVhfTElORV9MRU4gcGVyaGFwcz8gT3IgY291bGQgbWFrZSBhIG1hY3JvL2Z1bmN0aW9u
IHRoYXQgdGFrZXMKPiA+IGNyYy0+dmFsdWVzX2NudCBvciBEUk1fTUFYX0NSQ19OUiBhcyBhbiBh
cmd1bWVudC4KPiAKPiBTb3VuZHMgZ29vZCwgd2VudCB3aXRoIGEgbWFjcm8uCj4gCj4gPj4gKyAg
ICAgICAgICAgICBzcGluX3VubG9ja19pcnEoJmNyYy0+bG9jayk7Cj4gPj4gKyAgICAgICAgICAg
ICByZXR1cm4gLUVJTlZBTDsKPiA+PiArICAgICB9Cj4gPj4gKwo+ID4+ICsgICAgIEJVSUxEX0JV
R19PTl9OT1RfUE9XRVJfT0ZfMihEUk1fQ1JDX0VOVFJJRVNfTlIpOwo+ID4+ICsgICAgIGNyYy0+
dGFpbCA9IChjcmMtPnRhaWwgKyAxKSAmIChEUk1fQ1JDX0VOVFJJRVNfTlIgLSAxKTsKPiA+PiAr
Cj4gPj4gKyAgICAgc3Bpbl91bmxvY2tfaXJxKCZjcmMtPmxvY2spOwo+ID4+ICsKPiA+PiArICAg
ICBpZiAoZW50cnktPmhhc19mcmFtZV9jb3VudGVyKQo+ID4+ICsgICAgICAgICAgICAgc25wcmlu
dGYoYnVmLCA5LCAiJTA4eCIsIGVudHJ5LT5mcmFtZSk7Cj4gPj4gKyAgICAgZWxzZQo+ID4+ICsg
ICAgICAgICAgICAgc25wcmludGYoYnVmLCA5LCAiWFhYWFhYWFgiKTsKPiA+Cj4gPiBTaG91bGQg
d2UgYWRkICIweCIgcHJlZml4IHRvIGFsbCB0aGVzZSBudW1iZXJzIHRvIG1ha2UgaXQgY2xlYXIg
dGhhdAo+ID4gdGhleSdyZSBpbiBmYWN0IGhleD8KPiAKPiBTb3VuZHMgbGlrZSBhIGdvb2QgaWRl
YSB0byBtZS4KPiAKPiA+PiArCj4gPj4gKyAgICAgZm9yIChpID0gMDsgaSA8IGNyYy0+dmFsdWVz
X2NudDsgaSsrKQo+ID4+ICsgICAgICAgICAgICAgc25wcmludGYoYnVmICsgc3RybGVuKGJ1Ziks
IDEwLCAiICUwOHgiLCBlbnRyeS0+Y3Jjc1tpXSk7Cj4gPgo+ID4gVGhlICduJyBpbiBzbnByaW50
ZigpIGhlcmUgc2VlbXMgcG9pbnRsZXNzLiBBcyBkb2VzIHRoZSBzdHJsZW4oKS4KPiAKPiBHb29k
Lgo+IAo+ID4+ICsgICAgIHNucHJpbnRmKGJ1ZiArIHN0cmxlbihidWYpLCAyLCAiXG4iKTsKPiA+
PiArCj4gPj4gKyAgICAgaWYgKGNvcHlfdG9fdXNlcih1c2VyX2J1ZiwgYnVmLCBzdHJsZW4oYnVm
KSArIDEpKQo+ID4+ICsgICAgICAgICAgICAgcmV0dXJuIC1FRkFVTFQ7Cj4gPj4gKwo+ID4+ICsg
ICAgIHJldHVybiBzdHJsZW4oYnVmKSArIDE7Cj4gPgo+ID4gTW9yZSBzdHJsZW4oKXMgdGhhdCBz
aG91bGRuJ3QgYmUgbmVlZGVkLgo+IAo+IE9rLgo+IAo+IFRoYW5rcyEKPiAKPiBUb21ldQoKLS0g
ClZpbGxlIFN5cmrDpGzDpApJbnRlbCBPVEMKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMu
ZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz
dGluZm8vZHJpLWRldmVsCg==