From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Daniel Kurtz <djkurtz@chromium.org>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [Intel-gfx] [PATCH v2 3/9] drm/plane-helper: Add drm_plane_helper_check_state()
Date: Mon, 8 Aug 2016 10:44:11 +0300 [thread overview]
Message-ID: <20160808074411.GZ4329@intel.com> (raw)
In-Reply-To: <CAGS+omA+EwuVqsGTafr9T7=itCyBDbSh_Dew3H9ptg=aq0eL-g@mail.gmail.com>
On Mon, Aug 08, 2016 at 03:29:24PM +0800, Daniel Kurtz wrote:
> Hi Ville,
>
> Two fixes inline...
>
> On Wed, Jul 27, 2016 at 1:34 AM, <ville.syrjala@linux.intel.com> wrote:
> >
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > Add a version of drm_plane_helper_check_update() which takes a plane
> > state instead of having the caller pass in everything.
> >
> > And to reduce code duplication, let's reimplement
> > drm_plane_helper_check_update() in terms of the new function, by
> > having a tempororary plane state on the stack.
> >
> > v2: Add a note that the functions modifies the state (Chris)
> >
> > Cc: Chris Wilson <chris@chris-wilson.co.uk>
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> [snip...]
>
> > +int drm_plane_helper_check_update(struct drm_plane *plane,
> > + struct drm_crtc *crtc,
> > + struct drm_framebuffer *fb,
> > + struct drm_rect *src,
> > + struct drm_rect *dst,
> > + const struct drm_rect *clip,
> > + unsigned int rotation,
> > + int min_scale,
> > + int max_scale,
> > + bool can_position,
> > + bool can_update_disabled,
> > + bool *visible)
> > +{
> > + struct drm_plane_state state = {
> > + .plane = plane,
> > + .crtc = crtc,
> > + .fb = fb,
> > + .src_x = src->x1,
> > + .src_y = src->x2,
>
> This should be:
> src->y1
>
> > + .src_w = drm_rect_width(src),
> > + .src_h = drm_rect_height(src),
> > + .crtc_x = dst->x1,
> > + .crtc_y = dst->x2,
>
> And this should be:
> dst->y1
Whoops. Copypaste fail, or something. Thanks for catching those.
--
Ville Syrjälä
Intel OTC
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-08-08 7:44 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-26 16:06 [PATCH 0/9] drm: Store clipped coordinates in drm_plane_state ville.syrjala
2016-07-26 16:06 ` [PATCH 1/9] drm: Warn about negative sizes when calculating scale factor ville.syrjala
2016-07-26 16:24 ` Chris Wilson
2016-07-26 16:39 ` Ville Syrjälä
2016-07-29 20:41 ` [Intel-gfx] " Sean Paul
2016-07-26 16:06 ` [PATCH 2/9] drm: Store clipped src/dst coordinatee in drm_plane_state ville.syrjala
2016-08-01 15:10 ` Sean Paul
2016-07-26 16:06 ` [PATCH 3/9] drm/plane-helper: Add drm_plane_helper_check_state() ville.syrjala
2016-07-26 16:33 ` Chris Wilson
2016-07-26 16:42 ` Ville Syrjälä
2016-07-27 7:22 ` [Intel-gfx] " Daniel Vetter
2016-07-26 17:34 ` [PATCH v2 " ville.syrjala
2016-08-01 15:10 ` [Intel-gfx] " Sean Paul
2016-08-08 7:29 ` Daniel Kurtz
2016-08-08 7:44 ` Ville Syrjälä [this message]
2016-08-08 7:55 ` [PATCH v3 " ville.syrjala
2016-07-26 16:06 ` [PATCH 4/9] drm/i915: Use drm_plane_state.{src,dst,visible} ville.syrjala
2016-07-26 16:20 ` Chris Wilson
2016-08-01 15:10 ` [PATCH 4/9] drm/i915: Use drm_plane_state.{src, dst, visible} Sean Paul
2016-07-26 16:07 ` [PATCH 5/9] drm/i915: Use drm_plane_helper_check_state() ville.syrjala
2016-08-01 15:10 ` Sean Paul
[not found] ` <1469549224-1860-1-git-send-email-ville.syrjala-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2016-07-26 16:07 ` [PATCH 6/9] drm/rockchip: Use drm_plane_state.{src,dst} ville.syrjala-VuQAYsv1563Yd54FQh9/CA
2016-07-27 1:08 ` Mark yao
2016-08-01 15:10 ` [Intel-gfx] [PATCH 6/9] drm/rockchip: Use drm_plane_state.{src, dst} Sean Paul
2016-07-26 16:07 ` [PATCH 7/9] drm/rockchip: Use drm_plane_helper_check_state() ville.syrjala
2016-07-27 1:09 ` Mark yao
2016-08-01 15:10 ` [Intel-gfx] " Sean Paul
2016-07-26 16:07 ` [PATCH 8/9] drm/mediatek: " ville.syrjala
2016-08-01 15:10 ` Sean Paul
2016-08-02 5:31 ` Bibby Hsieh
2016-08-02 5:45 ` CK Hu
2016-07-26 16:07 ` [PATCH 9/9] drm/simple_kms_helper: " ville.syrjala
2016-08-01 15:10 ` Sean Paul
2016-08-01 15:12 ` [PATCH 0/9] drm: Store clipped coordinates in drm_plane_state Sean Paul
2016-08-01 15:19 ` Ville Syrjälä
2016-08-02 13:24 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160808074411.GZ4329@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=djkurtz@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).