From: Daniel Vetter <daniel@ffwll.ch>
To: jiang.biao2@zte.com.cn
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [RESEND PATCH] drm/gma500: Fix comments in gtt.c
Date: Wed, 10 Aug 2016 10:35:29 +0200 [thread overview]
Message-ID: <20160810083529.GN6232@phenom.ffwll.local> (raw)
In-Reply-To: <OF2BC5E4E2.B7EF943A-ON4825800B.000B3B61-4825800B.0013AB7E@zte.com.cn>
On Wed, Aug 10, 2016 at 11:35:14AM +0800, jiang.biao2@zte.com.cn wrote:
>
> Fix some comment faults in gtt.c.
>
> Signed-off-by: Jiang Biao <jiang.biao2@zte.com.cn>
Sending the same patch 3 times in just one hour doesn't help - people
sometimes sleep, or are busy. Please let at least a few days pass until
you ping (with a reply) or resend.
Thanks, Daniel
> ---
> drivers/gpu/drm/gma500/gtt.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/gma500/gtt.c b/drivers/gpu/drm/gma500/gtt.c
> index 8f69225..9f9f588 100644
> --- a/drivers/gpu/drm/gma500/gtt.c
> +++ b/drivers/gpu/drm/gma500/gtt.c
> @@ -76,6 +76,7 @@ static u32 __iomem *psb_gtt_entry(struct drm_device *dev, struct gtt_range *r)
> * psb_gtt_insert - put an object into the GTT
> * @dev: our DRM device
> * @r: our GTT range
> + * @resume: on resume
> *
> * Take our preallocated GTT range and insert the GEM object into
> * the GTT. This is protected via the gtt mutex which the caller
> @@ -321,6 +322,7 @@ out:
> * @len: length (bytes) of address space required
> * @name: resource name
> * @backed: resource should be backed by stolen pages
> + * @align: requested alignment
> *
> * Ask the kernel core to find us a suitable range of addresses
> * to use for a GTT mapping.
> @@ -440,7 +442,6 @@ int psb_gtt_init(struct drm_device *dev, int resume)
> PSB_WVDC32(dev_priv->pge_ctl | _PSB_PGETBL_ENABLED, PSB_PGETBL_CTL);
> (void) PSB_RVDC32(PSB_PGETBL_CTL);
>
> - /* The root resource we allocate address space from */
> dev_priv->gtt_initialized = 1;
>
> pg->gtt_phys_start = dev_priv->pge_ctl & PAGE_MASK;
> --
> 2.1.0
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-08-10 8:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-10 3:35 [RESEND PATCH] drm/gma500: Fix comments in gtt.c jiang.biao2
2016-08-10 8:35 ` Daniel Vetter [this message]
2016-08-10 8:52 ` jiang.biao2
2016-08-10 9:22 ` Daniel Vetter
2016-08-11 0:45 ` 答复: " jiang.biao2
-- strict thread matches above, loose matches on Subject: below --
2016-08-10 2:18 jiang.biao2
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160810083529.GN6232@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jiang.biao2@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox