From: Gustavo Padovan <gustavo@padovan.org>
To: Pavel Machek <pavel@ucw.cz>
Cc: devel@driverdev.osuosl.org,
"Daniel Stone" <daniels@collabora.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
"Arve Hjønnevåg" <arve@android.com>,
"Daniel Vetter" <daniel.vetter@ffwll.ch>,
"Riley Andrews" <riandrews@android.com>,
"Gustavo Padovan" <gustavo.padovan@collabora.co.uk>,
"John Harrison" <John.C.Harrison@Intel.com>
Subject: Re: [PATCH v2 1/6] staging/android: remove doc from sw_sync
Date: Thu, 11 Aug 2016 12:06:01 -0300 [thread overview]
Message-ID: <20160811150601.GE2478@joana> (raw)
In-Reply-To: <20160808234139.GD2946@xo-6d-61-c0.localdomain>
Hi Pavel,
2016-08-09 Pavel Machek <pavel@ucw.cz>:
> On Mon 2016-08-08 18:24:17, Gustavo Padovan wrote:
> > From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
> >
> > SW_SYNC should never be used by other pieces of the kernel apart from
> > sync_debug as it is only a Sync File Validation Framework, so hide any
> > info to avoid confuse this with a standard kernel internal API.
>
> > Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
>
> NAK.
>
> It is unclear for what the code does, removing the docs is not going to help.
>
> If it should not be used, document that it should not be used.. but not remove
> the docs.
Okay, I'll skip this patch.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-08-11 15:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-08 21:24 [PATCH v2 0/6] de-stage SW_SYNC validation frawework Gustavo Padovan
2016-08-08 21:24 ` [PATCH v2 1/6] staging/android: remove doc from sw_sync Gustavo Padovan
2016-08-08 23:41 ` Pavel Machek
2016-08-11 15:06 ` Gustavo Padovan [this message]
2016-08-08 21:24 ` [PATCH v2 2/6] staging/android: do not let userspace trigger WARN_ON Gustavo Padovan
2016-08-08 21:24 ` [PATCH v2 3/6] staging/android: move trace/sync.h to sync_trace.h Gustavo Padovan
2016-08-11 9:41 ` Eric Engestrom
2016-08-08 21:24 ` [PATCH v2 4/6] staging/android: prepare sw_sync files for de-staging Gustavo Padovan
2016-08-11 9:42 ` Eric Engestrom
2016-08-08 21:24 ` [PATCH v2 5/6] staging/android: add Doc for SW_SYNC ioctl interface Gustavo Padovan
2016-08-11 9:43 ` Eric Engestrom
2016-08-08 21:24 ` [PATCH v2 6/6] dma-buf/sw_sync: de-stage SW_SYNC Gustavo Padovan
2016-08-11 9:56 ` Eric Engestrom
2016-08-11 9:24 ` [PATCH v2 0/6] de-stage SW_SYNC validation frawework Eric Engestrom
2016-08-11 15:09 ` Gustavo Padovan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160811150601.GE2478@joana \
--to=gustavo@padovan.org \
--cc=John.C.Harrison@Intel.com \
--cc=arve@android.com \
--cc=daniel.vetter@ffwll.ch \
--cc=daniels@collabora.com \
--cc=devel@driverdev.osuosl.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=gustavo.padovan@collabora.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=riandrews@android.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).